mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH v2] mtd: nand: Add help text for i.MX NAND controllers
@ 2021-05-27  8:37 Trent Piepho
  2021-05-31  7:14 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Trent Piepho @ 2021-05-27  8:37 UTC (permalink / raw)
  To: barebox; +Cc: Trent Piepho

There are two different NAND drivers, used for different chips in the
i.MX range.  It's quite confusing as to which to use.  Add some help
text to clarify.

Signed-off-by: Trent Piepho <tpiepho@gmail.com>
---
Changes from V1:
  Add GPMI and NFC names, fix typos.

 drivers/mtd/nand/Kconfig | 17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)

diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
index 7c9326089..8fb1cedd6 100644
--- a/drivers/mtd/nand/Kconfig
+++ b/drivers/mtd/nand/Kconfig
@@ -32,14 +32,27 @@ config NAND_ALLOW_ERASE_BAD
 
 config NAND_IMX
 	bool
-	prompt "i.MX NAND driver"
+	prompt "i.MX21 to 53 NAND driver aka 'mxc', for NFC"
 	depends on ARCH_IMX
+	help
+	  Support for NAND flash on Freescale/NXP i.MX devices.  This is for the
+	  "MXC" series:  i.MX21/25/27/31/35/51/53.
+
+	  This is not for the "MXS" series i.MX processors (23 & 28), or i.MX6
+	  and later, which use the GPMI NAND controller from the MXS series. 
+	  See the i.MX 'mxs' driver for those chips.
 
 config NAND_MXS
 	bool
 	select STMP_DEVICE
-	prompt "i.MX23/28/6 NAND driver"
+	prompt "i.MX23/28 & 6+ NAND driver aka 'mxs', for GPMI"
 	depends on MXS_APBH_DMA
+	help
+	  Support for NAND flash on Freescale/NXP i.MX devices.	 This is for the
+	  "MXS" series:  i.MX23/28 and all i.MX6 and later SoCs.
+
+	  This is not for the "MXC" series of i.MX processors in the i.MX21 to
+	  i.MX53 range.  See the i.MX "mxc" driver for those chips.
 
 config NAND_OMAP_GPMC
 	tristate "NAND Flash Support for GPMC based OMAP platforms"
-- 
2.26.2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] mtd: nand: Add help text for i.MX NAND controllers
  2021-05-27  8:37 [PATCH v2] mtd: nand: Add help text for i.MX NAND controllers Trent Piepho
@ 2021-05-31  7:14 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2021-05-31  7:14 UTC (permalink / raw)
  To: Trent Piepho; +Cc: barebox

On Thu, May 27, 2021 at 01:37:41AM -0700, Trent Piepho wrote:
> There are two different NAND drivers, used for different chips in the
> i.MX range.  It's quite confusing as to which to use.  Add some help
> text to clarify.
> 
> Signed-off-by: Trent Piepho <tpiepho@gmail.com>
> ---
> Changes from V1:
>   Add GPMI and NFC names, fix typos.

Applied, thanks

Sascha

> 
>  drivers/mtd/nand/Kconfig | 17 +++++++++++++++--
>  1 file changed, 15 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
> index 7c9326089..8fb1cedd6 100644
> --- a/drivers/mtd/nand/Kconfig
> +++ b/drivers/mtd/nand/Kconfig
> @@ -32,14 +32,27 @@ config NAND_ALLOW_ERASE_BAD
>  
>  config NAND_IMX
>  	bool
> -	prompt "i.MX NAND driver"
> +	prompt "i.MX21 to 53 NAND driver aka 'mxc', for NFC"
>  	depends on ARCH_IMX
> +	help
> +	  Support for NAND flash on Freescale/NXP i.MX devices.  This is for the
> +	  "MXC" series:  i.MX21/25/27/31/35/51/53.
> +
> +	  This is not for the "MXS" series i.MX processors (23 & 28), or i.MX6
> +	  and later, which use the GPMI NAND controller from the MXS series. 
> +	  See the i.MX 'mxs' driver for those chips.
>  
>  config NAND_MXS
>  	bool
>  	select STMP_DEVICE
> -	prompt "i.MX23/28/6 NAND driver"
> +	prompt "i.MX23/28 & 6+ NAND driver aka 'mxs', for GPMI"
>  	depends on MXS_APBH_DMA
> +	help
> +	  Support for NAND flash on Freescale/NXP i.MX devices.	 This is for the
> +	  "MXS" series:  i.MX23/28 and all i.MX6 and later SoCs.
> +
> +	  This is not for the "MXC" series of i.MX processors in the i.MX21 to
> +	  i.MX53 range.  See the i.MX "mxc" driver for those chips.
>  
>  config NAND_OMAP_GPMC
>  	tristate "NAND Flash Support for GPMC based OMAP platforms"
> -- 
> 2.26.2
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-05-31  7:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-27  8:37 [PATCH v2] mtd: nand: Add help text for i.MX NAND controllers Trent Piepho
2021-05-31  7:14 ` Sascha Hauer

mail archive of the barebox mailing list

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://lore.barebox.org/barebox/0 barebox/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 barebox barebox/ https://lore.barebox.org/barebox \
		barebox@lists.infradead.org barebox@lists.infradead.org
	public-inbox-index barebox

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git