From: Sascha Hauer <sha@pengutronix.de> To: Marc Kleine-Budde <mkl@pengutronix.de> Cc: barebox@lists.infradead.org, Roland Hieber <rhi@pengutronix.de> Subject: Re: [PATCH] habv4: habv4_get_status(): do not print HAB error event in case of known RNG self test failure Date: Sun, 18 Jul 2021 07:09:04 +0200 Message-ID: <20210718050904.GG9782@pengutronix.de> (raw) In-Reply-To: <20210716122110.4022409-1-mkl@pengutronix.de> On Fri, Jul 16, 2021 at 02:21:10PM +0200, Marc Kleine-Budde wrote: > In commit > > | 655e085e3a22 ("crypto: caam - Always do rng selftest") > > the kconfig option CONFIG_CRYPTO_DEV_FSL_CAAM_RNG_SELF_TEST was > removed, which resulted in the pr_debug() never being executed. Remove > the IS_ENABLED() to restore the original behavior, i.e. to not print > the HAB error Event if it is the known RNG self-test failure. > > Fixes: 655e085e3a22 ("crypto: caam - Always do rng selftest") > Reported-by: Roland Hieber <rhi@pengutronix.de> > Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de> > --- > drivers/hab/habv4.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Applied, thanks Sascha > > diff --git a/drivers/hab/habv4.c b/drivers/hab/habv4.c > index c2acb81369d8..d58768fa5481 100644 > --- a/drivers/hab/habv4.c > +++ b/drivers/hab/habv4.c > @@ -553,8 +553,7 @@ static int habv4_get_status(const struct habv4_rvt *rvt) > break; > > /* suppress RNG self-test fail events if they can be handled in software */ > - if (IS_ENABLED(CONFIG_CRYPTO_DEV_FSL_CAAM_RNG_SELF_TEST) && > - is_known_rng_fail_event(data, len)) { > + if (is_known_rng_fail_event(data, len)) { > pr_debug("RNG self-test failure detected, will run software self-test\n"); > } else { > pr_err("-------- HAB Event %d --------\n", i); > -- > 2.30.2 > > > > _______________________________________________ > barebox mailing list > barebox@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/barebox > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2021-07-18 5:10 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-16 12:21 Marc Kleine-Budde 2021-07-16 13:00 ` Rouven Czerwinski 2021-07-18 5:09 ` Sascha Hauer [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210718050904.GG9782@pengutronix.de \ --to=sha@pengutronix.de \ --cc=barebox@lists.infradead.org \ --cc=mkl@pengutronix.de \ --cc=rhi@pengutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
mail archive of the barebox mailing list This inbox may be cloned and mirrored by anyone: git clone --mirror https://lore.barebox.org/barebox/0 barebox/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 barebox barebox/ https://lore.barebox.org/barebox \ barebox@lists.infradead.org barebox@lists.infradead.org public-inbox-index barebox Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git