mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Rouven Czerwinski <r.czerwinski@pengutronix.de>
To: Marc Kleine-Budde <mkl@pengutronix.de>, barebox@lists.infradead.org
Cc: Roland Hieber <rhi@pengutronix.de>
Subject: Re: [PATCH] habv4: habv4_get_status(): do not print HAB error event in case of known RNG self test failure
Date: Fri, 16 Jul 2021 15:00:56 +0200	[thread overview]
Message-ID: <2eede6ab254bdf6f66ff40dfd8f4ba7d11bf04ec.camel@pengutronix.de> (raw)
In-Reply-To: <20210716122110.4022409-1-mkl@pengutronix.de>

On Fri, 2021-07-16 at 14:21 +0200, Marc Kleine-Budde wrote:
> In commit
> 
> > 655e085e3a22 ("crypto: caam - Always do rng selftest")
> 
> the kconfig option CONFIG_CRYPTO_DEV_FSL_CAAM_RNG_SELF_TEST was
> removed, which resulted in the pr_debug() never being executed. Remove
> the IS_ENABLED() to restore the original behavior, i.e. to not print
> the HAB error Event if it is the known RNG self-test failure.
> 
> Fixes: 655e085e3a22 ("crypto: caam - Always do rng selftest")
> Reported-by: Roland Hieber <rhi@pengutronix.de>
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> ---
>  drivers/hab/habv4.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/hab/habv4.c b/drivers/hab/habv4.c
> index c2acb81369d8..d58768fa5481 100644
> --- a/drivers/hab/habv4.c
> +++ b/drivers/hab/habv4.c
> @@ -553,8 +553,7 @@ static int habv4_get_status(const struct habv4_rvt *rvt)
>  			break;
>  
>  		/* suppress RNG self-test fail events if they can be handled in software */
> -		if (IS_ENABLED(CONFIG_CRYPTO_DEV_FSL_CAAM_RNG_SELF_TEST) &&
> -		    is_known_rng_fail_event(data, len)) {
> +		if (is_known_rng_fail_event(data, len)) {
>  			pr_debug("RNG self-test failure detected, will run software self-test\n");
>  		} else {
>  			pr_err("-------- HAB Event %d --------\n", i);

Reviewed-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>

However I wonder if we need the pr_debug at all, since the selftests
are now always run, regardless of the HAB error. But I guess it's nice
to note that we detected the error and ran the software selftests.

- rcz


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


  reply	other threads:[~2021-07-16 13:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-16 12:21 Marc Kleine-Budde
2021-07-16 13:00 ` Rouven Czerwinski [this message]
2021-07-18  5:09 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2eede6ab254bdf6f66ff40dfd8f4ba7d11bf04ec.camel@pengutronix.de \
    --to=r.czerwinski@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=mkl@pengutronix.de \
    --cc=rhi@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox