[PATCH] scripts: bareboxenv: add erase hint if build as host-tool

[PATCH] scripts: bareboxenv: add erase hint if build as host-tool

[Marco Felsch]

The bareboxenv behviour is different if used as host-tool. As host-tool
the erase is skipped which can confuse the user. Add a help note as hot
fix. In the long term we should add the host-tool erase support as well.

Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
 scripts/bareboxenv.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/scripts/bareboxenv.c b/scripts/bareboxenv.c
index bdff644335..f1706a5e17 100644
--- a/scripts/bareboxenv.c
+++ b/scripts/bareboxenv.c
@@ -98,6 +98,12 @@ static void usage(char *prgname)
 	printf( "Usage : %s [OPTION] DIRECTORY FILE\n"
 		"Load a barebox environment sector into a directory or\n"
 		"save a directory into a barebox environment sector\n"
+#ifndef __BAREBOX__
+		"\n"
+		"Attention:\n"
+		"Depending on your environment backend storage you need to\n"
+		"erase FILE before you save the new environment.\n"
+#endif
 		"\n"
 		"options:\n"
 		"  -s        save (directory -> environment sector)\n"
-- 
2.30.2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] scripts: bareboxenv: add erase hint if build as host-tool

[Sascha Hauer]

On Fri, Aug 06, 2021 at 11:33:37AM +0200, Marco Felsch wrote:
> The bareboxenv behviour is different if used as host-tool. As host-tool
> the erase is skipped which can confuse the user. Add a help note as hot
> fix. In the long term we should add the host-tool erase support as well.
> 
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
>  scripts/bareboxenv.c | 6 ++++++
>  1 file changed, 6 insertions(+)

Applied, thanks

Sascha

> 
> diff --git a/scripts/bareboxenv.c b/scripts/bareboxenv.c
> index bdff644335..f1706a5e17 100644
> --- a/scripts/bareboxenv.c
> +++ b/scripts/bareboxenv.c
> @@ -98,6 +98,12 @@ static void usage(char *prgname)
>  	printf( "Usage : %s [OPTION] DIRECTORY FILE\n"
>  		"Load a barebox environment sector into a directory or\n"
>  		"save a directory into a barebox environment sector\n"
> +#ifndef __BAREBOX__
> +		"\n"
> +		"Attention:\n"
> +		"Depending on your environment backend storage you need to\n"
> +		"erase FILE before you save the new environment.\n"
> +#endif
>  		"\n"
>  		"options:\n"
>  		"  -s        save (directory -> environment sector)\n"
> -- 
> 2.30.2
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox