mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] scripts: bareboxenv: add erase hint if build as host-tool
@ 2021-08-06  9:33 Marco Felsch
  2021-08-09 17:56 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Marco Felsch @ 2021-08-06  9:33 UTC (permalink / raw)
  To: barebox

The bareboxenv behviour is different if used as host-tool. As host-tool
the erase is skipped which can confuse the user. Add a help note as hot
fix. In the long term we should add the host-tool erase support as well.

Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
 scripts/bareboxenv.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/scripts/bareboxenv.c b/scripts/bareboxenv.c
index bdff644335..f1706a5e17 100644
--- a/scripts/bareboxenv.c
+++ b/scripts/bareboxenv.c
@@ -98,6 +98,12 @@ static void usage(char *prgname)
 	printf( "Usage : %s [OPTION] DIRECTORY FILE\n"
 		"Load a barebox environment sector into a directory or\n"
 		"save a directory into a barebox environment sector\n"
+#ifndef __BAREBOX__
+		"\n"
+		"Attention:\n"
+		"Depending on your environment backend storage you need to\n"
+		"erase FILE before you save the new environment.\n"
+#endif
 		"\n"
 		"options:\n"
 		"  -s        save (directory -> environment sector)\n"
-- 
2.30.2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] scripts: bareboxenv: add erase hint if build as host-tool
  2021-08-06  9:33 [PATCH] scripts: bareboxenv: add erase hint if build as host-tool Marco Felsch
@ 2021-08-09 17:56 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2021-08-09 17:56 UTC (permalink / raw)
  To: Marco Felsch; +Cc: barebox

On Fri, Aug 06, 2021 at 11:33:37AM +0200, Marco Felsch wrote:
> The bareboxenv behviour is different if used as host-tool. As host-tool
> the erase is skipped which can confuse the user. Add a help note as hot
> fix. In the long term we should add the host-tool erase support as well.
> 
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
>  scripts/bareboxenv.c | 6 ++++++
>  1 file changed, 6 insertions(+)

Applied, thanks

Sascha

> 
> diff --git a/scripts/bareboxenv.c b/scripts/bareboxenv.c
> index bdff644335..f1706a5e17 100644
> --- a/scripts/bareboxenv.c
> +++ b/scripts/bareboxenv.c
> @@ -98,6 +98,12 @@ static void usage(char *prgname)
>  	printf( "Usage : %s [OPTION] DIRECTORY FILE\n"
>  		"Load a barebox environment sector into a directory or\n"
>  		"save a directory into a barebox environment sector\n"
> +#ifndef __BAREBOX__
> +		"\n"
> +		"Attention:\n"
> +		"Depending on your environment backend storage you need to\n"
> +		"erase FILE before you save the new environment.\n"
> +#endif
>  		"\n"
>  		"options:\n"
>  		"  -s        save (directory -> environment sector)\n"
> -- 
> 2.30.2
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-08-09 17:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-06  9:33 [PATCH] scripts: bareboxenv: add erase hint if build as host-tool Marco Felsch
2021-08-09 17:56 ` Sascha Hauer

mail archive of the barebox mailing list

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://lore.barebox.org/barebox/0 barebox/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 barebox barebox/ https://lore.barebox.org/barebox \
		barebox@lists.infradead.org barebox@lists.infradead.org
	public-inbox-index barebox

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git