mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH master] ARM: at91: fix building samad2 images without sama5d3
@ 2021-07-22 12:41 Ahmad Fatoum
  2021-08-09 18:37 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2021-07-22 12:41 UTC (permalink / raw)
  To: barebox; +Cc: ore, Ahmad Fatoum

Addition of first stage support for SAMA5D3 added a dependency
between sama5d2 and sama5d3 first stages: They both needed to be
enabled to generate images for either. Break up this dependency
to fix build failures for configs that e.g. only build one SoC.

Fixes: e30fb46597d3 ("ARM: at91: xload-mmc: add sama5d3_atmci_start_image() helper")
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 arch/arm/mach-at91/Kconfig | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/arch/arm/mach-at91/Kconfig b/arch/arm/mach-at91/Kconfig
index 28a82c1a9351..290178706a40 100644
--- a/arch/arm/mach-at91/Kconfig
+++ b/arch/arm/mach-at91/Kconfig
@@ -44,10 +44,7 @@ config HAVE_AT91_DDRAMC
 	bool
 
 config AT91_MCI_PBL
-	bool
-	depends on MCI_ATMEL_PBL
-	depends on MCI_ATMEL_SDHCI_PBL
-	default y
+	def_bool MCI_ATMEL_PBL || MCI_ATMEL_SDHCI_PBL
 
 # Select if board uses the common at91sam926x_board_init
 config AT91SAM926X_BOARD_INIT
-- 
2.30.2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH master] ARM: at91: fix building samad2 images without sama5d3
  2021-07-22 12:41 [PATCH master] ARM: at91: fix building samad2 images without sama5d3 Ahmad Fatoum
@ 2021-08-09 18:37 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2021-08-09 18:37 UTC (permalink / raw)
  To: Ahmad Fatoum; +Cc: barebox, ore

On Thu, Jul 22, 2021 at 02:41:37PM +0200, Ahmad Fatoum wrote:
> Addition of first stage support for SAMA5D3 added a dependency
> between sama5d2 and sama5d3 first stages: They both needed to be
> enabled to generate images for either. Break up this dependency
> to fix build failures for configs that e.g. only build one SoC.
> 
> Fixes: e30fb46597d3 ("ARM: at91: xload-mmc: add sama5d3_atmci_start_image() helper")
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  arch/arm/mach-at91/Kconfig | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)

Applied, thanks

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-08-09 18:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-22 12:41 [PATCH master] ARM: at91: fix building samad2 images without sama5d3 Ahmad Fatoum
2021-08-09 18:37 ` Sascha Hauer

mail archive of the barebox mailing list

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://lore.barebox.org/barebox/0 barebox/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 barebox barebox/ https://lore.barebox.org/barebox \
		barebox@lists.infradead.org barebox@lists.infradead.org
	public-inbox-index barebox

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git