mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] mci: Improve error message for non-existent vmmc regulator
@ 2021-09-14  9:00 Uwe Kleine-König
  2021-09-14 11:22 ` Rouven Czerwinski
  2021-10-02  9:27 ` Sascha Hauer
  0 siblings, 2 replies; 3+ messages in thread
From: Uwe Kleine-König @ 2021-09-14  9:00 UTC (permalink / raw)
  To: barebox

There are three improvements: a) Use a already initialized device as first
parameter to dev_err() and b) indicate that the error will be ignored, and
c) downgrade to a warning.

This changes the error message from

	ERROR: <NULL>: Failed to get 'vmmc' regulator.

to

	WARNING: bcm2835_mci fe340000.mmc@7e340000.of: Failed to get 'vmmc' regulator (ignored).

on a Raspberry Pi 4.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 drivers/mci/mci-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mci/mci-core.c b/drivers/mci/mci-core.c
index 92a73c8f1dfe..82e2f82f5377 100644
--- a/drivers/mci/mci-core.c
+++ b/drivers/mci/mci-core.c
@@ -1920,7 +1920,7 @@ int mci_register(struct mci_host *host)
 
 	host->supply = regulator_get(hw_dev, "vmmc");
 	if (IS_ERR(host->supply)) {
-		dev_err(&mci->dev, "Failed to get 'vmmc' regulator.\n");
+		dev_warn(hw_dev, "Failed to get 'vmmc' regulator (ignored).\n");
 		host->supply = NULL;
 	}
 
-- 
2.30.2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] mci: Improve error message for non-existent vmmc regulator
  2021-09-14  9:00 [PATCH] mci: Improve error message for non-existent vmmc regulator Uwe Kleine-König
@ 2021-09-14 11:22 ` Rouven Czerwinski
  2021-10-02  9:27 ` Sascha Hauer
  1 sibling, 0 replies; 3+ messages in thread
From: Rouven Czerwinski @ 2021-09-14 11:22 UTC (permalink / raw)
  To: Uwe Kleine-König, barebox

On Tue, 2021-09-14 at 11:00 +0200, Uwe Kleine-König wrote:
> There are three improvements: a) Use a already initialized device as first
> parameter to dev_err() and b) indicate that the error will be ignored, and
> c) downgrade to a warning.
> 
> This changes the error message from
> 
> 	ERROR: <NULL>: Failed to get 'vmmc' regulator.
> 
> to
> 
> 	WARNING: bcm2835_mci fe340000.mmc@7e340000.of: Failed to get 'vmmc' regulator (ignored).
> 
> on a Raspberry Pi 4.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  drivers/mci/mci-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mci/mci-core.c b/drivers/mci/mci-core.c
> index 92a73c8f1dfe..82e2f82f5377 100644
> --- a/drivers/mci/mci-core.c
> +++ b/drivers/mci/mci-core.c
> @@ -1920,7 +1920,7 @@ int mci_register(struct mci_host *host)
>  
>  	host->supply = regulator_get(hw_dev, "vmmc");
>  	if (IS_ERR(host->supply)) {
> -		dev_err(&mci->dev, "Failed to get 'vmmc' regulator.\n");
> +		dev_warn(hw_dev, "Failed to get 'vmmc' regulator (ignored).\n");
>  		host->supply = NULL;
>  	}
>  

Reviewed-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] mci: Improve error message for non-existent vmmc regulator
  2021-09-14  9:00 [PATCH] mci: Improve error message for non-existent vmmc regulator Uwe Kleine-König
  2021-09-14 11:22 ` Rouven Czerwinski
@ 2021-10-02  9:27 ` Sascha Hauer
  1 sibling, 0 replies; 3+ messages in thread
From: Sascha Hauer @ 2021-10-02  9:27 UTC (permalink / raw)
  To: Uwe Kleine-König; +Cc: barebox

On Tue, Sep 14, 2021 at 11:00:17AM +0200, Uwe Kleine-König wrote:
> There are three improvements: a) Use a already initialized device as first
> parameter to dev_err() and b) indicate that the error will be ignored, and
> c) downgrade to a warning.
> 
> This changes the error message from
> 
> 	ERROR: <NULL>: Failed to get 'vmmc' regulator.
> 
> to
> 
> 	WARNING: bcm2835_mci fe340000.mmc@7e340000.of: Failed to get 'vmmc' regulator (ignored).
> 
> on a Raspberry Pi 4.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  drivers/mci/mci-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-10-02  9:29 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-14  9:00 [PATCH] mci: Improve error message for non-existent vmmc regulator Uwe Kleine-König
2021-09-14 11:22 ` Rouven Czerwinski
2021-10-02  9:27 ` Sascha Hauer

mail archive of the barebox mailing list

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://lore.barebox.org/barebox/0 barebox/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 barebox barebox/ https://lore.barebox.org/barebox \
		barebox@lists.infradead.org
	public-inbox-index barebox

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git