mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] fs: remove unused struct fs_device_d::parent_device
@ 2021-09-13  8:30 Ahmad Fatoum
  2021-09-14  8:55 ` Roland Hieber
  2021-10-04 10:44 ` Sascha Hauer
  0 siblings, 2 replies; 5+ messages in thread
From: Ahmad Fatoum @ 2021-09-13  8:30 UTC (permalink / raw)
  To: barebox; +Cc: Ahmad Fatoum

The parent_device member is unused anywhere, so drop it.

Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
---
 fs/fs.c      | 1 -
 include/fs.h | 1 -
 2 files changed, 2 deletions(-)

diff --git a/fs/fs.c b/fs/fs.c
index b6431227d60c..e6fd57b8ac97 100644
--- a/fs/fs.c
+++ b/fs/fs.c
@@ -813,7 +813,6 @@ int fsdev_open_cdev(struct fs_device_d *fsdev)
 	}
 
 	fsdev->dev.parent = fsdev->cdev->dev;
-	fsdev->parent_device = fsdev->cdev->dev;
 
 	return 0;
 }
diff --git a/include/fs.h b/include/fs.h
index 5811199c0161..cd5eb571e08e 100644
--- a/include/fs.h
+++ b/include/fs.h
@@ -101,7 +101,6 @@ struct fs_device_d {
 	struct cdev *cdev;
 	bool loop;
 	char *path;
-	struct device_d *parent_device;
 	struct list_head list;
 	char *options;
 	char *linux_rootarg;
-- 
2.33.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] fs: remove unused struct fs_device_d::parent_device
  2021-09-13  8:30 [PATCH] fs: remove unused struct fs_device_d::parent_device Ahmad Fatoum
@ 2021-09-14  8:55 ` Roland Hieber
  2021-09-14  9:02   ` Ahmad Fatoum
  2021-10-04 10:44 ` Sascha Hauer
  1 sibling, 1 reply; 5+ messages in thread
From: Roland Hieber @ 2021-09-14  8:55 UTC (permalink / raw)
  To: Ahmad Fatoum; +Cc: barebox

On Mon, Sep 13, 2021 at 10:30:19AM +0200, Ahmad Fatoum wrote:
> The parent_device member is unused anywhere, so drop it.

s/is/isn't/?

> 
> Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
> ---
>  fs/fs.c      | 1 -
>  include/fs.h | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/fs/fs.c b/fs/fs.c
> index b6431227d60c..e6fd57b8ac97 100644
> --- a/fs/fs.c
> +++ b/fs/fs.c
> @@ -813,7 +813,6 @@ int fsdev_open_cdev(struct fs_device_d *fsdev)
>  	}
>  
>  	fsdev->dev.parent = fsdev->cdev->dev;
> -	fsdev->parent_device = fsdev->cdev->dev;
>  
>  	return 0;
>  }
> diff --git a/include/fs.h b/include/fs.h
> index 5811199c0161..cd5eb571e08e 100644
> --- a/include/fs.h
> +++ b/include/fs.h
> @@ -101,7 +101,6 @@ struct fs_device_d {
>  	struct cdev *cdev;
>  	bool loop;
>  	char *path;
> -	struct device_d *parent_device;
>  	struct list_head list;
>  	char *options;
>  	char *linux_rootarg;
> -- 
> 2.33.0
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Roland Hieber, Pengutronix e.K.          | r.hieber@pengutronix.de     |
Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] fs: remove unused struct fs_device_d::parent_device
  2021-09-14  8:55 ` Roland Hieber
@ 2021-09-14  9:02   ` Ahmad Fatoum
  2021-09-14 10:10     ` Roland Hieber
  0 siblings, 1 reply; 5+ messages in thread
From: Ahmad Fatoum @ 2021-09-14  9:02 UTC (permalink / raw)
  To: Roland Hieber, Ahmad Fatoum; +Cc: barebox

On 14.09.21 10:55, Roland Hieber wrote:
> On Mon, Sep 13, 2021 at 10:30:19AM +0200, Ahmad Fatoum wrote:
>> The parent_device member is unused anywhere, so drop it.
> 
> s/is/isn't/?

is unused == isn't used..?

> 
>>
>> Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
>> ---
>>  fs/fs.c      | 1 -
>>  include/fs.h | 1 -
>>  2 files changed, 2 deletions(-)
>>
>> diff --git a/fs/fs.c b/fs/fs.c
>> index b6431227d60c..e6fd57b8ac97 100644
>> --- a/fs/fs.c
>> +++ b/fs/fs.c
>> @@ -813,7 +813,6 @@ int fsdev_open_cdev(struct fs_device_d *fsdev)
>>  	}
>>  
>>  	fsdev->dev.parent = fsdev->cdev->dev;
>> -	fsdev->parent_device = fsdev->cdev->dev;
>>  
>>  	return 0;
>>  }
>> diff --git a/include/fs.h b/include/fs.h
>> index 5811199c0161..cd5eb571e08e 100644
>> --- a/include/fs.h
>> +++ b/include/fs.h
>> @@ -101,7 +101,6 @@ struct fs_device_d {
>>  	struct cdev *cdev;
>>  	bool loop;
>>  	char *path;
>> -	struct device_d *parent_device;
>>  	struct list_head list;
>>  	char *options;
>>  	char *linux_rootarg;
>> -- 
>> 2.33.0
>>
>>
>> _______________________________________________
>> barebox mailing list
>> barebox@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/barebox
>>
> 


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] fs: remove unused struct fs_device_d::parent_device
  2021-09-14  9:02   ` Ahmad Fatoum
@ 2021-09-14 10:10     ` Roland Hieber
  0 siblings, 0 replies; 5+ messages in thread
From: Roland Hieber @ 2021-09-14 10:10 UTC (permalink / raw)
  To: Ahmad Fatoum; +Cc: Ahmad Fatoum, barebox

On Tue, Sep 14, 2021 at 11:02:23AM +0200, Ahmad Fatoum wrote:
> On 14.09.21 10:55, Roland Hieber wrote:
> > On Mon, Sep 13, 2021 at 10:30:19AM +0200, Ahmad Fatoum wrote:
> >> The parent_device member is unused anywhere, so drop it.
> > 
> > s/is/isn't/?
> 
> is unused == isn't used..?

Yes. Sorry. Not enough coffee.

 - Roland

-- 
Roland Hieber, Pengutronix e.K.          | r.hieber@pengutronix.de     |
Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] fs: remove unused struct fs_device_d::parent_device
  2021-09-13  8:30 [PATCH] fs: remove unused struct fs_device_d::parent_device Ahmad Fatoum
  2021-09-14  8:55 ` Roland Hieber
@ 2021-10-04 10:44 ` Sascha Hauer
  1 sibling, 0 replies; 5+ messages in thread
From: Sascha Hauer @ 2021-10-04 10:44 UTC (permalink / raw)
  To: Ahmad Fatoum; +Cc: barebox

On Mon, Sep 13, 2021 at 10:30:19AM +0200, Ahmad Fatoum wrote:
> The parent_device member is unused anywhere, so drop it.
> 
> Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
> ---
>  fs/fs.c      | 1 -
>  include/fs.h | 1 -
>  2 files changed, 2 deletions(-)

Applied, thanks

Sascha


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-10-04 10:45 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-13  8:30 [PATCH] fs: remove unused struct fs_device_d::parent_device Ahmad Fatoum
2021-09-14  8:55 ` Roland Hieber
2021-09-14  9:02   ` Ahmad Fatoum
2021-09-14 10:10     ` Roland Hieber
2021-10-04 10:44 ` Sascha Hauer

mail archive of the barebox mailing list

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://lore.barebox.org/barebox/0 barebox/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 barebox barebox/ https://lore.barebox.org/barebox \
		barebox@lists.infradead.org
	public-inbox-index barebox

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git