mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* inkscape 1.1.1 issue
@ 2021-10-06 10:58 Antony Pavlov
  2021-10-06 11:19 ` Ahmad Fatoum
  2021-10-07 11:52 ` [RFC PATCH] logo: Makefile: Replace inkscape with convert Jules Maselbas
  0 siblings, 2 replies; 7+ messages in thread
From: Antony Pavlov @ 2021-10-06 10:58 UTC (permalink / raw)
  To: barebox

Hi!

I have just update inkscape from Debian repo.
It looks like inkscape-1.1.1 has new unexpected behaviour.

During barebox sandbox build process I have faced with unexpected
inkscape dialog. Also the '--without-gui=' option is depricated.
See my build log

barebox$ make
...
Warning: Option --without-gui= is deprecated
Unable to init server: Could not connect: Connection refused
Background RRGGBBAA: ffffff00
Area 0:0:3000:1500 exported to 640 x 320 pixels (20.48 dpi)
  LOGO.S   lib/logo/barebox-logo-w640.bblogo.S
  AS      lib/logo/barebox-logo-w640.bblogo.o
  AR      lib/logo/built-in.a
  AR      lib/built-in.a
  GEN     .version
  CHK     include/generated/compile.h
  UPD     include/generated/compile.h
  CC      common/version.o
  CC      common/imd-barebox.o
  AR      common/built-in.a
  LD      barebox
  SYSMAP  System.map
  OBJCOPY barebox.bin
  CHKFILESIZE barebox.bin
  LN      barebox-flash-image
antony@cinco:~/barebox$ dpkg -l | grep inkscape
ii  inkscape                                     1.1.1-2                                   amd64        vector-based drawing program

-- 
Best regards,
  Antony Pavlov

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: inkscape 1.1.1 issue
  2021-10-06 10:58 inkscape 1.1.1 issue Antony Pavlov
@ 2021-10-06 11:19 ` Ahmad Fatoum
  2021-10-07  9:24   ` Ian Abbott
  2021-10-07  9:49   ` Jules Maselbas
  2021-10-07 11:52 ` [RFC PATCH] logo: Makefile: Replace inkscape with convert Jules Maselbas
  1 sibling, 2 replies; 7+ messages in thread
From: Ahmad Fatoum @ 2021-10-06 11:19 UTC (permalink / raw)
  To: Antony Pavlov, barebox

Hello Antony,

On 06.10.21 12:58, Antony Pavlov wrote:
> Hi!
> 
> I have just update inkscape from Debian repo.
> It looks like inkscape-1.1.1 has new unexpected behaviour.

I ran into issues as well when going from 0.92.4 to 1.0.1.
Instead of adding another quirk, maybe we should use something
else for SVG to PNG that is actually stable.

Any suggestions?

> 
> During barebox sandbox build process I have faced with unexpected
> inkscape dialog. Also the '--without-gui=' option is depricated.
> See my build log
> 
> barebox$ make
> ...
> Warning: Option --without-gui= is deprecated
> Unable to init server: Could not connect: Connection refused
> Background RRGGBBAA: ffffff00
> Area 0:0:3000:1500 exported to 640 x 320 pixels (20.48 dpi)
>   LOGO.S   lib/logo/barebox-logo-w640.bblogo.S
>   AS      lib/logo/barebox-logo-w640.bblogo.o
>   AR      lib/logo/built-in.a
>   AR      lib/built-in.a
>   GEN     .version
>   CHK     include/generated/compile.h
>   UPD     include/generated/compile.h
>   CC      common/version.o
>   CC      common/imd-barebox.o
>   AR      common/built-in.a
>   LD      barebox
>   SYSMAP  System.map
>   OBJCOPY barebox.bin
>   CHKFILESIZE barebox.bin
>   LN      barebox-flash-image
> antony@cinco:~/barebox$ dpkg -l | grep inkscape
> ii  inkscape                                     1.1.1-2                                   amd64        vector-based drawing program
> 


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: inkscape 1.1.1 issue
  2021-10-06 11:19 ` Ahmad Fatoum
@ 2021-10-07  9:24   ` Ian Abbott
  2021-10-07  9:49   ` Jules Maselbas
  1 sibling, 0 replies; 7+ messages in thread
From: Ian Abbott @ 2021-10-07  9:24 UTC (permalink / raw)
  To: Ahmad Fatoum, Antony Pavlov, barebox

On 06/10/2021 12:19, Ahmad Fatoum wrote:
> Hello Antony,
> 
> On 06.10.21 12:58, Antony Pavlov wrote:
>> Hi!
>>
>> I have just update inkscape from Debian repo.
>> It looks like inkscape-1.1.1 has new unexpected behaviour.
> 
> I ran into issues as well when going from 0.92.4 to 1.0.1.
> Instead of adding another quirk, maybe we should use something
> else for SVG to PNG that is actually stable.
> 
> Any suggestions?

Perhaps rsvg-convert?

In Debian and Ubuntu, it is part of the librsvg2-bin package.

-- 
-=( Ian Abbott <abbotti@mev.co.uk> || MEV Ltd. is a company  )=-
-=( registered in England & Wales.  Regd. number: 02862268.  )=-
-=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=-
-=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: inkscape 1.1.1 issue
  2021-10-06 11:19 ` Ahmad Fatoum
  2021-10-07  9:24   ` Ian Abbott
@ 2021-10-07  9:49   ` Jules Maselbas
  2021-10-07 10:03     ` Ahmad Fatoum
  1 sibling, 1 reply; 7+ messages in thread
From: Jules Maselbas @ 2021-10-07  9:49 UTC (permalink / raw)
  To: Ahmad Fatoum; +Cc: barebox

Hi,

On Wed, Oct 06, 2021 at 01:19:36PM +0200, Ahmad Fatoum wrote:
> Hello Antony,
> 
> On 06.10.21 12:58, Antony Pavlov wrote:
> > Hi!
> > 
> > I have just update inkscape from Debian repo.
> > It looks like inkscape-1.1.1 has new unexpected behaviour.
> 
> I ran into issues as well when going from 0.92.4 to 1.0.1.
> Instead of adding another quirk, maybe we should use something
> else for SVG to PNG that is actually stable.
> 
> Any suggestions?
Maybe using imagemagick's convert ?

How can I see the result of the current solution ?
> > 
> > During barebox sandbox build process I have faced with unexpected
> > inkscape dialog. Also the '--without-gui=' option is depricated.
> > See my build log
> > 
> > barebox$ make
> > ...
> > Warning: Option --without-gui= is deprecated
> > Unable to init server: Could not connect: Connection refused
> > Background RRGGBBAA: ffffff00
> > Area 0:0:3000:1500 exported to 640 x 320 pixels (20.48 dpi)
> >   LOGO.S   lib/logo/barebox-logo-w640.bblogo.S
> >   AS      lib/logo/barebox-logo-w640.bblogo.o
> >   AR      lib/logo/built-in.a
> >   AR      lib/built-in.a
> >   GEN     .version
> >   CHK     include/generated/compile.h
> >   UPD     include/generated/compile.h
> >   CC      common/version.o
> >   CC      common/imd-barebox.o
> >   AR      common/built-in.a
> >   LD      barebox
> >   SYSMAP  System.map
> >   OBJCOPY barebox.bin
> >   CHKFILESIZE barebox.bin
> >   LN      barebox-flash-image
> > antony@cinco:~/barebox$ dpkg -l | grep inkscape
> > ii  inkscape                                     1.1.1-2                                   amd64        vector-based drawing program
> > 
> 





_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: inkscape 1.1.1 issue
  2021-10-07  9:49   ` Jules Maselbas
@ 2021-10-07 10:03     ` Ahmad Fatoum
  0 siblings, 0 replies; 7+ messages in thread
From: Ahmad Fatoum @ 2021-10-07 10:03 UTC (permalink / raw)
  To: Jules Maselbas; +Cc: barebox

Hello Jules

On 07.10.21 11:49, Jules Maselbas wrote:
> Hi,
> 
> On Wed, Oct 06, 2021 at 01:19:36PM +0200, Ahmad Fatoum wrote:
>> Hello Antony,
>>
>> On 06.10.21 12:58, Antony Pavlov wrote:
>>> Hi!
>>>
>>> I have just update inkscape from Debian repo.
>>> It looks like inkscape-1.1.1 has new unexpected behaviour.
>>
>> I ran into issues as well when going from 0.92.4 to 1.0.1.
>> Instead of adding another quirk, maybe we should use something
>> else for SVG to PNG that is actually stable.
>>
>> Any suggestions?
> Maybe using imagemagick's convert ?
> 
> How can I see the result of the current solution ?

Build for ARCH=sandbox and look into /logo.
If you enable CONFIG_DRIVER_VIDEO_SDL, you can display
the PNGs with e.g. fb0.enable=1 splash /logo/barebox-logo-640.png

>>>
>>> During barebox sandbox build process I have faced with unexpected
>>> inkscape dialog. Also the '--without-gui=' option is depricated.
>>> See my build log
>>>
>>> barebox$ make
>>> ...
>>> Warning: Option --without-gui= is deprecated
>>> Unable to init server: Could not connect: Connection refused
>>> Background RRGGBBAA: ffffff00
>>> Area 0:0:3000:1500 exported to 640 x 320 pixels (20.48 dpi)
>>>   LOGO.S   lib/logo/barebox-logo-w640.bblogo.S
>>>   AS      lib/logo/barebox-logo-w640.bblogo.o
>>>   AR      lib/logo/built-in.a
>>>   AR      lib/built-in.a
>>>   GEN     .version
>>>   CHK     include/generated/compile.h
>>>   UPD     include/generated/compile.h
>>>   CC      common/version.o
>>>   CC      common/imd-barebox.o
>>>   AR      common/built-in.a
>>>   LD      barebox
>>>   SYSMAP  System.map
>>>   OBJCOPY barebox.bin
>>>   CHKFILESIZE barebox.bin
>>>   LN      barebox-flash-image
>>> antony@cinco:~/barebox$ dpkg -l | grep inkscape
>>> ii  inkscape                                     1.1.1-2                                   amd64        vector-based drawing program
>>>
>>
> 
> 
> 
> 
> 


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [RFC PATCH] logo: Makefile: Replace inkscape with convert
  2021-10-06 10:58 inkscape 1.1.1 issue Antony Pavlov
  2021-10-06 11:19 ` Ahmad Fatoum
@ 2021-10-07 11:52 ` Jules Maselbas
  2021-10-11  9:45   ` Sascha Hauer
  1 sibling, 1 reply; 7+ messages in thread
From: Jules Maselbas @ 2021-10-07 11:52 UTC (permalink / raw)
  To: barebox; +Cc: Jules Maselbas, Ian Abbott, Ahmad Fatoum

The uses of inkscape to convert svg to png hasn't been very stable from
one version to another, and required quirks from one version to another.

I hope that convert from imagemagick will be a more stable solution.

Signed-off-by: Jules Maselbas <jmaselbas@kalray.eu>
---
 lib/logo/Makefile | 19 ++++++++-----------
 1 file changed, 8 insertions(+), 11 deletions(-)

diff --git a/lib/logo/Makefile b/lib/logo/Makefile
index 4149d4ff6c..f08beef76b 100644
--- a/lib/logo/Makefile
+++ b/lib/logo/Makefile
@@ -1,17 +1,17 @@
 
-OPTS_barebox-logo-w64.bblogo = --export-width=64
+OPTS_barebox-logo-w64.bblogo = -resize 64
 bblogo-$(CONFIG_BAREBOX_LOGO_64) += barebox-logo-w64
 
-OPTS_barebox-logo-w240.bblogo = --export-width=240
+OPTS_barebox-logo-w240.bblogo = -resize 240
 bblogo-$(CONFIG_BAREBOX_LOGO_240) += barebox-logo-w240
 
-OPTS_barebox-logo-w320.bblogo = --export-width=320
+OPTS_barebox-logo-w320.bblogo = -resize 320
 bblogo-$(CONFIG_BAREBOX_LOGO_320) += barebox-logo-w320
 
-OPTS_barebox-logo-w400.bblogo = --export-width=400
+OPTS_barebox-logo-w400.bblogo = -resize 400
 bblogo-$(CONFIG_BAREBOX_LOGO_400) += barebox-logo-w400
 
-OPTS_barebox-logo-w640.bblogo = --export-width=640
+OPTS_barebox-logo-w640.bblogo = -resize 640
 bblogo-$(CONFIG_BAREBOX_LOGO_640) += barebox-logo-w640
 
 obj-y += $(patsubst %,%.bblogo.o,$(bblogo-y))
@@ -38,15 +38,12 @@ cmd_logo_S =							\
 %.bblogo.S: %.bblogo FORCE
 	$(call if_changed,logo_S)
 
-# Inkscape 0.92.4 supports -z -e but Inkscape 1.0 uses --export-type=png
-INKSCAPEOPTS += $(call try-run, inkscape -z -e -,-z -e -,--export-type=png)
-# Inkscape 1.0 supports -o -
-INKSCAPEOPTS += $(call try-run, inkscape -o -,-o -,)
+CONVERTOPTS += -background none
 
-quiet_cmd_logo = LOGO.S  $@
+quiet_cmd_logo = PNG     $@
 cmd_logo =							\
 (								\
-	inkscape $(OPTS_$(@F)) $(INKSCAPEOPTS) $< > $@; \
+	convert $(OPTS_$(@F)) $(CONVERTOPTS) $< png:$@; \
 )
 
 %.bblogo: $(srctree)/Documentation/barebox.svg FORCE
-- 
2.17.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [RFC PATCH] logo: Makefile: Replace inkscape with convert
  2021-10-07 11:52 ` [RFC PATCH] logo: Makefile: Replace inkscape with convert Jules Maselbas
@ 2021-10-11  9:45   ` Sascha Hauer
  0 siblings, 0 replies; 7+ messages in thread
From: Sascha Hauer @ 2021-10-11  9:45 UTC (permalink / raw)
  To: Jules Maselbas; +Cc: barebox, Ian Abbott, Ahmad Fatoum

On Thu, Oct 07, 2021 at 01:52:54PM +0200, Jules Maselbas wrote:
> The uses of inkscape to convert svg to png hasn't been very stable from
> one version to another, and required quirks from one version to another.
> 
> I hope that convert from imagemagick will be a more stable solution.
> 
> Signed-off-by: Jules Maselbas <jmaselbas@kalray.eu>
> ---
>  lib/logo/Makefile | 19 ++++++++-----------
>  1 file changed, 8 insertions(+), 11 deletions(-)

I applied this one to the tree, thanks for the effort. Inkscape was
mentioned in the Kconfig entry, I changed this to ImageMagick.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2021-10-11  9:50 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-06 10:58 inkscape 1.1.1 issue Antony Pavlov
2021-10-06 11:19 ` Ahmad Fatoum
2021-10-07  9:24   ` Ian Abbott
2021-10-07  9:49   ` Jules Maselbas
2021-10-07 10:03     ` Ahmad Fatoum
2021-10-07 11:52 ` [RFC PATCH] logo: Makefile: Replace inkscape with convert Jules Maselbas
2021-10-11  9:45   ` Sascha Hauer

mail archive of the barebox mailing list

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://lore.barebox.org/barebox/0 barebox/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 barebox barebox/ https://lore.barebox.org/barebox \
		barebox@lists.infradead.org
	public-inbox-index barebox

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git