From: Ahmad Fatoum <a.fatoum@pengutronix.de> To: barebox@lists.infradead.org Cc: Ian Abbott <abbotti@mev.co.uk>, Ahmad Fatoum <a.fatoum@pengutronix.de> Subject: [PATCH master] mci: dw_mmc: make reset control optional again Date: Mon, 1 Nov 2021 18:52:07 +0100 [thread overview] Message-ID: <20211101175207.2160779-1-a.fatoum@pengutronix.de> (raw) As documented in 90bdf1e5d1e4 ("mci: dw_mmc: match against StarFive MMC compatibles"), it was intended for the reset to remain optional as to not break existing users. Unfortunately, my later a3cf324593ea ("mci: dw_mmc: add optional reset line") didn't heed that and made it required, breaking SoCFPGA DW-MMC use as a result. Revert that line to fix the regression. Fixes: a3cf324593ea ("mci: dw_mmc: add optional reset line") Reported-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de> --- drivers/mci/dw_mmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mci/dw_mmc.c b/drivers/mci/dw_mmc.c index b402090ab3cb..86c4f43e88f5 100644 --- a/drivers/mci/dw_mmc.c +++ b/drivers/mci/dw_mmc.c @@ -572,7 +572,7 @@ static int dw_mmc_probe(struct device_d *dev) rst = reset_control_get(dev, "reset"); if (IS_ERR(rst)) { - return PTR_ERR(rst); + dev_warn(dev, "error claiming reset: %pe\n", rst); } else if (rst) { reset_control_assert(rst); udelay(10); -- 2.30.2 _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
next reply other threads:[~2021-11-01 17:53 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-01 17:52 Ahmad Fatoum [this message] 2021-11-02 8:06 ` Sascha Hauer 2021-11-02 9:04 ` Philipp Zabel 2021-11-08 10:28 ` Ahmad Fatoum 2021-11-10 8:16 ` Sascha Hauer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211101175207.2160779-1-a.fatoum@pengutronix.de \ --to=a.fatoum@pengutronix.de \ --cc=abbotti@mev.co.uk \ --cc=barebox@lists.infradead.org \ --subject='Re: [PATCH master] mci: dw_mmc: make reset control optional again' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox