From: Sascha Hauer <sha@pengutronix.de>
To: Ian Abbott <abbotti@mev.co.uk>
Cc: barebox@lists.infradead.org,
Ahmad Fatoum <a.fatoum@pengutronix.de>,
Steffen Trumtrar <s.trumtrar@pengutronix.de>
Subject: Re: [PATCH v2] ARM: socfpga: Set reset-names property for &mmc
Date: Mon, 22 Nov 2021 10:11:31 +0100 [thread overview]
Message-ID: <20211122091131.GY6556@pengutronix.de> (raw)
In-Reply-To: <20211118130927.53123-1-abbotti@mev.co.uk>
On Thu, Nov 18, 2021 at 01:09:27PM +0000, Ian Abbott wrote:
> The device tree node for SoCFPGA's MMC device has the `resets =` property,
> but is missing the `reset-names = "reset";` property. This causes the
> "dw_mmc" driver to output a warning:
>
> WARNING: dw_mmc ff704000.dwmmc0@ff704000.of: error claiming reset: Invalid argument
>
> Add the missing `reset-names` property to the `&mmc` node in
> "arch/arm/dts/socfpga.dtsi". It probably needs fixing in the upstream
> Linux device tree sources too!
>
> Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
> Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
> ---
> v2: Updated commit message because it no longer fails to initialize the
> MMC device since commit 724512bbac14 ("mci: dw_mmc: make reset control
> optional again").
>
> arch/arm/dts/socfpga.dtsi | 4 ++++
> 1 file changed, 4 insertions(+)
Applied, thanks
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2021-11-22 9:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 17:40 [PATCH] " Ian Abbott
2021-11-01 17:52 ` Ahmad Fatoum
2021-11-01 18:51 ` Trent Piepho
2021-11-02 8:01 ` Sascha Hauer
2021-11-02 9:59 ` Ian Abbott
2021-11-18 13:09 ` [PATCH v2] " Ian Abbott
2021-11-22 9:11 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211122091131.GY6556@pengutronix.de \
--to=sha@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=abbotti@mev.co.uk \
--cc=barebox@lists.infradead.org \
--cc=s.trumtrar@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox