mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ian Abbott <>
To: Sascha Hauer <>
	Ahmad Fatoum <>,
	Steffen Trumtrar <>
Subject: Re: [PATCH] ARM: socfpga: Set reset-names property for &mmc
Date: Tue, 2 Nov 2021 09:59:38 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 02/11/2021 08:01, Sascha Hauer wrote:
> On Mon, Nov 01, 2021 at 05:40:53PM +0000, Ian Abbott wrote:
>> Since commit 90bdf1e5d1e4 ("mci: dw_mmc: match against StarFive MMC
>> compatibles"), the dw_mmc driver requires a reset line called "reset".
>> The slightly earlier commit a3cf324593ea ("mci: dw_mmc: add optional
>> reset line") introduced the reset line support, but made it optional.
>> The device tree node for SoCFPGA's MMC device has the "resets" property,
>> but is missing the "reset-names" property, so MMC no longer works.
>> Barebox produces the error message:
>> ERROR: dw_mmc ff704000.dwmmc0@ff704000.of: probe failed: Invalid argument
>> Add the missing "reset-names" property to the "&mmc" node in
>> "arch/arm/dts/socfpga.dtsi".  It probably needs fixing in the upstream
>> Linux device tree sources too!
> The reset binding lists reset-names as an optional property, so it seems
> our reset code needs fixing and not the dtsi file.

I'll resubmit the patch later with a different commit message once 
things have been settled, since it seems like a good idea for the reset 
line in the socfpga.dtsi to be made use of, and it doesn't seem to do 
any harm!

-=( Ian Abbott <> || MEV Ltd. is a company  )=-
-=( registered in England & Wales.  Regd. number: 02862268.  )=-
-=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=-
-=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || )=-

barebox mailing list

  reply	other threads:[~2021-11-02 10:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-01 17:40 Ian Abbott
2021-11-01 17:52 ` Ahmad Fatoum
2021-11-01 18:51   ` Trent Piepho
2021-11-02  8:01 ` Sascha Hauer
2021-11-02  9:59   ` Ian Abbott [this message]
2021-11-18 13:09 ` [PATCH v2] " Ian Abbott
2021-11-22  9:11   ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \
    --subject='Re: [PATCH] ARM: socfpga: Set reset-names property for &mmc' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox