mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] misc: acpi-test: retire test driver in favor of WDAT driver
@ 2022-01-10 10:48 Ahmad Fatoum
  2022-01-17  9:10 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2022-01-10 10:48 UTC (permalink / raw)
  To: barebox; +Cc: Ahmad Fatoum

With the integration of the ACPI WDAT watchdog driver, we now have an
actually useful user of the ACPI bus in tree, so the test driver
serves no purpose anymore. Drop it.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 drivers/misc/Kconfig     |  6 ----
 drivers/misc/Makefile    |  1 -
 drivers/misc/acpi-test.c | 61 ----------------------------------------
 3 files changed, 68 deletions(-)
 delete mode 100644 drivers/misc/acpi-test.c

diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
index 56569145076e..5ab0506cd9fa 100644
--- a/drivers/misc/Kconfig
+++ b/drivers/misc/Kconfig
@@ -37,12 +37,6 @@ config UBOOTVAR
 	  While it can be used standalone, it is best when coupled
 	  with corresponding filesystem driver.
 
-config ACPI_TEST
-	bool "ACPI Test driver"
-	depends on ACPI
-	help
-	  This is a simple Test driver to test the ACPI bus.
-
 config STARFIVE_PWRSEQ
 	bool "StarFive power sequencing driver"
 	depends on SOC_STARFIVE
diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile
index 05da264a426d..6326e784fc98 100644
--- a/drivers/misc/Makefile
+++ b/drivers/misc/Makefile
@@ -8,5 +8,4 @@ obj-$(CONFIG_SRAM)		+= sram.o
 obj-$(CONFIG_STATE_DRV)		+= state.o
 obj-$(CONFIG_DEV_MEM)		+= mem.o
 obj-$(CONFIG_UBOOTVAR)		+= ubootvar.o
-obj-$(CONFIG_ACPI_TEST)		+= acpi-test.o
 obj-$(CONFIG_STARFIVE_PWRSEQ)	+= starfive-pwrseq.o
diff --git a/drivers/misc/acpi-test.c b/drivers/misc/acpi-test.c
deleted file mode 100644
index af20370fbc73..000000000000
--- a/drivers/misc/acpi-test.c
+++ /dev/null
@@ -1,61 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0-only
-/*
- * Copyright (c) 2019 Ahmad Fatoum
- */
-
-#include <common.h>
-#include <init.h>
-#include <acpi.h>
-
-static const char *profiles[] = {
-	"Unspecified",
-	"Desktop",
-	"Mobile",
-	"Workstation",
-	"Enterprise Server",
-	"SOHO Server",
-	"Applicance PC",
-	"Performance Server",
-	"Tablet",
-};
-
-static int acpi_test_probe(struct device_d *dev)
-{
-	const char *profile = "reserved";
-	u8 *sdt;
-	u8 profileno;
-
-	dev_dbg(dev, "driver initializing...\n");
-
-	sdt = (u8 __force *)dev_request_mem_region_by_name(dev, "SDT");
-	if (IS_ERR(sdt)) {
-		dev_err(dev, "no SDT resource available: %pe\n", sdt);
-		return PTR_ERR(sdt);
-	}
-
-	dev_dbg(dev, "SDT is at 0x%p\n", sdt);
-
-	profileno = sdt[45];
-
-	if (profileno < ARRAY_SIZE(profiles))
-		profile = profiles[profileno];
-
-	dev_info(dev, "PM profile is for '%s'\n", profile);
-
-	return 0;
-}
-
-static void acpi_test_remove(struct device_d *dev)
-{
-	dev_dbg(dev, "FADT driver removed\n");
-}
-
-static struct acpi_driver acpi_test_driver = {
-	.signature = "FACP",
-	.driver = {
-		.name = "acpi-test",
-		.probe = acpi_test_probe,
-		.remove = acpi_test_remove,
-	}
-};
-device_acpi_driver(acpi_test_driver);
-- 
2.30.2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] misc: acpi-test: retire test driver in favor of WDAT driver
  2022-01-10 10:48 [PATCH] misc: acpi-test: retire test driver in favor of WDAT driver Ahmad Fatoum
@ 2022-01-17  9:10 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2022-01-17  9:10 UTC (permalink / raw)
  To: Ahmad Fatoum; +Cc: barebox

On Mon, Jan 10, 2022 at 11:48:31AM +0100, Ahmad Fatoum wrote:
> With the integration of the ACPI WDAT watchdog driver, we now have an
> actually useful user of the ACPI bus in tree, so the test driver
> serves no purpose anymore. Drop it.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  drivers/misc/Kconfig     |  6 ----
>  drivers/misc/Makefile    |  1 -
>  drivers/misc/acpi-test.c | 61 ----------------------------------------
>  3 files changed, 68 deletions(-)
>  delete mode 100644 drivers/misc/acpi-test.c

Applied, thanks

Sascha


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-01-17  9:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-10 10:48 [PATCH] misc: acpi-test: retire test driver in favor of WDAT driver Ahmad Fatoum
2022-01-17  9:10 ` Sascha Hauer

mail archive of the barebox mailing list

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://lore.barebox.org/barebox/0 barebox/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 barebox barebox/ https://lore.barebox.org/barebox \
		barebox@lists.infradead.org barebox@lists.infradead.org
	public-inbox-index barebox

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git