mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Jules Maselbas <jmaselbas@kalray.eu>
To: Trent Piepho <trent.piepho@igorinstitute.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v2 4/5] logo: Enable image format selection for the logo
Date: Tue, 18 Jan 2022 18:00:35 +0100	[thread overview]
Message-ID: <20220118170035.GF29876@tellis.lin.mbt.kalray.eu> (raw)
In-Reply-To: <CAMHeXxOQXTTd=u8M9fbtQeB6OAFnC+1t=Sx=CtwzocNc=HaDMg@mail.gmail.com>

On Mon, Jan 17, 2022 at 03:28:17PM -0800, Trent Piepho wrote:
> On Mon, Jan 17, 2022 at 3:03 PM Jules Maselbas <jmaselbas@kalray.eu> wrote:
> >
> > +choice
> > +       prompt "Logo image encoding format to be used"
> > +       default BAREBOX_LOGO_PNG
> > +
> > +config BAREBOX_LOGO_PNG
> > +       bool "png"
> > +       select PNG
> > +       help
> > +         Encode logo with the PNG image format
> > +
> > +config BAREBOX_LOGO_BMP
> > +       bool "bmp"
> > +       select BMP
> > +       help
> > +         Encode logo with the BMP image format
> 
> You might say why one might want one format or ther other.  What's the
> point of adding bmp support?
Yes that's a good point, I'll add a short explaination of pros/cons.
The only reason of adding bmp is that is it a supported format in
lib/gui/ that's all... 


> 





_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


  reply	other threads:[~2022-01-18 17:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-17 23:02 [PATCH v2 0/5] Add support for QOI image format Jules Maselbas
2022-01-17 23:02 ` [PATCH v2 1/5] filetype: Add QOI format image type Jules Maselbas
2022-01-17 23:02 ` [PATCH v2 2/5] gui: Add qoi image format Jules Maselbas
2022-01-17 23:02 ` [PATCH v2 3/5] scripts: Add qoiconv to convert png to qoi Jules Maselbas
2022-01-17 23:02 ` [PATCH v2 4/5] logo: Enable image format selection for the logo Jules Maselbas
2022-01-17 23:28   ` Trent Piepho
2022-01-18 17:00     ` Jules Maselbas [this message]
2022-01-20  8:13     ` Sascha Hauer
2022-01-20 10:38       ` Jules Maselbas
2022-01-17 23:02 ` [PATCH v2 5/5] logo: Add choice for the QOI image format option Jules Maselbas
2022-01-20  8:25 ` [PATCH v2 0/5] Add support for QOI image format Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220118170035.GF29876@tellis.lin.mbt.kalray.eu \
    --to=jmaselbas@kalray.eu \
    --cc=barebox@lists.infradead.org \
    --cc=trent.piepho@igorinstitute.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox