mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] serial: cadence: add ZynqMP compatibles
@ 2022-02-02 10:11 Michael Tretter
  2022-02-02 10:39 ` Ahmad Fatoum
  2022-02-03  9:57 ` Sascha Hauer
  0 siblings, 2 replies; 3+ messages in thread
From: Michael Tretter @ 2022-02-02 10:11 UTC (permalink / raw)
  To: barebox; +Cc: m.tretter

Commit 3f2f5980d517 ("dts: update to v5.16-rc1") changes the compatible
of the ZynqMP uarts to "xlnx,zynqmp-uart" and drops the "xlnx,xuartps"
compatible.

The driver worked just fine before and the difference between the r1p8
and r1p12 compatibles is the use of the RX byte status register which is
only used with interrupts.

Add the "xlnx,zynqmp-uart" and the "cdns,uart-r1p12" compatibles to the
driver.

Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
---
 drivers/serial/serial_cadence.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/serial/serial_cadence.c b/drivers/serial/serial_cadence.c
index 6cf18aa25ac7..84dcd1b76b6e 100644
--- a/drivers/serial/serial_cadence.c
+++ b/drivers/serial/serial_cadence.c
@@ -230,6 +230,12 @@ static __maybe_unused struct of_device_id cadence_serial_dt_ids[] = {
 	{
 		.compatible = "xlnx,xuartps",
 		.data = &cadence_r1p08_data,
+	}, {
+		.compatible = "cdns,uart-r1p12",
+		.data = &cadence_r1p08_data,
+	}, {
+		.compatible = "xlnx,zynqmp-uart",
+		.data = &cadence_r1p08_data,
 	}, {
 		/* sentinel */
 	}
-- 
2.30.2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] serial: cadence: add ZynqMP compatibles
  2022-02-02 10:11 [PATCH] serial: cadence: add ZynqMP compatibles Michael Tretter
@ 2022-02-02 10:39 ` Ahmad Fatoum
  2022-02-03  9:57 ` Sascha Hauer
  1 sibling, 0 replies; 3+ messages in thread
From: Ahmad Fatoum @ 2022-02-02 10:39 UTC (permalink / raw)
  To: Michael Tretter, barebox

On 02.02.22 11:11, Michael Tretter wrote:
> Commit 3f2f5980d517 ("dts: update to v5.16-rc1") changes the compatible
> of the ZynqMP uarts to "xlnx,zynqmp-uart" and drops the "xlnx,xuartps"
> compatible.
> 
> The driver worked just fine before and the difference between the r1p8
> and r1p12 compatibles is the use of the RX byte status register which is
> only used with interrupts.
> 
> Add the "xlnx,zynqmp-uart" and the "cdns,uart-r1p12" compatibles to the
> driver.
> 
> Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>

Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

Should probably go into master.

> ---
>  drivers/serial/serial_cadence.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/serial/serial_cadence.c b/drivers/serial/serial_cadence.c
> index 6cf18aa25ac7..84dcd1b76b6e 100644
> --- a/drivers/serial/serial_cadence.c
> +++ b/drivers/serial/serial_cadence.c
> @@ -230,6 +230,12 @@ static __maybe_unused struct of_device_id cadence_serial_dt_ids[] = {
>  	{
>  		.compatible = "xlnx,xuartps",
>  		.data = &cadence_r1p08_data,
> +	}, {
> +		.compatible = "cdns,uart-r1p12",
> +		.data = &cadence_r1p08_data,
> +	}, {
> +		.compatible = "xlnx,zynqmp-uart",
> +		.data = &cadence_r1p08_data,
>  	}, {
>  		/* sentinel */
>  	}


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] serial: cadence: add ZynqMP compatibles
  2022-02-02 10:11 [PATCH] serial: cadence: add ZynqMP compatibles Michael Tretter
  2022-02-02 10:39 ` Ahmad Fatoum
@ 2022-02-03  9:57 ` Sascha Hauer
  1 sibling, 0 replies; 3+ messages in thread
From: Sascha Hauer @ 2022-02-03  9:57 UTC (permalink / raw)
  To: Michael Tretter; +Cc: barebox

On Wed, Feb 02, 2022 at 11:11:19AM +0100, Michael Tretter wrote:
> Commit 3f2f5980d517 ("dts: update to v5.16-rc1") changes the compatible
> of the ZynqMP uarts to "xlnx,zynqmp-uart" and drops the "xlnx,xuartps"
> compatible.
> 
> The driver worked just fine before and the difference between the r1p8
> and r1p12 compatibles is the use of the RX byte status register which is
> only used with interrupts.
> 
> Add the "xlnx,zynqmp-uart" and the "cdns,uart-r1p12" compatibles to the
> driver.
> 
> Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
> ---
>  drivers/serial/serial_cadence.c | 6 ++++++
>  1 file changed, 6 insertions(+)

Applied, thanks

Sascha


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-02-03 10:12 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-02 10:11 [PATCH] serial: cadence: add ZynqMP compatibles Michael Tretter
2022-02-02 10:39 ` Ahmad Fatoum
2022-02-03  9:57 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox