mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <sha@pengutronix.de>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v4 01/13] net: add RX preprocessor support
Date: Tue, 12 Apr 2022 09:58:27 +0200	[thread overview]
Message-ID: <20220412075827.GV4012@pengutronix.de> (raw)
In-Reply-To: <20220408082950.824927-2-o.rempel@pengutronix.de>

On Fri, Apr 08, 2022 at 10:29:38AM +0200, Oleksij Rempel wrote:
> Add callback for optional rx_preprocessor. This is needed to add DSA
> switch support and demultiplex traffic received from different switch ports.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
>  include/net.h | 3 +++
>  net/net.c     | 6 ++++++
>  2 files changed, 9 insertions(+)
> 
> diff --git a/include/net.h b/include/net.h
> index aad28e4f4c..ca9b6cd61e 100644
> --- a/include/net.h
> +++ b/include/net.h
> @@ -44,9 +44,12 @@ struct eth_device {
>  	void (*halt) (struct eth_device*);
>  	int  (*get_ethaddr) (struct eth_device*, u8 adr[6]);
>  	int  (*set_ethaddr) (struct eth_device*, const unsigned char *adr);
> +	int  (*rx_preprocessor) (struct eth_device*, unsigned char **packet,
> +				 int *length);
>  
>  	struct eth_device *next;
>  	void *priv;
> +	void *rx_preprocessor_priv;
>  
>  	/* phy device may attach itself for hardware timestamping */
>  	struct phy_device *phydev;
> diff --git a/net/net.c b/net/net.c
> index fdb9ab826c..dd2ceb396d 100644
> --- a/net/net.c
> +++ b/net/net.c
> @@ -708,6 +708,12 @@ int net_receive(struct eth_device *edev, unsigned char *pkt, int len)
>  		goto out;
>  	}
>  
> +	if (edev->rx_preprocessor) {
> +		ret = edev->rx_preprocessor(edev, &pkt, &len);
> +		if (ret == -ENOMSG)
> +			return 0;

ret == -ENOMSG means the packet has been handled by the preprocessor
(and forwarded to the DSA virtual network devices). What about the other
errors that rx_preprocessor can return? Shouldn't we ignore the packet
on other errors?

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


  reply	other threads:[~2022-04-12  8:02 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-08  8:29 [PATCH v4 00/13] provide DSA support Oleksij Rempel
2022-04-08  8:29 ` [PATCH v4 01/13] net: add RX preprocessor support Oleksij Rempel
2022-04-12  7:58   ` Sascha Hauer [this message]
2022-04-12  8:14     ` Oleksij Rempel
2022-04-08  8:29 ` [PATCH v4 02/13] net: add of_find_eth_device_by_node() function Oleksij Rempel
2022-04-08  8:29 ` [PATCH v4 03/13] net: phy: export of_phy_register_fixed_link() function Oleksij Rempel
2022-04-08  8:29 ` [PATCH v4 04/13] net: add DSA framework to support basic switch functionality Oleksij Rempel
2022-04-12  8:02   ` Sascha Hauer
2022-04-08  8:29 ` [PATCH v4 05/13] driver: add dev_get_priv() helper Oleksij Rempel
2022-04-08  8:29 ` [PATCH v4 06/13] net: port part of if_vlan header from kernel v5.17 Oleksij Rempel
2022-04-08  8:29 ` [PATCH v4 07/13] spi: port spi_sync_transfer() function " Oleksij Rempel
2022-04-08  8:29 ` [PATCH v4 08/13] net: mdio: add MDIO_DEVAD_NONE define Oleksij Rempel
2022-04-08  8:29 ` [PATCH v4 09/13] net: phy: make sure MDIO bus is probed if we search for the PHY Oleksij Rempel
2022-04-08  8:29 ` [PATCH v4 10/13] of_net: add rev-rmii support Oleksij Rempel
2022-04-08  8:29 ` [PATCH v4 11/13] net: dsa: add support for SJA11xx switches Oleksij Rempel
2022-04-12  8:25   ` Sascha Hauer
2022-04-08  8:29 ` [PATCH v4 12/13] net: dsa: add KSZ9477 switch SPI driver Oleksij Rempel
2022-04-12  8:37   ` Sascha Hauer
2022-04-08  8:29 ` [PATCH v4 13/13] add ethlog command Oleksij Rempel
2022-04-12  8:54   ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220412075827.GV4012@pengutronix.de \
    --to=sha@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=o.rempel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox