From: Matthias Fend <matthias.fend@emfend.at> To: barebox@lists.infradead.org Subject: [PATCH] firmware: zynqmp-fpga: do not load PL with ONLY_BIN flag unless necessary Date: Sun, 1 May 2022 20:26:07 +0200 [thread overview] Message-ID: <20220501182607.38125-1-matthias.fend@emfend.at> (raw) Since pmu-fw release 2018.3, the ZYNQMP_FPGA_BIT_ONLY_BIN flag is no longer used. This wasn't a problem for a while, but in newer versions a validation sequence will fail if this flag is set. This means that the PL can no longer be loaded. Do not set the ZYNQMP_FPGA_BIT_ONLY_BIN flag unless absolutely necessary to avoid this problem. Signed-off-by: Matthias Fend <matthias.fend@emfend.at> --- drivers/firmware/zynqmp-fpga.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/zynqmp-fpga.c b/drivers/firmware/zynqmp-fpga.c index 63d7398fd..db34ac2be 100644 --- a/drivers/firmware/zynqmp-fpga.c +++ b/drivers/firmware/zynqmp-fpga.c @@ -261,9 +261,10 @@ static int fpgamgr_program_finish(struct firmware_handler *fh) goto err_free_dma; } - if (mgr->features & ZYNQMP_PM_FEATURE_SIZE_NOT_NEEDED) + if (mgr->features & ZYNQMP_PM_FEATURE_SIZE_NOT_NEEDED) { + flags &= ~ZYNQMP_FPGA_BIT_ONLY_BIN; buf_size = body_length; - else + } else buf_size = addr + body_length; status = mgr->eemi_ops->fpga_load((u64)addr, buf_size, flags); -- 2.25.1 _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
next reply other threads:[~2022-05-01 18:28 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-01 18:26 Matthias Fend [this message] 2022-05-02 14:00 ` Michael Tretter 2022-05-02 16:00 ` Matthias Fend
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220501182607.38125-1-matthias.fend@emfend.at \ --to=matthias.fend@emfend.at \ --cc=barebox@lists.infradead.org \ --subject='Re: [PATCH] firmware: zynqmp-fpga: do not load PL with ONLY_BIN flag unless necessary' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox