From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: barebox@lists.infradead.org
Subject: [PATCH 1/3] watchdog: imxwd: Add error messages for some failure points in .probe()
Date: Mon, 27 Jun 2022 12:33:56 +0200 [thread overview]
Message-ID: <20220627103358.34487-1-u.kleine-koenig@pengutronix.de> (raw)
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/watchdog/imxwd.c | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/drivers/watchdog/imxwd.c b/drivers/watchdog/imxwd.c
index 31ea388c2cf2..3e596b55f8f7 100644
--- a/drivers/watchdog/imxwd.c
+++ b/drivers/watchdog/imxwd.c
@@ -245,12 +245,16 @@ static int imx_wd_probe(struct device_d *dev)
}
clk = clk_get(dev, NULL);
- if (IS_ERR(clk))
+ if (IS_ERR(clk)) {
+ dev_err(dev, "Failed to get clk: %d\n", PTR_ERR(clk));
return PTR_ERR(clk);
+ }
ret = clk_enable(clk);
- if (ret)
+ if (ret) {
+ dev_err(dev, "Failed to enable clk: %d\n", ret);
return ret;
+ }
priv->base = IOMEM(iores->start);
priv->ops = ops;
@@ -272,14 +276,16 @@ static int imx_wd_probe(struct device_d *dev)
}
ret = watchdog_register(&priv->wd);
- if (ret)
+ if (ret) {
+ dev_err(dev, "Failed to register watchdog device: %d\n", ret);
goto on_error;
+ }
}
if (priv->ops->init) {
ret = priv->ops->init(priv);
if (ret) {
- dev_err(dev, "Failed to init watchdog device %d\n", ret);
+ dev_err(dev, "Failed to init watchdog device: %d\n", ret);
goto error_unregister;
}
}
base-commit: 512d036587a38c57a30cc63ce48c19c895b9d729
--
2.36.1
next reply other threads:[~2022-06-27 10:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-27 10:33 Uwe Kleine-König [this message]
2022-06-27 10:33 ` [PATCH 2/3] clk: imx25: Add comments to clk list with offsets Uwe Kleine-König
2022-06-27 13:13 ` Alexander Shiyan
2022-06-29 7:40 ` Sascha Hauer
2022-06-27 10:33 ` [PATCH 3/3] clk: imx25: Add support for watchdog clock Uwe Kleine-König
2022-06-27 10:51 ` [PATCH 1/3] watchdog: imxwd: Add error messages for some failure points in .probe() Ahmad Fatoum
2022-06-29 8:54 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220627103358.34487-1-u.kleine-koenig@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox