Re: [PATCH 2/3] clk: imx25: Add comments to clk list with offsets

[Sascha Hauer <sha@pengutronix.de>]

On Mon, Jun 27, 2022 at 04:13:09PM +0300, Alexander Shiyan wrote:
> Hello.
> 
> пн, 27 июн. 2022 г. в 13:34, Uwe Kleine-König <u.kleine-koenig@pengutronix.de>:
> > This greatly simplifies to determine the offset of a given clk.
> ...
> >  enum mx25_clks {
> > -       dummy, osc, mpll, upll, mpll_cpu_3_4, cpu_sel, cpu, ahb, usb_div, ipg,
> > -       per0_sel, per1_sel, per2_sel, per3_sel, per4_sel, per5_sel, per6_sel,
> > -       per7_sel, per8_sel, per9_sel, per10_sel, per11_sel, per12_sel,
> > -       per13_sel, per14_sel, per15_sel, per0, per1, per2, per3, per4, per5,
> > -       per6, per7, per8, per9, per10, per11, per12, per13, per14, per15,
> > -       csi_ipg_per, epit_ipg_per, esai_ipg_per, esdhc1_ipg_per, esdhc2_ipg_per,
> > -       gpt_ipg_per, i2c_ipg_per, lcdc_ipg_per, nfc_ipg_per, owire_ipg_per,
> > -       pwm_ipg_per, sim1_ipg_per, sim2_ipg_per, ssi1_ipg_per, ssi2_ipg_per,
> > -       uart_ipg_per, ata_ahb, reserved1, csi_ahb, emi_ahb, esai_ahb, esdhc1_ahb,
> > -       esdhc2_ahb, fec_ahb, lcdc_ahb, rtic_ahb, sdma_ahb, slcdc_ahb, usbotg_ahb,
> > -       reserved2, reserved3, reserved4, reserved5, can1_ipg, can2_ipg, csi_ipg,
> > -       cspi1_ipg, cspi2_ipg, cspi3_ipg, dryice_ipg, ect_ipg, epit1_ipg, epit2_ipg,
> > -       reserved6, esdhc1_ipg, esdhc2_ipg, fec_ipg, reserved7, reserved8, reserved9,
> > -       gpt1_ipg, gpt2_ipg, gpt3_ipg, gpt4_ipg, reserved10, reserved11, reserved12,
> > -       iim_ipg, reserved13, reserved14, kpp_ipg, lcdc_ipg, reserved15, pwm1_ipg,
> > -       pwm2_ipg, pwm3_ipg, pwm4_ipg, rngb_ipg, reserved16, scc_ipg, sdma_ipg,
> > -       sim1_ipg, sim2_ipg, slcdc_ipg, spba_ipg, ssi1_ipg, ssi2_ipg, tsc_ipg,
> > -       uart1_ipg, uart2_ipg, uart3_ipg, uart4_ipg, uart5_ipg, reserved17,
> > -       wdt_ipg, clk_max
> > +       /*   0 */ dummy, osc, mpll, upll, mpll_cpu_3_4, cpu_sel, cpu, ahb, usb_div, ipg,
> > +       /*  10 */ per0_sel, per1_sel, per2_sel, per3_sel, per4_sel, per5_sel, per6_sel,
> > +       /*  17 */ per7_sel, per8_sel, per9_sel, per10_sel, per11_sel, per12_sel,
> > +       /*  23 */ per13_sel, per14_sel, per15_sel, per0, per1, per2, per3, per4, per5,
> > +       /*  32 */ per6, per7, per8, per9, per10, per11, per12, per13, per14, per15,
> > +       /*  42 */ csi_ipg_per, epit_ipg_per, esai_ipg_per, esdhc1_ipg_per, esdhc2_ipg_per,
> > +       /*  47 */ gpt_ipg_per, i2c_ipg_per, lcdc_ipg_per, nfc_ipg_per, owire_ipg_per,
> > +       /*  52 */ pwm_ipg_per, sim1_ipg_per, sim2_ipg_per, ssi1_ipg_per, ssi2_ipg_per,
> > +       /*  57 */ uart_ipg_per, ata_ahb, reserved1, csi_ahb, emi_ahb, esai_ahb, esdhc1_ahb,
> > +       /*  64 */ esdhc2_ahb, fec_ahb, lcdc_ahb, rtic_ahb, sdma_ahb, slcdc_ahb, usbotg_ahb,
> > +       /*  71 */ reserved2, reserved3, reserved4, reserved5, can1_ipg, can2_ipg, csi_ipg,
> > +       /*  78 */ cspi1_ipg, cspi2_ipg, cspi3_ipg, dryice_ipg, ect_ipg, epit1_ipg, epit2_ipg,
> > +       /*  85 */ reserved6, esdhc1_ipg, esdhc2_ipg, fec_ipg, reserved7, reserved8, reserved9,
> > +       /*  92 */ gpt1_ipg, gpt2_ipg, gpt3_ipg, gpt4_ipg, reserved10, reserved11, reserved12,
> > +       /*  99 */ iim_ipg, reserved13, reserved14, kpp_ipg, lcdc_ipg, reserved15, pwm1_ipg,
> > +       /* 106 */ pwm2_ipg, pwm3_ipg, pwm4_ipg, rngb_ipg, reserved16, scc_ipg, sdma_ipg,
> > +       /* 113 */ sim1_ipg, sim2_ipg, slcdc_ipg, spba_ipg, ssi1_ipg, ssi2_ipg, tsc_ipg,
> > +       /* 120 */ uart1_ipg, uart2_ipg, uart3_ipg, uart4_ipg, uart5_ipg, reserved17,
> > +       /* 126 */ wdt_ipg, clk_max
> >  };
> 
> Maybe this enum should be updated from linux/drivers/clk/imx/clk-imx25.c first?

There should be no clocks changed, only added at the end. As we do not
support these additional clocks I don't think that's necessary.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |