mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <sha@pengutronix.de>
To: Alexander Shiyan <eagle.alexander923@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 6/8] pbl: Fix Kconfig dependencies
Date: Thu, 30 Jun 2022 13:57:32 +0200	[thread overview]
Message-ID: <20220630115732.GB2387@pengutronix.de> (raw)
In-Reply-To: <20220627102500.18427-7-eagle.alexander923@gmail.com>

On Mon, Jun 27, 2022 at 01:24:58PM +0300, Alexander Shiyan wrote:
> WARNING: unmet direct dependencies detected for PBL_IMAGE
> Depends on [n]: HAVE_PBL_IMAGE [=n]
> Selected by [y]:
> - PBL_MULTI_IMAGES [=y] && HAVE_PBL_MULTI_IMAGES [=y]
> 
> WARNING: unmet direct dependencies detected for PBL_VERIFY_PIGGY
> Depends on [n]: PBL_IMAGE [=n] && ARM [=y]
> Selected by [y]:
> - ARCH_IMX8M [=y] && ARCH_IMX [=y] && HABV4 [=y]
> 
> WARNING: unmet direct dependencies detected for BOARD_GENERIC_DT
> Depends on [n]: PBL_IMAGE [=n]
> Selected by [y]:
> - BOARD_ARM_GENERIC_DT [=y] && HAVE_PBL_MULTI_IMAGES [=y] && OFDEVICE [=y]

I had to revert this one as it breaks for example am335x_mlo_defconfig.
It breaks because HAVE_PBL_MULTI_IMAGES is set. With this
PBL_MULTI_IMAGES becomes enabled because it is default y. That option
in turn selects PBL_IMAGE. Now with this patch applied we end up
with PBL_IMAGE disabled and the config doesn't compile anymore.

I think we have to split this patch up further. What I trapped in was:

> WARNING: unmet direct dependencies detected for PBL_IMAGE
> Depends on [n]: HAVE_PBL_IMAGE [=n]
> Selected by [y]:
> - PBL_MULTI_IMAGES [=y] && HAVE_PBL_MULTI_IMAGES [=y]

And I think that one could be fixed with:

config HAVE_PBL_MULTI_IMAGES
	select HAVE_PBL_IMAGE
	bool

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



  reply	other threads:[~2022-06-30 11:59 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-27 10:24 [PATCH 0/8] Misc fixes part III Alexander Shiyan
2022-06-27 10:24 ` [PATCH 1/8] ARM: vexpress: Simplify sysctl initialization Alexander Shiyan
2022-06-27 10:24 ` [PATCH 2/8] ARM: bcm2835: Drop uneeded headers Alexander Shiyan
2022-06-29  7:10   ` Sascha Hauer
2022-06-27 10:24 ` [PATCH 3/8] of: Use appropriate header for of_clk_init() Alexander Shiyan
2022-06-27 10:24 ` [PATCH 4/8] usb: gadget: Fix Kconfig dependencies Alexander Shiyan
2022-06-29  6:52   ` Sascha Hauer
2022-06-29  6:55     ` Ahmad Fatoum
2022-06-29  6:59       ` Sascha Hauer
2022-06-29  7:03         ` Ahmad Fatoum
2022-06-29  7:08           ` Sascha Hauer
2022-06-27 10:24 ` [PATCH 5/8] logo: " Alexander Shiyan
2022-06-27 10:24 ` [PATCH 6/8] pbl: " Alexander Shiyan
2022-06-30 11:57   ` Sascha Hauer [this message]
2022-06-27 10:24 ` [PATCH 7/8] ARM: mxs: " Alexander Shiyan
2022-06-27 10:25 ` [PATCH 8/8] ARM: boards: ccmx51: Remove unused KConfig option Alexander Shiyan
2022-06-29  7:10 ` [PATCH 0/8] Misc fixes part III Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220630115732.GB2387@pengutronix.de \
    --to=sha@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=eagle.alexander923@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox