Re: [PATCH 6/8] pbl: Fix Kconfig dependencies

[Sascha Hauer <sha@pengutronix.de>]

On Mon, Jun 27, 2022 at 01:24:58PM +0300, Alexander Shiyan wrote:
> WARNING: unmet direct dependencies detected for PBL_IMAGE
> Depends on [n]: HAVE_PBL_IMAGE [=n]
> Selected by [y]:
> - PBL_MULTI_IMAGES [=y] && HAVE_PBL_MULTI_IMAGES [=y]
> 
> WARNING: unmet direct dependencies detected for PBL_VERIFY_PIGGY
> Depends on [n]: PBL_IMAGE [=n] && ARM [=y]
> Selected by [y]:
> - ARCH_IMX8M [=y] && ARCH_IMX [=y] && HABV4 [=y]
> 
> WARNING: unmet direct dependencies detected for BOARD_GENERIC_DT
> Depends on [n]: PBL_IMAGE [=n]
> Selected by [y]:
> - BOARD_ARM_GENERIC_DT [=y] && HAVE_PBL_MULTI_IMAGES [=y] && OFDEVICE [=y]

I had to revert this one as it breaks for example am335x_mlo_defconfig.
It breaks because HAVE_PBL_MULTI_IMAGES is set. With this
PBL_MULTI_IMAGES becomes enabled because it is default y. That option
in turn selects PBL_IMAGE. Now with this patch applied we end up
with PBL_IMAGE disabled and the config doesn't compile anymore.

I think we have to split this patch up further. What I trapped in was:

> WARNING: unmet direct dependencies detected for PBL_IMAGE
> Depends on [n]: HAVE_PBL_IMAGE [=n]
> Selected by [y]:
> - PBL_MULTI_IMAGES [=y] && HAVE_PBL_MULTI_IMAGES [=y]

And I think that one could be fixed with:

config HAVE_PBL_MULTI_IMAGES
	select HAVE_PBL_IMAGE
	bool

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |