mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <sha@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: Alexander Shiyan <eagle.alexander923@gmail.com>,
	barebox@lists.infradead.org, Ahmad Fatoum <afa@pengutronix.de>
Subject: Re: [PATCH 4/8] usb: gadget: Fix Kconfig dependencies
Date: Wed, 29 Jun 2022 09:08:51 +0200	[thread overview]
Message-ID: <20220629070851.GL19026@pengutronix.de> (raw)
In-Reply-To: <fc07a9a9-3d78-7295-119a-e0b54d593237@pengutronix.de>

On Wed, Jun 29, 2022 at 09:03:41AM +0200, Ahmad Fatoum wrote:
> Hello Sascha,
> 
> On 29.06.22 08:59, Sascha Hauer wrote:
> > On Wed, Jun 29, 2022 at 08:55:46AM +0200, Ahmad Fatoum wrote:
> >> Hello Sascha,
> >>
> >> On 29.06.22 08:52, Sascha Hauer wrote:
> >>> Without GLOBALVAR selected the USB gadget autostart stuff can be
> >>> compiled, but without any functionality, as all functionality is
> >>> behind globalvars, so adding this dependency mykes sense.
> >>>
> >>>>  	select SYSTEM_PARTITIONS if USB_GADGET_MASS_STORAGE
> >>>
> >>> I am not sure why SYSTEM_PARTITIONS is selected here. Maybe Ahmad can
> >>> comment on that. From what I can see with USB_GADGET_AUTOSTART selected
> >>> without SYSTEM_PARTITIONS we still get autostart functionality, but
> >>> without global.system.partitions support which seems ok.
> >>
> >> Instead of adding yet another gadget-specific global variable,
> >> the mass storage gadget only uses system partitions, so this
> >> select makes sense IMO.
> > 
> > I would argument that USB_GADGET_AUTOSTART is functional without system
> > partitions, and the additional support for system partitions can be
> > manually selected by the user.
> 
> I think it's a bit surprising to enable USB_GADGET_AUTOSTART and then
> see DFU and fastboot working, but not USB_GADGET_MASS_STORAGE.
> 
> If you have both USB_GADGET_MASS_STORAGE and USB_GADGET_AUTOSTART enabled,
> the user implicitly agrees to waste some space on them working together.

I was mistaken. I didn't realize that system partitions is the only way
to activate USB mass storage support automatically. Ok then, applied
this one with just the "select USB_GADGET" removed.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



  reply	other threads:[~2022-06-29  7:10 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-27 10:24 [PATCH 0/8] Misc fixes part III Alexander Shiyan
2022-06-27 10:24 ` [PATCH 1/8] ARM: vexpress: Simplify sysctl initialization Alexander Shiyan
2022-06-27 10:24 ` [PATCH 2/8] ARM: bcm2835: Drop uneeded headers Alexander Shiyan
2022-06-29  7:10   ` Sascha Hauer
2022-06-27 10:24 ` [PATCH 3/8] of: Use appropriate header for of_clk_init() Alexander Shiyan
2022-06-27 10:24 ` [PATCH 4/8] usb: gadget: Fix Kconfig dependencies Alexander Shiyan
2022-06-29  6:52   ` Sascha Hauer
2022-06-29  6:55     ` Ahmad Fatoum
2022-06-29  6:59       ` Sascha Hauer
2022-06-29  7:03         ` Ahmad Fatoum
2022-06-29  7:08           ` Sascha Hauer [this message]
2022-06-27 10:24 ` [PATCH 5/8] logo: " Alexander Shiyan
2022-06-27 10:24 ` [PATCH 6/8] pbl: " Alexander Shiyan
2022-06-30 11:57   ` Sascha Hauer
2022-06-27 10:24 ` [PATCH 7/8] ARM: mxs: " Alexander Shiyan
2022-06-27 10:25 ` [PATCH 8/8] ARM: boards: ccmx51: Remove unused KConfig option Alexander Shiyan
2022-06-29  7:10 ` [PATCH 0/8] Misc fixes part III Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220629070851.GL19026@pengutronix.de \
    --to=sha@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=afa@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=eagle.alexander923@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox