Re: [PATCH 4/8] usb: gadget: Fix Kconfig dependencies

[Sascha Hauer <sha@pengutronix.de>]

On Wed, Jun 29, 2022 at 09:03:41AM +0200, Ahmad Fatoum wrote:
> Hello Sascha,
> 
> On 29.06.22 08:59, Sascha Hauer wrote:
> > On Wed, Jun 29, 2022 at 08:55:46AM +0200, Ahmad Fatoum wrote:
> >> Hello Sascha,
> >>
> >> On 29.06.22 08:52, Sascha Hauer wrote:
> >>> Without GLOBALVAR selected the USB gadget autostart stuff can be
> >>> compiled, but without any functionality, as all functionality is
> >>> behind globalvars, so adding this dependency mykes sense.
> >>>
> >>>>  	select SYSTEM_PARTITIONS if USB_GADGET_MASS_STORAGE
> >>>
> >>> I am not sure why SYSTEM_PARTITIONS is selected here. Maybe Ahmad can
> >>> comment on that. From what I can see with USB_GADGET_AUTOSTART selected
> >>> without SYSTEM_PARTITIONS we still get autostart functionality, but
> >>> without global.system.partitions support which seems ok.
> >>
> >> Instead of adding yet another gadget-specific global variable,
> >> the mass storage gadget only uses system partitions, so this
> >> select makes sense IMO.
> > 
> > I would argument that USB_GADGET_AUTOSTART is functional without system
> > partitions, and the additional support for system partitions can be
> > manually selected by the user.
> 
> I think it's a bit surprising to enable USB_GADGET_AUTOSTART and then
> see DFU and fastboot working, but not USB_GADGET_MASS_STORAGE.
> 
> If you have both USB_GADGET_MASS_STORAGE and USB_GADGET_AUTOSTART enabled,
> the user implicitly agrees to waste some space on them working together.

I was mistaken. I didn't realize that system partitions is the only way
to activate USB mass storage support automatically. Ok then, applied
this one with just the "select USB_GADGET" removed.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |