From: Marco Felsch <m.felsch@pengutronix.de>
To: barebox@lists.infradead.org
Subject: [PATCH] common: bootm: print error in case of appendroot failed
Date: Mon, 4 Jul 2022 16:18:09 +0200 [thread overview]
Message-ID: <20220704141809.457135-1-m.felsch@pengutronix.de> (raw)
Inform the user that appendroot failed instead of silently dropping the
request. This makes the debugging easier e.g. if nt-signature wasn't set
correctly.
Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
common/bootm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/common/bootm.c b/common/bootm.c
index 3c80e8bf94..1c722afc80 100644
--- a/common/bootm.c
+++ b/common/bootm.c
@@ -729,6 +729,8 @@ int bootm_boot(struct bootm_data *bootm_data)
globalvar_add_simple("linux.bootargs.bootm.appendroot",
rootarg);
free(rootarg);
+ } else {
+ pr_err("Failed to append kernel cmdline parameter 'root='\n");
}
}
--
2.30.2
next reply other threads:[~2022-07-04 14:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-04 14:18 Marco Felsch [this message]
2022-07-05 8:19 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220704141809.457135-1-m.felsch@pengutronix.de \
--to=m.felsch@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox