From: Ahmad Fatoum <ahmad@a3f.at>
To: barebox@lists.infradead.org
Cc: Yannick FERTRE <yannick.fertre@foss.st.com>, Ahmad Fatoum <ahmad@a3f.at>
Subject: [PATCH 1/3] video: stm32: stm32_ltdc: fix data enable polarity
Date: Fri, 8 Jul 2022 07:52:48 +0200 [thread overview]
Message-ID: <20220708055250.1175444-1-ahmad@a3f.at> (raw)
From: Yannick FERTRE <yannick.fertre@foss.st.com>
Wrong DISPLAY_FLAGS used to set the data enable polarity.
Signed-off-by: Yannick FERTRE <yannick.fertre@foss.st.com>
Origin: https://st-md-mailman.stormreply.com/pipermail/uboot-stm32/2022-April/005122.html
[afa: cherry-picked from U-Boot driver]
Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
---
drivers/video/stm32_ltdc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/stm32_ltdc.c b/drivers/video/stm32_ltdc.c
index 645c20b5545f..9dc35ade6124 100644
--- a/drivers/video/stm32_ltdc.c
+++ b/drivers/video/stm32_ltdc.c
@@ -98,7 +98,7 @@ static void ltdc_set_mode(struct ltdc_fb *priv,
val |= GCR_HSPOL;
if (mode->sync & FB_SYNC_VERT_HIGH_ACT)
val |= GCR_VSPOL;
- if (mode->display_flags & DISPLAY_FLAGS_DE_HIGH)
+ if (mode->display_flags & DISPLAY_FLAGS_DE_LOW)
val |= GCR_DEPOL;
if (mode->display_flags & DISPLAY_FLAGS_PIXDATA_NEGEDGE)
val |= GCR_PCPOL;
--
2.34.1
next reply other threads:[~2022-07-08 5:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-08 5:52 Ahmad Fatoum [this message]
2022-07-08 5:52 ` [PATCH 2/3] pinctrl: stm32: keep GPIO bank clocks enabled throughout Ahmad Fatoum
2022-07-08 5:52 ` [PATCH 3/3] spi: stm32: fix reads for sizes bigger than SZ_64K-1 Ahmad Fatoum
2022-07-11 10:43 ` [PATCH 1/3] video: stm32: stm32_ltdc: fix data enable polarity Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220708055250.1175444-1-ahmad@a3f.at \
--to=ahmad@a3f.at \
--cc=barebox@lists.infradead.org \
--cc=yannick.fertre@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox