mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <>
To: Sascha Hauer <>
Cc: Barebox List <>
Subject: Re: [PATCH] fs: Check if automount actually mounts something
Date: Thu, 14 Jul 2022 23:12:38 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

[-- Attachment #1: Type: text/plain, Size: 926 bytes --]

On Thu, Jul 14, 2022 at 09:35:09PM +0200, Sascha Hauer wrote:
> An automount command that returns successfully but doesn't mount
> anything makes barebox hang as can be reproduced with:
> automount -d /mnt/foo true
> ls /mnt/foo
> Check if the current dentry is a mountpoint after running the automount
> command, otherwise return with an error from automount_mount().

While I think the intention of this patch is fine, I have little doubts
if that breaks some workflows, e.g. something like:

	automount -d /mnt/tralala 'for p in 0 1 2; do mkdir ${automount_path}/${p} && mount /dev/disk0.${p} ${automount_path}/${p} || break; done'

I admit it's a bit constructed, but maybe that's only because I'm not
creative enough?

Best regards

Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2022-07-14 21:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-14 19:35 Sascha Hauer
2022-07-14 21:12 ` Uwe Kleine-König [this message]
2022-08-09 10:06   ` Sascha Hauer
2022-08-09 13:05     ` Uwe Kleine-König
2022-08-10  6:44       ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox