Re: [PATCH] pstore: disable double memory reservation fixup

[Sascha Hauer <sha@pengutronix.de>]

On Mon, Aug 15, 2022 at 08:40:01AM +0200, Ahmad Fatoum wrote:
> Device tree fixup ramoops_of_fixup registered directly after
> of_add_reserve_entry already takes care to create a /reserved-memory
> entry, so adding one to the FDT reserved memory list is redundant.
> Thus keep only the /reserved-memory entry.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  fs/pstore/ram.c | 1 -
>  1 file changed, 1 deletion(-)

Applied, thanks

Sascha

> 
> diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
> index 0d8bb8f418f4..b484ecd55201 100644
> --- a/fs/pstore/ram.c
> +++ b/fs/pstore/ram.c
> @@ -639,7 +639,6 @@ static int ramoops_probe(struct device_d *dev)
>  			  ramoops_ecc);
>  		globalvar_add_simple("linux.bootargs.ramoops", kernelargs);
>  	} else {
> -		of_add_reserve_entry(cxt->phys_addr, cxt->phys_addr + mem_size);
>  		of_register_fixup(ramoops_of_fixup, pdata);
>  	}
>  
> -- 
> 2.30.2
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |