* [PATCH] pstore: disable double memory reservation fixup
@ 2022-08-15 6:40 Ahmad Fatoum
2022-08-16 6:33 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2022-08-15 6:40 UTC (permalink / raw)
To: barebox; +Cc: Ahmad Fatoum
Device tree fixup ramoops_of_fixup registered directly after
of_add_reserve_entry already takes care to create a /reserved-memory
entry, so adding one to the FDT reserved memory list is redundant.
Thus keep only the /reserved-memory entry.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
fs/pstore/ram.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
index 0d8bb8f418f4..b484ecd55201 100644
--- a/fs/pstore/ram.c
+++ b/fs/pstore/ram.c
@@ -639,7 +639,6 @@ static int ramoops_probe(struct device_d *dev)
ramoops_ecc);
globalvar_add_simple("linux.bootargs.ramoops", kernelargs);
} else {
- of_add_reserve_entry(cxt->phys_addr, cxt->phys_addr + mem_size);
of_register_fixup(ramoops_of_fixup, pdata);
}
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] pstore: disable double memory reservation fixup
2022-08-15 6:40 [PATCH] pstore: disable double memory reservation fixup Ahmad Fatoum
@ 2022-08-16 6:33 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2022-08-16 6:33 UTC (permalink / raw)
To: Ahmad Fatoum; +Cc: barebox
On Mon, Aug 15, 2022 at 08:40:01AM +0200, Ahmad Fatoum wrote:
> Device tree fixup ramoops_of_fixup registered directly after
> of_add_reserve_entry already takes care to create a /reserved-memory
> entry, so adding one to the FDT reserved memory list is redundant.
> Thus keep only the /reserved-memory entry.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> fs/pstore/ram.c | 1 -
> 1 file changed, 1 deletion(-)
Applied, thanks
Sascha
>
> diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
> index 0d8bb8f418f4..b484ecd55201 100644
> --- a/fs/pstore/ram.c
> +++ b/fs/pstore/ram.c
> @@ -639,7 +639,6 @@ static int ramoops_probe(struct device_d *dev)
> ramoops_ecc);
> globalvar_add_simple("linux.bootargs.ramoops", kernelargs);
> } else {
> - of_add_reserve_entry(cxt->phys_addr, cxt->phys_addr + mem_size);
> of_register_fixup(ramoops_of_fixup, pdata);
> }
>
> --
> 2.30.2
>
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-16 6:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-15 6:40 [PATCH] pstore: disable double memory reservation fixup Ahmad Fatoum
2022-08-16 6:33 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox