mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
To: barebox@lists.infradead.org
Cc: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
Subject: [PATCH 0/8] tftp fixups
Date: Sun, 28 Aug 2022 16:02:23 +0200	[thread overview]
Message-ID: <20220828140231.930643-1-enrico.scholz@sigma-chemnitz.de> (raw)

The "tftp: allocate buffers and fifo dynamically" patch in the last
patchset broke interaction with non rfc 2347 servers (e.g. when data
transfer starts immediately after RRQ/WRQ without the OACK negotiation
phase).

This has been fixed for both RRQ and WRQ requests.

For WRQ requests (push), the "tsize" option will not be sent anymore
because it is always '0' and can confuse servers.

New patches add some sanity checks which prevent modification of
internal information (blocksize or port numbers) when OACK packets
arrive in the middle of a transfer.


Enrico Scholz (8):
  tftp: make debug_assert() critical when selftest is enabled.
  tftp: remove sanity check of first block
  tftp: split out allocation and cache initialization
  tftp: accept OACK + DATA datagrams only in certain states
  tftp: support non rfc 2347 servers
  tftp: do not set 'tsize' in wrq requests
  tftp: fix WRQ support
  tftp: add some documentation about windowsize support

 Documentation/filesystems/tftp.rst |  38 ++++++
 fs/tftp.c                          | 189 +++++++++++++++++++----------
 2 files changed, 166 insertions(+), 61 deletions(-)

-- 
2.37.2




             reply	other threads:[~2022-08-28 14:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-28 14:02 Enrico Scholz [this message]
2022-08-28 14:02 ` [PATCH 1/8] tftp: make debug_assert() critical when selftest is enabled Enrico Scholz
2022-08-28 14:02 ` [PATCH 2/8] tftp: remove sanity check of first block Enrico Scholz
2022-08-28 14:02 ` [PATCH 3/8] tftp: split out allocation and cache initialization Enrico Scholz
2022-08-28 14:02 ` [PATCH 4/8] tftp: accept OACK + DATA datagrams only in certain states Enrico Scholz
2022-08-28 14:02 ` [PATCH 5/8] tftp: support non rfc 2347 servers Enrico Scholz
2022-08-28 14:02 ` [PATCH 6/8] tftp: do not set 'tsize' in wrq requests Enrico Scholz
2022-08-28 14:02 ` [PATCH 7/8] tftp: fix WRQ support Enrico Scholz
2022-08-28 14:02 ` [PATCH 8/8] tftp: add some documentation about windowsize support Enrico Scholz
2022-08-29 10:52 ` [PATCH 0/8] tftp fixups Ahmad Fatoum
2022-08-30  7:30   ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220828140231.930643-1-enrico.scholz@sigma-chemnitz.de \
    --to=enrico.scholz@sigma-chemnitz.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox