mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <sha@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>,
	barebox@lists.infradead.org
Subject: Re: [PATCH 0/8] tftp fixups
Date: Tue, 30 Aug 2022 09:30:34 +0200	[thread overview]
Message-ID: <20220830073034.GE24324@pengutronix.de> (raw)
In-Reply-To: <ad848886-ba94-1e34-0ae8-4157a19e8404@pengutronix.de>

On Mon, Aug 29, 2022 at 12:52:16PM +0200, Ahmad Fatoum wrote:
> Hello Enrico,
> 
> On 28.08.22 16:02, Enrico Scholz wrote:
> > The "tftp: allocate buffers and fifo dynamically" patch in the last
> > patchset broke interaction with non rfc 2347 servers (e.g. when data
> > transfer starts immediately after RRQ/WRQ without the OACK negotiation
> > phase).
> > 
> > This has been fixed for both RRQ and WRQ requests.
> > 
> > For WRQ requests (push), the "tsize" option will not be sent anymore
> > because it is always '0' and can confuse servers.
> > 
> > New patches add some sanity checks which prevent modification of
> > internal information (blocksize or port numbers) when OACK packets
> > arrive in the middle of a transfer.
> 
> The patch introducing the regression is still in next, which can be
> rebased unlike master. Perhaps it would be best you provide a fixup
> for the commit in question (or a revised series, if it would cause
> conflicts for later commits)? That way, we don't end up with breakage
> when doing a bisect in future.

Yes, please. Both a fixup patch or a revised series would be fine with
me.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



      reply	other threads:[~2022-08-30  7:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-28 14:02 Enrico Scholz
2022-08-28 14:02 ` [PATCH 1/8] tftp: make debug_assert() critical when selftest is enabled Enrico Scholz
2022-08-28 14:02 ` [PATCH 2/8] tftp: remove sanity check of first block Enrico Scholz
2022-08-28 14:02 ` [PATCH 3/8] tftp: split out allocation and cache initialization Enrico Scholz
2022-08-28 14:02 ` [PATCH 4/8] tftp: accept OACK + DATA datagrams only in certain states Enrico Scholz
2022-08-28 14:02 ` [PATCH 5/8] tftp: support non rfc 2347 servers Enrico Scholz
2022-08-28 14:02 ` [PATCH 6/8] tftp: do not set 'tsize' in wrq requests Enrico Scholz
2022-08-28 14:02 ` [PATCH 7/8] tftp: fix WRQ support Enrico Scholz
2022-08-28 14:02 ` [PATCH 8/8] tftp: add some documentation about windowsize support Enrico Scholz
2022-08-29 10:52 ` [PATCH 0/8] tftp fixups Ahmad Fatoum
2022-08-30  7:30   ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220830073034.GE24324@pengutronix.de \
    --to=sha@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=enrico.scholz@sigma-chemnitz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox