mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH v2] test: self: only include ramfs selftest when CONFIG_SELFTEST_FS_RAMFS=y
@ 2022-11-01  6:32 Ahmad Fatoum
  2022-11-02  7:51 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2022-11-01  6:32 UTC (permalink / raw)
  To: barebox; +Cc: Ahmad Fatoum

So far, we ignored the symbol and built the test always when
CONFIG_SELFTEST=y and CONFIG_FS_RAMFS=y.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
v1 -> v2:
  - moved out of other series. No other changes.
 test/self/Kconfig  | 2 +-
 test/self/Makefile | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/test/self/Kconfig b/test/self/Kconfig
index f3cb6601e3b8..5c6981959921 100644
--- a/test/self/Kconfig
+++ b/test/self/Kconfig
@@ -33,7 +33,7 @@ config SELFTEST_ENABLE_ALL
 	select SELFTEST_PROGRESS_NOTIFIER
 	select SELFTEST_OF_MANIPULATION
 	select SELFTEST_ENVIRONMENT_VARIABLES if ENVIRONMENT_VARIABLES
-	select SELFTEST_FS_RAMFS
+	imply SELFTEST_FS_RAMFS
 	imply SELFTEST_TFTP
 	help
 	  Selects all self-tests compatible with current configuration
diff --git a/test/self/Makefile b/test/self/Makefile
index 6f2c0d394034..c7c729cba0e0 100644
--- a/test/self/Makefile
+++ b/test/self/Makefile
@@ -6,4 +6,4 @@ obj-$(CONFIG_SELFTEST_PRINTF) += printf.o
 obj-$(CONFIG_SELFTEST_PROGRESS_NOTIFIER) += progress-notifier.o
 obj-$(CONFIG_SELFTEST_OF_MANIPULATION) += of_manipulation.o of_manipulation.dtb.o
 obj-$(CONFIG_SELFTEST_ENVIRONMENT_VARIABLES) += envvar.o
-obj-$(CONFIG_FS_RAMFS) += ramfs.o
+obj-$(CONFIG_SELFTEST_FS_RAMFS) += ramfs.o
-- 
2.30.2




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] test: self: only include ramfs selftest when CONFIG_SELFTEST_FS_RAMFS=y
  2022-11-01  6:32 [PATCH v2] test: self: only include ramfs selftest when CONFIG_SELFTEST_FS_RAMFS=y Ahmad Fatoum
@ 2022-11-02  7:51 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2022-11-02  7:51 UTC (permalink / raw)
  To: Ahmad Fatoum; +Cc: barebox

On Tue, Nov 01, 2022 at 07:32:16AM +0100, Ahmad Fatoum wrote:
> So far, we ignored the symbol and built the test always when
> CONFIG_SELFTEST=y and CONFIG_FS_RAMFS=y.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> v1 -> v2:
>   - moved out of other series. No other changes.
>  test/self/Kconfig  | 2 +-
>  test/self/Makefile | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Applied, thanks

Sascha

> 
> diff --git a/test/self/Kconfig b/test/self/Kconfig
> index f3cb6601e3b8..5c6981959921 100644
> --- a/test/self/Kconfig
> +++ b/test/self/Kconfig
> @@ -33,7 +33,7 @@ config SELFTEST_ENABLE_ALL
>  	select SELFTEST_PROGRESS_NOTIFIER
>  	select SELFTEST_OF_MANIPULATION
>  	select SELFTEST_ENVIRONMENT_VARIABLES if ENVIRONMENT_VARIABLES
> -	select SELFTEST_FS_RAMFS
> +	imply SELFTEST_FS_RAMFS
>  	imply SELFTEST_TFTP
>  	help
>  	  Selects all self-tests compatible with current configuration
> diff --git a/test/self/Makefile b/test/self/Makefile
> index 6f2c0d394034..c7c729cba0e0 100644
> --- a/test/self/Makefile
> +++ b/test/self/Makefile
> @@ -6,4 +6,4 @@ obj-$(CONFIG_SELFTEST_PRINTF) += printf.o
>  obj-$(CONFIG_SELFTEST_PROGRESS_NOTIFIER) += progress-notifier.o
>  obj-$(CONFIG_SELFTEST_OF_MANIPULATION) += of_manipulation.o of_manipulation.dtb.o
>  obj-$(CONFIG_SELFTEST_ENVIRONMENT_VARIABLES) += envvar.o
> -obj-$(CONFIG_FS_RAMFS) += ramfs.o
> +obj-$(CONFIG_SELFTEST_FS_RAMFS) += ramfs.o
> -- 
> 2.30.2
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-11-02  7:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-01  6:32 [PATCH v2] test: self: only include ramfs selftest when CONFIG_SELFTEST_FS_RAMFS=y Ahmad Fatoum
2022-11-02  7:51 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox