mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Marco Felsch <m.felsch@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] ARM: i.MX8M: atf: prefix log messages via pr_fmt()
Date: Wed, 2 Nov 2022 08:58:41 +0100	[thread overview]
Message-ID: <20221102075841.t74tkl7l2wax6ils@pengutronix.de> (raw)
In-Reply-To: <20221101180421.241328-1-a.fatoum@pengutronix.de>

On 22-11-01, Ahmad Fatoum wrote:
> We have a couple of log messages in the file, so ensure they are
> appropriately prefixed.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  arch/arm/mach-imx/atf.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/mach-imx/atf.c b/arch/arm/mach-imx/atf.c
> index 5301c0fbe8e5..67462bc36189 100644
> --- a/arch/arm/mach-imx/atf.c
> +++ b/arch/arm/mach-imx/atf.c
> @@ -1,5 +1,7 @@
>  // SPDX-License-Identifier: GPL-2.0-only
>  
> +#define pr_fmt(fmt) "imx8m-atf: " fmt

Just "atf:" or "imx-atf:"? This code may shared with upcoming imx
processors as well, so "imx8m-atf:" would be a bit to specific.

Regards,
  Marco

> +
>  #include <asm/sections.h>
>  #include <common.h>
>  #include <firmware.h>
> -- 
> 2.30.2
> 
> 
> 



  reply	other threads:[~2022-11-02  8:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-01 18:04 Ahmad Fatoum
2022-11-02  7:58 ` Marco Felsch [this message]
2022-11-02  8:19   ` Sascha Hauer
2022-11-02  8:56     ` Ahmad Fatoum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221102075841.t74tkl7l2wax6ils@pengutronix.de \
    --to=m.felsch@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox