Re: [PATCH] ARM: i.MX8M: atf: prefix log messages via pr_fmt()

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

On 02.11.22 09:19, Sascha Hauer wrote:
> On Wed, Nov 02, 2022 at 08:58:41AM +0100, Marco Felsch wrote:
>> On 22-11-01, Ahmad Fatoum wrote:
>>> We have a couple of log messages in the file, so ensure they are
>>> appropriately prefixed.
>>>
>>> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
>>> ---
>>>  arch/arm/mach-imx/atf.c | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/arch/arm/mach-imx/atf.c b/arch/arm/mach-imx/atf.c
>>> index 5301c0fbe8e5..67462bc36189 100644
>>> --- a/arch/arm/mach-imx/atf.c
>>> +++ b/arch/arm/mach-imx/atf.c
>>> @@ -1,5 +1,7 @@
>>>  // SPDX-License-Identifier: GPL-2.0-only
>>>  
>>> +#define pr_fmt(fmt) "imx8m-atf: " fmt
>>
>> Just "atf:" or "imx-atf:"? This code may shared with upcoming imx
>> processors as well, so "imx8m-atf:" would be a bit to specific.
> 
> "imx-atf: " sounds appropriate.

That's confusing, because users may believe this is actual imx-atf output.
Looking at the two log messages in the file, they are both about SDPS
(serial download), so all suggestions are misleading. Perhaps the file
should just be renamed. Please dismiss this patch.

> 
> Sascha
> 
> 
>>
>> Regards,
>>   Marco
>>
>>> +
>>>  #include <asm/sections.h>
>>>  #include <common.h>
>>>  #include <firmware.h>
>>> -- 
>>> 2.30.2
>>>
>>>
>>>
>>
>>
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |