[PATCH] video: vpl: don't print only skipped vpl endpoints

[PATCH] video: vpl: don't print only skipped vpl endpoints

[Ahmad Fatoum]

The remote_vpl->ioctl is within a loop and every time an iteration is
skipped, a debug line is printed, but no debug line is printed when the
loop actually finds a remote_vpl to call its ioctl callback.

Make this debugging code more useful by adding a debug print in the
latter case.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 drivers/video/vpl.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/video/vpl.c b/drivers/video/vpl.c
index f94bd4a3e2f3..6d6786168114 100644
--- a/drivers/video/vpl.c
+++ b/drivers/video/vpl.c
@@ -93,6 +93,7 @@ int vpl_ioctl(struct vpl *vpl, unsigned int port,
 			continue;
 		}
 
+		pr_debug("%s: looked up %s: %pS\n", __func__, remote->full_name, remote_vpl->ioctl);
 		ret = remote_vpl->ioctl(remote_vpl, remote_port_id, cmd, ptr);
 		if (ret)
 			return ret;
-- 
2.30.2

Re: [PATCH] video: vpl: don't print only skipped vpl endpoints

[Sascha Hauer]

On Thu, Dec 22, 2022 at 12:57:59PM +0100, Ahmad Fatoum wrote:
> The remote_vpl->ioctl is within a loop and every time an iteration is
> skipped, a debug line is printed, but no debug line is printed when the
> loop actually finds a remote_vpl to call its ioctl callback.
> 
> Make this debugging code more useful by adding a debug print in the
> latter case.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  drivers/video/vpl.c | 1 +
>  1 file changed, 1 insertion(+)

Applied, thanks

Sascha

> 
> diff --git a/drivers/video/vpl.c b/drivers/video/vpl.c
> index f94bd4a3e2f3..6d6786168114 100644
> --- a/drivers/video/vpl.c
> +++ b/drivers/video/vpl.c
> @@ -93,6 +93,7 @@ int vpl_ioctl(struct vpl *vpl, unsigned int port,
>  			continue;
>  		}
>  
> +		pr_debug("%s: looked up %s: %pS\n", __func__, remote->full_name, remote_vpl->ioctl);
>  		ret = remote_vpl->ioctl(remote_vpl, remote_port_id, cmd, ptr);
>  		if (ret)
>  			return ret;
> -- 
> 2.30.2
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |