mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] regulator: scmi: rename struct scmi_regulator::device_node to of_node
@ 2023-01-09 15:19 Ahmad Fatoum
  2023-01-10 14:55 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2023-01-09 15:19 UTC (permalink / raw)
  To: barebox; +Cc: Ahmad Fatoum

The naming is different than the Linux driver and was only chosen for
symmetry with device_d::device_node. Now that this is renamed to
device:of_node, follow suite in the barebox driver.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 drivers/regulator/scmi-regulator.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/regulator/scmi-regulator.c b/drivers/regulator/scmi-regulator.c
index 22813ce66248..2a007ac620a1 100644
--- a/drivers/regulator/scmi-regulator.c
+++ b/drivers/regulator/scmi-regulator.c
@@ -44,7 +44,7 @@ struct scmi_regulator {
 	struct scmi_device *sdev;
 	struct scmi_protocol_handle *ph;
 	struct regulator_dev rdev;
-	struct device_node *device_node;
+	struct device_node *of_node;
 	struct scmi_reg_desc sdesc;
 };
 
@@ -232,7 +232,7 @@ static int scmi_regulator_common_init(struct scmi_regulator *sreg)
 	 */
 	if (vinfo->negative_volts_allowed) {
 		dev_warn(dev, "Negative voltages NOT supported...skip %s\n",
-			 sreg->device_node->full_name);
+			 sreg->of_node->full_name);
 		return -EOPNOTSUPP;
 	}
 
@@ -278,7 +278,7 @@ static int process_scmi_regulator_of_node(struct scmi_device *sdev,
 	rinfo->sregv[dom]->ph = ph;
 
 	/* get hold of good nodes */
-	rinfo->sregv[dom]->device_node = np;
+	rinfo->sregv[dom]->of_node = np;
 
 	dev_dbg(&sdev->dev,
 		"Found SCMI Regulator entry -- OF node [%d] -> %s\n",
-- 
2.30.2




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] regulator: scmi: rename struct scmi_regulator::device_node to of_node
  2023-01-09 15:19 [PATCH] regulator: scmi: rename struct scmi_regulator::device_node to of_node Ahmad Fatoum
@ 2023-01-10 14:55 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2023-01-10 14:55 UTC (permalink / raw)
  To: Ahmad Fatoum; +Cc: barebox

On Mon, Jan 09, 2023 at 04:19:44PM +0100, Ahmad Fatoum wrote:
> The naming is different than the Linux driver and was only chosen for
> symmetry with device_d::device_node. Now that this is renamed to
> device:of_node, follow suite in the barebox driver.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  drivers/regulator/scmi-regulator.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Applied, thanks

Sascha

> 
> diff --git a/drivers/regulator/scmi-regulator.c b/drivers/regulator/scmi-regulator.c
> index 22813ce66248..2a007ac620a1 100644
> --- a/drivers/regulator/scmi-regulator.c
> +++ b/drivers/regulator/scmi-regulator.c
> @@ -44,7 +44,7 @@ struct scmi_regulator {
>  	struct scmi_device *sdev;
>  	struct scmi_protocol_handle *ph;
>  	struct regulator_dev rdev;
> -	struct device_node *device_node;
> +	struct device_node *of_node;
>  	struct scmi_reg_desc sdesc;
>  };
>  
> @@ -232,7 +232,7 @@ static int scmi_regulator_common_init(struct scmi_regulator *sreg)
>  	 */
>  	if (vinfo->negative_volts_allowed) {
>  		dev_warn(dev, "Negative voltages NOT supported...skip %s\n",
> -			 sreg->device_node->full_name);
> +			 sreg->of_node->full_name);
>  		return -EOPNOTSUPP;
>  	}
>  
> @@ -278,7 +278,7 @@ static int process_scmi_regulator_of_node(struct scmi_device *sdev,
>  	rinfo->sregv[dom]->ph = ph;
>  
>  	/* get hold of good nodes */
> -	rinfo->sregv[dom]->device_node = np;
> +	rinfo->sregv[dom]->of_node = np;
>  
>  	dev_dbg(&sdev->dev,
>  		"Found SCMI Regulator entry -- OF node [%d] -> %s\n",
> -- 
> 2.30.2
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-01-10 14:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-09 15:19 [PATCH] regulator: scmi: rename struct scmi_regulator::device_node to of_node Ahmad Fatoum
2023-01-10 14:55 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox