From: Sascha Hauer <sha@pengutronix.de>
To: Ahmad Fatoum <ahmad@a3f.at>
Cc: barebox@lists.infradead.org, Marco Felsch <m.felsch@pengutronix.de>
Subject: Re: [PATCH] RISC-V: virt: riscvemu: fix unit address in node name
Date: Fri, 3 Feb 2023 09:02:40 +0100 [thread overview]
Message-ID: <20230203080240.GT13319@pengutronix.de> (raw)
In-Reply-To: <20230202142000.3544631-1-ahmad@a3f.at>
On Thu, Feb 02, 2023 at 03:20:00PM +0100, Ahmad Fatoum wrote:
> The overlay adds a SRAM at address 0x1000, but the unit address was
> still 0, which is confusing. Change it to sram@1000 instead.
>
> Reported-by: Marco Felsch <m.felsch@pengutronix.de>
> Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
> ---
> arch/riscv/boards/riscvemu/overlay-of-sram.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks
Sascha
>
> diff --git a/arch/riscv/boards/riscvemu/overlay-of-sram.dts b/arch/riscv/boards/riscvemu/overlay-of-sram.dts
> index 506d45bde9b6..092fb02518b9 100644
> --- a/arch/riscv/boards/riscvemu/overlay-of-sram.dts
> +++ b/arch/riscv/boards/riscvemu/overlay-of-sram.dts
> @@ -9,7 +9,7 @@
> __overlay__ {
> #address-cells = <2>;
> #size-cells = <2>;
> - sram@0 {
> + sram@1000 {
> compatible = "mtd-ram";
> reg = <0 0x1000 0 0x10000>;
> #address-cells = <1>;
> @@ -49,7 +49,7 @@ fixed-partitions
> __overlay__ {
> environment {
> compatible = "barebox,environment";
> - device-path = "/soc/sram@0/partitions/partition@3000";
> + device-path = "/soc/sram@1000/partitions/partition@3000";
> };
> };
> };
> --
> 2.38.1
>
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
prev parent reply other threads:[~2023-02-03 8:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-02 14:20 Ahmad Fatoum
2023-02-02 14:41 ` Marco Felsch
2023-02-03 8:02 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230203080240.GT13319@pengutronix.de \
--to=sha@pengutronix.de \
--cc=ahmad@a3f.at \
--cc=barebox@lists.infradead.org \
--cc=m.felsch@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox