mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Steffen Trumtrar <s.trumtrar@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH v4 04/15] mci: arasan: implement 25MHz quirk for zynqmp
Date: Mon, 18 Mar 2024 11:18:18 +0100	[thread overview]
Message-ID: <20240318-v2024-02-0-topic-arasan-hs200-support-v4-4-48756863add6@pengutronix.de> (raw)
In-Reply-To: <20240318-v2024-02-0-topic-arasan-hs200-support-v4-0-48756863add6@pengutronix.de>

The Arasan on the zynqmp in version 8.9a doesn't meet the timing
requirements at 25MHz. It works at 19MHz instead.

Add the quirk from linux kernel v6.8-rc4.

Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 drivers/mci/arasan-sdhci.c | 28 +++++++++++++++++++++++++++-
 1 file changed, 27 insertions(+), 1 deletion(-)

diff --git a/drivers/mci/arasan-sdhci.c b/drivers/mci/arasan-sdhci.c
index 98f990b5c1..77e6086165 100644
--- a/drivers/mci/arasan-sdhci.c
+++ b/drivers/mci/arasan-sdhci.c
@@ -37,6 +37,12 @@ struct arasan_sdhci_host {
 /* Controller does not have CD wired and will not function normally without */
 #define SDHCI_ARASAN_QUIRK_FORCE_CDTEST		BIT(0)
 #define SDHCI_ARASAN_QUIRK_NO_1_8_V		BIT(1)
+/*
+ * Some of the Arasan variations might not have timing requirements
+ * met at 25MHz for Default Speed mode, those controllers work at
+ * 19MHz instead
+ */
+#define SDHCI_ARASAN_QUIRK_CLOCK_25_BROKEN	BIT(2)
 };
 
 static inline
@@ -110,13 +116,30 @@ static int arasan_sdhci_init(struct mci_host *mci, struct device *dev)
 	return 0;
 }
 
+static void arasan_sdhci_set_clock(struct mci_host *mci, unsigned int clock)
+{
+	struct arasan_sdhci_host *host = to_arasan_sdhci_host(mci);
+
+	if (host->quirks & SDHCI_ARASAN_QUIRK_CLOCK_25_BROKEN) {
+		/*
+		 * Some of the Arasan variations might not have timing
+		 * requirements met at 25MHz for Default Speed mode,
+		 * those controllers work at 19MHz instead.
+		 */
+		if (clock == 25000000)
+			clock = (25000000 * 19) / 25;
+	}
+
+	sdhci_set_clock(&host->sdhci, clock, host->sdhci.max_clk);
+}
+
 static void arasan_sdhci_set_ios(struct mci_host *mci, struct mci_ios *ios)
 {
 	struct arasan_sdhci_host *host = to_arasan_sdhci_host(mci);
 	u16 val;
 
 	if (ios->clock)
-		sdhci_set_clock(&host->sdhci, ios->clock, host->sdhci.max_clk);
+		arasan_sdhci_set_clock(mci, ios->clock);
 
 	sdhci_set_bus_width(&host->sdhci, ios->bus_width);
 
@@ -245,6 +268,9 @@ static int arasan_sdhci_probe(struct device *dev)
 	if (of_property_read_bool(np, "no-1-8-v"))
 		arasan_sdhci->quirks |= SDHCI_ARASAN_QUIRK_NO_1_8_V;
 
+	if (of_device_is_compatible(np, "xlnx,zynqmp-8.9a"))
+		arasan_sdhci->quirks |= SDHCI_ARASAN_QUIRK_CLOCK_25_BROKEN;
+
 	arasan_sdhci->sdhci.base = IOMEM(iores->start);
 	arasan_sdhci->sdhci.mci = mci;
 	mci->send_cmd = arasan_sdhci_send_cmd;

-- 
2.43.2




  parent reply	other threads:[~2024-03-18 10:23 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-18 10:18 [PATCH v4 00/15] mci: add HS200 support for eMMCs Steffen Trumtrar
2024-03-18 10:18 ` [PATCH v4 01/15] mci: arasan: fix dma support Steffen Trumtrar
2024-03-18 10:18 ` [PATCH v4 02/15] ARM: zynqmp: add sd_dll_reset call Steffen Trumtrar
2024-03-18 10:18 ` [PATCH v4 03/15] zynqmp: firmware: add functions to set tap delay Steffen Trumtrar
2024-03-18 10:18 ` Steffen Trumtrar [this message]
2024-03-18 10:18 ` [PATCH v4 05/15] include: mci: sync mci_timing with linux Steffen Trumtrar
2024-03-18 10:18 ` [PATCH v4 06/15] mci: arasan: read clk phases from DT Steffen Trumtrar
2024-03-18 10:18 ` [PATCH v4 07/15] mci: core: save the set clock as actual_clock Steffen Trumtrar
2024-03-18 10:18 ` [PATCH v4 08/15] mci: arasan: register sdcard/sampleclk Steffen Trumtrar
2024-03-18 10:18 ` [PATCH v4 09/15] include: mci: add more EXT_CSD_CARD_TYPE_* Steffen Trumtrar
2024-03-18 10:18 ` [PATCH v4 10/15] mci: core: parse more host capabilities from DT Steffen Trumtrar
2024-03-18 10:18 ` [PATCH v4 11/15] mci: mci-core: add HS200 support Steffen Trumtrar
2024-03-18 10:18 ` [PATCH v4 12/15] mci: mci-core: replace value with define Steffen Trumtrar
2024-03-18 10:18 ` [PATCH v4 13/15] mci: sdhci: add tuning support Steffen Trumtrar
2024-03-18 10:18 ` [PATCH v4 14/15] mci: arasan-sdhci: add HS200 tuning support on ZynqMP Steffen Trumtrar
2024-03-18 10:18 ` [PATCH v4 15/15] mci: sdhci: replace sdhci_wait_idle Steffen Trumtrar
2024-03-18 12:17 ` [PATCH v4 00/15] mci: add HS200 support for eMMCs Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240318-v2024-02-0-topic-arasan-hs200-support-v4-4-48756863add6@pengutronix.de \
    --to=s.trumtrar@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox