From: Michael Tretter <m.tretter@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: BAREBOX <barebox@lists.infradead.org>,
Steffen Trumtrar <s.trumtrar@pengutronix.de>,
Michael Tretter <m.tretter@pengutronix.de>
Subject: [PATCH] fixup! arm: socfgpa: iossm: extract initialization of one interface
Date: Wed, 15 Apr 2026 12:56:29 +0200 [thread overview]
Message-ID: <20260415105629.3994364-1-m.tretter@pengutronix.de> (raw)
In-Reply-To: <ad9o5HBwJw0je5UL@pengutronix.de>
Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
---
arch/arm/mach-socfpga/iossm_mailbox.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/arch/arm/mach-socfpga/iossm_mailbox.c b/arch/arm/mach-socfpga/iossm_mailbox.c
index 9fd50fe042de..9c34b3b2882c 100644
--- a/arch/arm/mach-socfpga/iossm_mailbox.c
+++ b/arch/arm/mach-socfpga/iossm_mailbox.c
@@ -603,10 +603,13 @@ static int bist_mem_init_by_addr(struct io96b_info *io96b_ctrl,
int bist_error = 0;
u32 mem_init_status;
int ret = 0;
- u32 mem_exp;
+#define BIST_ADDR_SPACE GENMASK(5, 0)
+#define BIST_FULL_MEM BIT(6)
+ u32 cmd_param_0;
if (io96b_ctrl->inline_ecc) {
phys_size_t chunk_size;
+ u32 mem_exp;
/* Check if size is a power of 2 */
if (size == 0 || (size & (size - 1)) != 0)
@@ -619,17 +622,18 @@ static int bist_mem_init_by_addr(struct io96b_info *io96b_ctrl,
pr_debug("%s: Initializing memory: Addr=0x%llx, Size=2^%u\n",
__func__, base_addr, mem_exp);
+ cmd_param_0 = FIELD_PREP(BIST_ADDR_SPACE, mem_exp);
} else {
pr_debug("%s: Start memory initialization BIST on full memory address",
__func__);
- mem_exp = 0x40;
+ cmd_param_0 = BIST_FULL_MEM;
}
ret = io96b_mb_req(io96b_csr_addr,
mb_ctrl->ip_type[interface],
mb_ctrl->ip_instance_id[interface],
CMD_TRIG_CONTROLLER_OP, BIST_MEM_INIT_START,
- FIELD_PREP(GENMASK(5, 0), mem_exp),
+ cmd_param_0,
FIELD_GET(GENMASK(31, 0), base_addr),
FIELD_GET(GENMASK(37, 32), base_addr),
0, 0, 0, 0, &usr_resp);
--
2.47.3
next prev parent reply other threads:[~2026-04-15 10:57 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-09 13:52 [PATCH v2 00/10] arm: socfpga: iossm: add support for mailbox v1 Michael Tretter
2026-04-09 13:52 ` [PATCH v2 01/10] arm: socfpga: iossm: remove uninitialized variable Michael Tretter
2026-04-09 13:52 ` [PATCH v2 02/10] arm: socfpga: iossm: add version check Michael Tretter
2026-04-10 8:18 ` Ahmad Fatoum
2026-04-10 13:24 ` Michael Tretter
2026-04-09 13:52 ` [PATCH v2 03/10] arm: socfpga: iossm: use local mb_ctrl variable Michael Tretter
2026-04-09 13:52 ` [PATCH v2 04/10] arm: socfpga: iossm: store size in bytes Michael Tretter
2026-04-10 8:13 ` Ahmad Fatoum
2026-04-10 8:31 ` Michael Tretter
2026-04-10 8:37 ` Ahmad Fatoum
2026-04-10 12:06 ` Michael Tretter
2026-04-13 7:27 ` Sascha Hauer
2026-04-09 13:52 ` [PATCH v2 05/10] arm: socfpga: iossm: refactor io96b_mb_init Michael Tretter
2026-04-09 13:52 ` [PATCH v2 06/10] arm: socfpga: iossm: refactor return value handling Michael Tretter
2026-04-09 13:52 ` [PATCH v2 07/10] arm: socfgpa: iossm: extract poll_bist_mem_init_status Michael Tretter
2026-04-09 13:52 ` [PATCH v2 08/10] arm: socfgpa: iossm: extract initialization of one interface Michael Tretter
2026-04-15 6:12 ` Sascha Hauer
2026-04-15 8:29 ` Michael Tretter
2026-04-15 10:31 ` Sascha Hauer
2026-04-15 10:56 ` Michael Tretter [this message]
2026-04-15 11:48 ` [PATCH] fixup! " Sascha Hauer
2026-04-09 13:52 ` [PATCH v2 09/10] arm: socfpga: iossm: add memory initialization with inline ecc Michael Tretter
2026-04-09 13:52 ` [PATCH v2 10/10] arm: socfpga: iossm: add support for mailbox v1 Michael Tretter
2026-04-10 8:19 ` [PATCH v2 00/10] " Ahmad Fatoum
2026-04-13 7:26 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260415105629.3994364-1-m.tretter@pengutronix.de \
--to=m.tretter@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
--cc=s.trumtrar@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox