mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [PATCH] ARM: dts: stm32mp: stm32mp135-dk: disable button on PA13
Date: Fri, 17 Apr 2026 14:20:02 +0200	[thread overview]
Message-ID: <20260417122004.2030708-1-a.fatoum@pengutronix.de> (raw)

After update to the v7.0-rc1 device trees, boot up on the board
reports following error:

  ERROR: gpiolib: _gpio_request: gpio-13 (led-red) status -16

This is caused by the combination of following two upstream kernel commits:

57012d79fefd ("ARM: dts: stm32: add UserPA13 button on stm32mp135f-dk")
31f0d9a486a8 ("ARM: dts: stm32: Add red LED for stm32mp135f-dk board")

Both reference the same &gpioa 13. Linux didn't seem to mind, but
barebox fails the LED driver probe, because the GPIO had already been
requested.

Assuming it is correct that they share the same GPIO physically,
Blinking the LED would register a button press, so it sounds not so
useful to have both enabled by default.

Thus disable the button in barebox.

This has been reported upstream at [1].

[1]: https://lore.kernel.org/all/382d28eb-557c-4cae-898c-8ed5c8cd7843@pengutronix.de/

Fixes: fe223ba39321 ("dts: update to v7.0-rc1")
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 arch/arm/dts/stm32mp135f-dk.dts | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/dts/stm32mp135f-dk.dts b/arch/arm/dts/stm32mp135f-dk.dts
index bf45276c864f..2887d153bc2d 100644
--- a/arch/arm/dts/stm32mp135f-dk.dts
+++ b/arch/arm/dts/stm32mp135f-dk.dts
@@ -16,3 +16,8 @@ environment {
 		};
 	};
 };
+
+&{/gpio-keys/button-user} {
+	/* The button shared the same GPIO as led-red */
+	barebox,status = "disabled";
+};
-- 
2.47.3




             reply	other threads:[~2026-04-17 12:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-17 12:20 Ahmad Fatoum [this message]
2026-04-22  8:03 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260417122004.2030708-1-a.fatoum@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox