* [PATCH] ARM: dts: stm32mp: stm32mp135-dk: disable button on PA13
@ 2026-04-17 12:20 Ahmad Fatoum
2026-04-22 8:03 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2026-04-17 12:20 UTC (permalink / raw)
To: barebox; +Cc: Ahmad Fatoum
After update to the v7.0-rc1 device trees, boot up on the board
reports following error:
ERROR: gpiolib: _gpio_request: gpio-13 (led-red) status -16
This is caused by the combination of following two upstream kernel commits:
57012d79fefd ("ARM: dts: stm32: add UserPA13 button on stm32mp135f-dk")
31f0d9a486a8 ("ARM: dts: stm32: Add red LED for stm32mp135f-dk board")
Both reference the same &gpioa 13. Linux didn't seem to mind, but
barebox fails the LED driver probe, because the GPIO had already been
requested.
Assuming it is correct that they share the same GPIO physically,
Blinking the LED would register a button press, so it sounds not so
useful to have both enabled by default.
Thus disable the button in barebox.
This has been reported upstream at [1].
[1]: https://lore.kernel.org/all/382d28eb-557c-4cae-898c-8ed5c8cd7843@pengutronix.de/
Fixes: fe223ba39321 ("dts: update to v7.0-rc1")
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
arch/arm/dts/stm32mp135f-dk.dts | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm/dts/stm32mp135f-dk.dts b/arch/arm/dts/stm32mp135f-dk.dts
index bf45276c864f..2887d153bc2d 100644
--- a/arch/arm/dts/stm32mp135f-dk.dts
+++ b/arch/arm/dts/stm32mp135f-dk.dts
@@ -16,3 +16,8 @@ environment {
};
};
};
+
+&{/gpio-keys/button-user} {
+ /* The button shared the same GPIO as led-red */
+ barebox,status = "disabled";
+};
--
2.47.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: dts: stm32mp: stm32mp135-dk: disable button on PA13
2026-04-17 12:20 [PATCH] ARM: dts: stm32mp: stm32mp135-dk: disable button on PA13 Ahmad Fatoum
@ 2026-04-22 8:03 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2026-04-22 8:03 UTC (permalink / raw)
To: barebox, Ahmad Fatoum
On Fri, 17 Apr 2026 14:20:02 +0200, Ahmad Fatoum wrote:
> After update to the v7.0-rc1 device trees, boot up on the board
> reports following error:
>
> ERROR: gpiolib: _gpio_request: gpio-13 (led-red) status -16
>
> This is caused by the combination of following two upstream kernel commits:
>
> [...]
Applied, thanks!
[1/1] ARM: dts: stm32mp: stm32mp135-dk: disable button on PA13
https://git.pengutronix.de/cgit/barebox/commit/?id=ce99330b64f3 (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-04-22 8:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-04-17 12:20 [PATCH] ARM: dts: stm32mp: stm32mp135-dk: disable button on PA13 Ahmad Fatoum
2026-04-22 8:03 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox