mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Michael Tretter <m.tretter@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>,
	 BAREBOX <barebox@lists.infradead.org>
Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de>,
	 Michael Tretter <m.tretter@pengutronix.de>
Subject: [PATCH] ARM: dts: socfpga: AXE5-Eagle: fix phy reset
Date: Wed, 22 Apr 2026 17:56:11 +0200	[thread overview]
Message-ID: <20260422-socfpga-agilex5-dwmac-v1-1-648a33bd9ec2@pengutronix.de> (raw)

The snps,reset-gpio is a property of the Synopsys DesignWare MAC and
belongs into the gmac node.

The property is deprecated and shall be replaced by regular gpio reset
at the phy. However, use the deprecated binding to be sure that the
dwmac driver handles the reset for now.

Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
---
 arch/arm/dts/socfpga_agilex5_axe5_eagle.dts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/dts/socfpga_agilex5_axe5_eagle.dts b/arch/arm/dts/socfpga_agilex5_axe5_eagle.dts
index f67b974f2adc..732d6142dcb1 100644
--- a/arch/arm/dts/socfpga_agilex5_axe5_eagle.dts
+++ b/arch/arm/dts/socfpga_agilex5_axe5_eagle.dts
@@ -74,16 +74,16 @@ &gmac2 {
 	status = "okay";
 	phy-mode = "rgmii-id";
 	phy-handle = <&emac2_phy0>;
-
 	max-frame-size = <9000>;
+	snps,reset-gpio = <&portb 10 GPIO_ACTIVE_LOW>;
+	snps,reset-active-low;
+	snps,reset-delays-us = <0 10000 10000>;
 
 	mdio0 {
 		#address-cells = <1>;
 		#size-cells = <0>;
 		compatible = "snps,dwmac-mdio";
 		emac2_phy0: ethernet-phy@1 {
-			snps,reset-gpio = <&portb 10 GPIO_ACTIVE_LOW>;
-			snps,reset-delays-us = <0 10000 10000>;
 			reg = <0x1>;
 			adi,rx-internal-delay-ps = <2000>;
 			adi,tx-internal-delay-ps = <2000>;

---
base-commit: 7b492daea9347fd55bf29560c2ec494ca1040f95
change-id: 20260422-socfpga-agilex5-dwmac-9d45a7c123a8

Best regards,
-- 
Michael Tretter <m.tretter@pengutronix.de>




             reply	other threads:[~2026-04-22 15:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-22 15:56 Michael Tretter [this message]
2026-04-27  7:20 ` Sascha Hauer
2026-04-27 10:55   ` Michael Tretter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260422-socfpga-agilex5-dwmac-v1-1-648a33bd9ec2@pengutronix.de \
    --to=m.tretter@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    --cc=s.trumtrar@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox