[PATCH] net: dsa: don't index the port array one entry past its end

[PATCH] net: dsa: don't index the port array one entry past its end

[Ahmad Fatoum]

dsa_rx_preprocessor() takes the source port out of the received frame
and rejects it with

	if (port > DSA_MAX_PORTS)
		return -ERANGE;

before reading ds->dp[port], but the array is declared as

	struct dsa_port *dp[DSA_MAX_PORTS];

so the last accepted value indexes one entry past its end.

Fix this off-by-one.

Fixes: d64486483505 ("net: add DSA framework to support basic switch functionality")
Assisted-by: Claude:opus-5
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 drivers/net/dsa.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/dsa.c b/drivers/net/dsa.c
index 8eb12522999f..7b2de7324e4a 100644
--- a/drivers/net/dsa.c
+++ b/drivers/net/dsa.c
@@ -311,7 +311,7 @@ static int dsa_rx_preprocessor(struct eth_device *edev, unsigned char **packet,
 	*packet += ds->needed_headroom;
 	*length -= ds->needed_rx_tailroom;
 
-	if (port > DSA_MAX_PORTS)
+	if (port >= DSA_MAX_PORTS)
 		return -ERANGE;
 
 	dp = ds->dp[port];
-- 
2.47.3

Re: [PATCH] net: dsa: don't index the port array one entry past its end

[Sascha Hauer]

On Wed, 26 Aug 2026 11:58:42 +0200, Ahmad Fatoum wrote:
> dsa_rx_preprocessor() takes the source port out of the received frame
> and rejects it with
> 
> 	if (port > DSA_MAX_PORTS)
> 		return -ERANGE;
> 
> before reading ds->dp[port], but the array is declared as
> 
> [...]

Applied, thanks!

[1/1] net: dsa: don't index the port array one entry past its end
      https://git.pengutronix.de/cgit/barebox/commit/?id=00c015c961d0 (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>