mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] ARM: Enable frame pointers for arm64
@ 2023-03-09 13:57 Sascha Hauer
  2023-03-09 14:07 ` Ahmad Fatoum
  0 siblings, 1 reply; 2+ messages in thread
From: Sascha Hauer @ 2023-03-09 13:57 UTC (permalink / raw)
  To: Barebox List; +Cc: mol

stack unwinding on arm64 depends on framepointers, so enable them.

OSELAS.Toolchain-2022.10.0 now defaults to -fomit-frame-pointer whereas
earlier versions default to -fno-omit-frame-pointer. Fix stack
unwinding for new OSELAS.Toolchain and other toolchains which omit
frame pointers by default.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 arch/arm/cpu/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/cpu/Kconfig b/arch/arm/cpu/Kconfig
index 3ef3604737..f6e2ae9b8a 100644
--- a/arch/arm/cpu/Kconfig
+++ b/arch/arm/cpu/Kconfig
@@ -18,6 +18,7 @@ config CPU_64
 	select HAVE_PBL_IMAGE
 	select HAVE_PBL_MULTI_IMAGES
 	select HAS_DMA
+	select ARCH_WANT_FRAME_POINTERS
 
 # Select CPU types depending on the architecture selected. This selects
 # which CPUs we support in the kernel image, and the compiler instruction
-- 
2.30.2




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: Enable frame pointers for arm64
  2023-03-09 13:57 [PATCH] ARM: Enable frame pointers for arm64 Sascha Hauer
@ 2023-03-09 14:07 ` Ahmad Fatoum
  0 siblings, 0 replies; 2+ messages in thread
From: Ahmad Fatoum @ 2023-03-09 14:07 UTC (permalink / raw)
  To: Sascha Hauer, Barebox List; +Cc: mol

On 09.03.23 14:57, Sascha Hauer wrote:
> stack unwinding on arm64 depends on framepointers, so enable them.
> 
> OSELAS.Toolchain-2022.10.0 now defaults to -fomit-frame-pointer whereas
> earlier versions default to -fno-omit-frame-pointer. Fix stack
> unwinding for new OSELAS.Toolchain and other toolchains which omit
> frame pointers by default.
> 
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

> ---
>  arch/arm/cpu/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/cpu/Kconfig b/arch/arm/cpu/Kconfig
> index 3ef3604737..f6e2ae9b8a 100644
> --- a/arch/arm/cpu/Kconfig
> +++ b/arch/arm/cpu/Kconfig
> @@ -18,6 +18,7 @@ config CPU_64
>  	select HAVE_PBL_IMAGE
>  	select HAVE_PBL_MULTI_IMAGES
>  	select HAS_DMA
> +	select ARCH_WANT_FRAME_POINTERS
>  
>  # Select CPU types depending on the architecture selected. This selects
>  # which CPUs we support in the kernel image, and the compiler instruction

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-03-09 14:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-09 13:57 [PATCH] ARM: Enable frame pointers for arm64 Sascha Hauer
2023-03-09 14:07 ` Ahmad Fatoum

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox