[PATCH] serial: stm: set linux_console_name

[PATCH] serial: stm: set linux_console_name

[Michael Grzeschik]

We set the linux_console_name so for this uart the
linux.bootargs.console will be properly set.

Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
---
 drivers/serial/stm-serial.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/serial/stm-serial.c b/drivers/serial/stm-serial.c
index ea482415ce..a2c3dcf56e 100644
--- a/drivers/serial/stm-serial.c
+++ b/drivers/serial/stm-serial.c
@@ -159,6 +159,7 @@ static int stm_serial_probe(struct device_d *dev)
 	cdev->flush = stm_serial_flush;
 	cdev->setbrg = stm_serial_setbaudrate;
 	cdev->dev = dev;
+	cdev->linux_console_name = "ttyAMA";
 
 	dev->priv = priv;
 	iores = dev_request_mem_resource(dev, 0);
-- 
2.26.2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] serial: stm: set linux_console_name

[Ahmad Fatoum]

Hello Michael,

On 5/29/20 2:51 PM, Michael Grzeschik wrote:
> We set the linux_console_name so for this uart the
> linux.bootargs.console will be properly set.
> 
> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
> ---
>  drivers/serial/stm-serial.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/serial/stm-serial.c b/drivers/serial/stm-serial.c
> index ea482415ce..a2c3dcf56e 100644
> --- a/drivers/serial/stm-serial.c
> +++ b/drivers/serial/stm-serial.c
> @@ -159,6 +159,7 @@ static int stm_serial_probe(struct device_d *dev)
>  	cdev->flush = stm_serial_flush;
>  	cdev->setbrg = stm_serial_setbaudrate;
>  	cdev->dev = dev;
> +	cdev->linux_console_name = "ttyAMA";

Couldn't we just combine the two drivers? On a cursory look, only
difference is how they're probed?

>  
>  	dev->priv = priv;
>  	iores = dev_request_mem_resource(dev, 0);
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] serial: stm: set linux_console_name

[Sascha Hauer]

On Fri, May 29, 2020 at 03:57:30PM +0200, Ahmad Fatoum wrote:
> Hello Michael,
> 
> On 5/29/20 2:51 PM, Michael Grzeschik wrote:
> > We set the linux_console_name so for this uart the
> > linux.bootargs.console will be properly set.
> > 
> > Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
> > ---
> >  drivers/serial/stm-serial.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/serial/stm-serial.c b/drivers/serial/stm-serial.c
> > index ea482415ce..a2c3dcf56e 100644
> > --- a/drivers/serial/stm-serial.c
> > +++ b/drivers/serial/stm-serial.c
> > @@ -159,6 +159,7 @@ static int stm_serial_probe(struct device_d *dev)
> >  	cdev->flush = stm_serial_flush;
> >  	cdev->setbrg = stm_serial_setbaudrate;
> >  	cdev->dev = dev;
> > +	cdev->linux_console_name = "ttyAMA";
> 
> Couldn't we just combine the two drivers? On a cursory look, only
> difference is how they're probed?

Yes, that sounds good. Until this is done I applied this patch.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox