[PATCH v2 1/2] ARM: i.MX: configs: add recent boards to imx_v7_defconfig

[PATCH v2 1/2] ARM: i.MX: configs: add recent boards to imx_v7_defconfig

[Johannes Zink]

We've gained some new boards in the meantime, enable them and run make
savedefconfig to regenerate the defconfig.

Signed-off-by: Johannes Zink <j.zink@pengutronix.de>
---
 arch/arm/configs/imx_v7_defconfig | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/arch/arm/configs/imx_v7_defconfig b/arch/arm/configs/imx_v7_defconfig
index 8e707b960..8ae515ae7 100644
--- a/arch/arm/configs/imx_v7_defconfig
+++ b/arch/arm/configs/imx_v7_defconfig
@@ -13,7 +13,6 @@ CONFIG_MACH_FREESCALE_MX53_VMX53=y
 CONFIG_MACH_TX53=y
 CONFIG_MACH_PHYTEC_SOM_IMX6=y
 CONFIG_MACH_PROTONIC_IMX6=y
-CONFIG_MACH_KAMSTRUP_MX7_CONCENTRATOR=y
 CONFIG_MACH_KONTRON_SAMX6I=y
 CONFIG_MACH_DFI_FS700_M60=y
 CONFIG_MACH_GUF_SANTARO=y
@@ -38,7 +37,7 @@ CONFIG_MACH_GW_VENTANA=y
 CONFIG_MACH_CM_FX6=y
 CONFIG_MACH_ADVANTECH_ROM_742X=y
 CONFIG_MACH_WARP7=y
-CONFIG_MACH_WEBASTO_CCBV2=y
+CONFIG_MACH_AC_SXB=y
 CONFIG_MACH_VF610_TWR=y
 CONFIG_MACH_ZII_RDU1=y
 CONFIG_MACH_ZII_RDU2=y
@@ -46,9 +45,12 @@ CONFIG_MACH_ZII_VF610_DEV=y
 CONFIG_MACH_ZII_IMX7D_DEV=y
 CONFIG_MACH_PHYTEC_PHYCORE_IMX7=y
 CONFIG_MACH_FREESCALE_MX7_SABRESD=y
+CONFIG_MACH_KAMSTRUP_MX7_CONCENTRATOR=y
 CONFIG_MACH_NXP_IMX6ULL_EVK=y
 CONFIG_MACH_GRINN_LITEBOARD=y
 CONFIG_MACH_DIGI_CCIMX6ULSBCPRO=y
+CONFIG_MACH_WEBASTO_CCBV2=y
+CONFIG_MACH_SKOV_IMX6=y
 CONFIG_IMX_IIM_FUSE_BLOW=y
 CONFIG_THUMB2_BAREBOX=y
 CONFIG_ARM_OPTIMZED_STRING_FUNCTIONS=y
@@ -87,6 +89,7 @@ CONFIG_CMD_MMC_EXTCSD=y
 CONFIG_CMD_GO=y
 CONFIG_CMD_RESET=y
 CONFIG_CMD_UIMAGE=y
+CONFIG_CMD_BOOTCHOOSER=y
 CONFIG_CMD_PARTITION=y
 CONFIG_CMD_UBIFORMAT=y
 CONFIG_CMD_EXPORT=y
@@ -139,7 +142,6 @@ CONFIG_CMD_OF_OVERLAY=y
 CONFIG_CMD_OFTREE=y
 CONFIG_CMD_TIME=y
 CONFIG_CMD_STATE=y
-CONFIG_CMD_BOOTCHOOSER=y
 CONFIG_NET=y
 CONFIG_NET_NETCONSOLE=y
 CONFIG_OF_BAREBOX_DRIVERS=y
@@ -198,9 +200,9 @@ CONFIG_WATCHDOG=y
 CONFIG_WATCHDOG_IMX=y
 CONFIG_PWM=y
 CONFIG_PWM_IMX=y
-CONFIG_IMX_OCOTP_WRITE=y
 CONFIG_MXS_APBH_DMA=y
 CONFIG_GPIO_STMPE=y
+CONFIG_IMX_OCOTP_WRITE=y
 CONFIG_REGULATOR=y
 CONFIG_REGULATOR_FIXED=y
 CONFIG_GENERIC_PHY=y
-- 
2.30.2

[PATCH v2 2/2] ARM: i.MX7: add 96Boards Meerkat96 support

[Johannes Zink]

This is a i.MX7D-based board with an upstream device tree.
Add the necessary boilerplate to have barebox create an image.

The memory settings are taken from U-Boot v2022.07-rc6.

System reset requires pmic driver which is not available yet in barebox.

Signed-off-by: Johannes Zink <j.zink@pengutronix.de>
---
v1 -> v2:
 - added meerkat96 board to imx_v7_defconfig
 - added Documentation for meerkat96 board
---
 Documentation/boards/imx/meerkat96.rst        |  31 ++++++
 arch/arm/boards/Makefile                      |   1 +
 arch/arm/boards/meerkat96/Makefile            |   4 +
 arch/arm/boards/meerkat96/board.c             |  10 ++
 .../flash-header-mx7-meerkat96.imxcfg         | 105 ++++++++++++++++++
 arch/arm/boards/meerkat96/lowlevel.c          |  34 ++++++
 arch/arm/configs/imx_v7_defconfig             |   1 +
 arch/arm/dts/Makefile                         |   1 +
 arch/arm/dts/imx7d-meerkat96.dts              |  42 +++++++
 arch/arm/mach-imx/Kconfig                     |   5 +
 images/Makefile.imx                           |   5 +
 11 files changed, 239 insertions(+)
 create mode 100644 Documentation/boards/imx/meerkat96.rst
 create mode 100644 arch/arm/boards/meerkat96/Makefile
 create mode 100644 arch/arm/boards/meerkat96/board.c
 create mode 100644 arch/arm/boards/meerkat96/flash-header-mx7-meerkat96.imxcfg
 create mode 100644 arch/arm/boards/meerkat96/lowlevel.c
 create mode 100644 arch/arm/dts/imx7d-meerkat96.dts

diff --git a/Documentation/boards/imx/meerkat96.rst b/Documentation/boards/imx/meerkat96.rst
new file mode 100644
index 000000000..3cdb1beaf
--- /dev/null
+++ b/Documentation/boards/imx/meerkat96.rst
@@ -0,0 +1,31 @@
+Meerkat 96
+==========
+
+The Meerkat96 is a single board computer based on an i.MX7D SoC by NXP, featuring a dual core ARM Cortex-A7 at 1 GHz and a Cortex-M4 at 266MHz and 512 MB DRAM. For further details on the board's features check the manufacturers page at https://www.96boards.org/product/imx7-96
+
+Serial console
+--------------
+
+UART6 of the i.MX7D is broken out to Pinheader J3, on the Silkscreen the Pins are labeled with B (Ground), W (UART 6 TX) and G (UART 6 RX). If you use the UART-To-Serial-Converter provided with the board, you can just connect the Black jumper to B, the White to W and the Green to G. The UART uses 3.3V levels. 
+
+Building Barebox                                                        
+----------------                                                        
+                                                                        
+To build Barebox for ZII i.MX7 based boards do the following:           
+                                                                        
+.. code-block:: sh                                                      
+           
+  make ARCH=arm CROSS_COMPILE=<ARM toolchain prefix> mrproper   
+  make ARCH=arm CROSS_COMPILE=<ARM toolchain prefix> imx_v7_defconfig
+  make ARCH=arm CROSS_COMPILE=<ARM toolchain prefix>
+
+Bringup
+-------
+
+flash the resulting barebox-meerkat96.img to an sdcard at address 0. Make sure the pmic is set to power-on state by setting the dipswitch SW3 on the boards bottom side to 1-1 (i.e. all switches on, which is the factory default).
+
+Schematics
+----------
+
+Schematics are available at https://github.com/96boards/documentation/blob/master/consumer/imx7-96/hardware-docs/files/iMX7-96-schematics.pdf
+
diff --git a/arch/arm/boards/Makefile b/arch/arm/boards/Makefile
index 3ccde26f1..96f81a32d 100644
--- a/arch/arm/boards/Makefile
+++ b/arch/arm/boards/Makefile
@@ -52,6 +52,7 @@ obj-$(CONFIG_MACH_FREESCALE_MX53_LOCO)		+= freescale-mx53-qsb/
 obj-$(CONFIG_MACH_FREESCALE_MX53_SMD)		+= freescale-mx53-smd/
 obj-$(CONFIG_MACH_FREESCALE_MX53_VMX53)		+= freescale-mx53-vmx53/
 obj-$(CONFIG_MACH_FREESCALE_MX7_SABRESD)	+= freescale-mx7-sabresd/
+obj-$(CONFIG_MACH_MEERKAT96)			+= meerkat96/
 obj-$(CONFIG_MACH_GE863)			+= telit-evk-pro3/
 obj-$(CONFIG_MACH_GK802)			+= gk802/
 obj-$(CONFIG_MACH_GLOBALSCALE_GURUPLUG)		+= globalscale-guruplug/
diff --git a/arch/arm/boards/meerkat96/Makefile b/arch/arm/boards/meerkat96/Makefile
new file mode 100644
index 000000000..567871818
--- /dev/null
+++ b/arch/arm/boards/meerkat96/Makefile
@@ -0,0 +1,4 @@
+# SPDX-License-Identifier: GPL-2.0-only
+
+lwl-y += lowlevel.o
+obj-y += board.o
diff --git a/arch/arm/boards/meerkat96/board.c b/arch/arm/boards/meerkat96/board.c
new file mode 100644
index 000000000..49e9c06f7
--- /dev/null
+++ b/arch/arm/boards/meerkat96/board.c
@@ -0,0 +1,10 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+
+#include <of.h>
+#include <deep-probe.h>
+
+static const struct of_device_id meerkat96_match[] = {
+	{ .compatible = "novtech,imx7d-meerkat96" },
+	{ /* Sentinel */ },
+};
+BAREBOX_DEEP_PROBE_ENABLE(meerkat96_match);
diff --git a/arch/arm/boards/meerkat96/flash-header-mx7-meerkat96.imxcfg b/arch/arm/boards/meerkat96/flash-header-mx7-meerkat96.imxcfg
new file mode 100644
index 000000000..a49b81617
--- /dev/null
+++ b/arch/arm/boards/meerkat96/flash-header-mx7-meerkat96.imxcfg
@@ -0,0 +1,105 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright (C) 2014 Freescale Semiconductor, Inc.
+ */
+
+soc imx7
+loadaddr 0x80000000
+ivtofs 0x400
+
+/*
+ * Device Configuration Data (DCD)
+ *
+ * Each entry must have the format:
+ * Addr-type           Address        Value
+ *
+ * where:
+ *	Addr-type register length (1,2 or 4 bytes)
+ *	Address	  absolute address of the register
+ *	value	  value to be stored in the register
+ */
+
+/* Enable OCRAM EPDC */
+wm 32 0x30340004 0x4F400005
+
+/* =============================================================================
+ * DDR Controller Registers
+ * =============================================================================
+ * Memory type:           DDR3
+ * Manufacturer:          ISSI
+ * Device Part Number:    IS43TR16256AL-125KBL
+ * Clock Freq.:           533MHz
+ * Density per CS in Gb:  4
+ * Chip Selects used:     1
+ * Number of Banks:       8
+ * Row address:          15
+ * Column address:       10
+ * Data bus width:       16
+ * ROW-BANK interleave:  ENABLED
+ * =============================================================================
+ */
+
+wm 32 0x30391000 0x00000002    // deassert presetn
+wm 32 0x307A0000 0x01041001    // DDRC_MSTR
+wm 32 0x307A0064 0x00400046    // DDRC_RFSHTMG
+wm 32 0x307a0490 0x00000001    // DDRC_PCTRL_0
+wm 32 0x307A00D4 0x00690000    // DDRC_INIT1
+wm 32 0x307A00D0 0x00020083    // DDRC_INIT0
+wm 32 0x307A00DC 0x09300004    // DDRC_INIT3
+wm 32 0x307A00E0 0x04080000    // DDRC_INIT4
+wm 32 0x307A00E4 0x00100004    // DDRC_INIT5
+wm 32 0x307A00F4 0x0000033F    // DDRC_RANKCTL
+wm 32 0x307A0100 0x090B1109    // DDRC_DRAMTMG0
+wm 32 0x307A0104 0x0007020D    // DDRC_DRAMTMG1
+wm 32 0x307A0108 0x03040407    // DDRC_DRAMTMG2
+wm 32 0x307A010C 0x00002006    // DDRC_DRAMTMG3
+wm 32 0x307A0110 0x04020205    // DDRC_DRAMTMG4
+wm 32 0x307A0114 0x03030202    // DDRC_DRAMTMG5
+wm 32 0x307A0120 0x00000803    // DDRC_DRAMTMG8
+wm 32 0x307A0180 0x00800020    // DDRC_ZQCTL0
+wm 32 0x307A0190 0x02098204    // DDRC_DFITMG0
+wm 32 0x307A0194 0x00030303    // DDRC_DFITMG1
+wm 32 0x307A01A0 0x80400003    // DDRC_DFIUPD0
+wm 32 0x307A01A4 0x00100020    // DDRC_DFIUPD1
+wm 32 0x307A01A8 0x80100004    // DDRC_DFIUPD2
+wm 32 0x307A0200 0x00000015    // DDRC_ADDRMAP0
+wm 32 0x307A0204 0x00070707    // DDRC_ADDRMAP1
+wm 32 0x307A0210 0x00000F0F    // DDRC_ADDRMAP4
+wm 32 0x307A0214 0x06060606    // DDRC_ADDRMAP5
+wm 32 0x307A0218 0x0F060606    // DDRC_ADDRMAP6
+wm 32 0x307A0240 0x06000604    // DDRC_ODTCFG
+wm 32 0x307A0244 0x00000001    // DDRC_ODTMAP
+
+
+/* =============================================================================
+ * PHY Control Register
+ * =============================================================================
+ */
+
+wm 32 0x30391000 0x00000000    // deassert presetn
+wm 32 0x30790000 0x17420F40    // DDR_PHY_PHY_CON0
+wm 32 0x30790004 0x10210100    // DDR_PHY_PHY_CON1
+wm 32 0x30790010 0x00060807    // DDR_PHY_PHY_CON4
+wm 32 0x307900B0 0x1010007E    // DDR_PHY_MDLL_CON0
+wm 32 0x3079009C 0x00000D6E    // DDR_PHY_DRVDS_CON0
+wm 32 0x30790030 0x08080808    // DDR_PHY_OFFSET_WR_CON0
+wm 32 0x30790020 0x08080808    // DDR_PHY_OFFSET_RD_CON0
+wm 32 0x30790050 0x01000010    // DDR_PHY_OFFSETD_CON0
+wm 32 0x30790050 0x00000010    // DDR_PHY_OFFSETD_CON0
+wm 32 0x30790018 0x0000000F    // DDR_PHY_LP_CON0
+wm 32 0x307900C0 0x0E407304    // DDR_PHY_ZQ_CON0 - Start Manual ZQ
+wm 32 0x307900C0 0x0E447304
+wm 32 0x307900C0 0x0E447306
+wm 32 0x307900C0 0x0E447304    // <= NOTE: Depending on JTAG device used, may need ~ 7 us pause at this point.
+wm 32 0x307900C0 0x0E407304    // DDR_PHY_ZQ_CON0 - End Manual ZQ
+
+
+/* =============================================================================
+ * Final Initialization start sequence
+ * =============================================================================
+ */
+
+wm 32 0x30384130 0x00000000    // Disable Clock
+wm 32 0x30340020 0x00000178    // IOMUX_GRP_GRP8 - Start input to PHY
+wm 32 0x30384130 0x00000002    // Enable Clock
+/* <= NOTE: Depending on JTAG device used, may need ~ 250 us pause at this point. */
diff --git a/arch/arm/boards/meerkat96/lowlevel.c b/arch/arm/boards/meerkat96/lowlevel.c
new file mode 100644
index 000000000..1c9baeacf
--- /dev/null
+++ b/arch/arm/boards/meerkat96/lowlevel.c
@@ -0,0 +1,34 @@
+// SPDX-License-Identifier: GPL-2.0-only
+
+#include <debug_ll.h>
+#include <io.h>
+#include <linux/sizes.h>
+#include <mach/debug_ll.h>
+#include <mach/iomux-mx7.h>
+#include <mach/imx7-ccm-regs.h>
+#include <mach/generic.h>
+#include <asm/barebox-arm-head.h>
+#include <asm/barebox-arm.h>
+#include <asm/cache.h>
+extern char __dtb_z_imx7d_meerkat96_start[];
+
+static void setup_uart(void)
+{
+	imx7_early_setup_uart_clock();
+	imx7_setup_pad(MX7D_PAD_SD1_WP__UART6_DCE_TX);
+	imx7_uart_setup_ll();
+	putc_ll('>');
+}
+
+ENTRY_FUNCTION_WITHSTACK(start_imx7d_meerkat96, 0, r0, r1, r2)
+{
+	void *fdt;
+
+	imx7_cpu_lowlevel_init();
+
+	setup_uart();
+
+	fdt = __dtb_z_imx7d_meerkat96_start + get_runtime_offset();
+
+	barebox_arm_entry(0x80000000, SZ_512M, fdt);
+}
diff --git a/arch/arm/configs/imx_v7_defconfig b/arch/arm/configs/imx_v7_defconfig
index 8ae515ae7..df2304eae 100644
--- a/arch/arm/configs/imx_v7_defconfig
+++ b/arch/arm/configs/imx_v7_defconfig
@@ -38,6 +38,7 @@ CONFIG_MACH_CM_FX6=y
 CONFIG_MACH_ADVANTECH_ROM_742X=y
 CONFIG_MACH_WARP7=y
 CONFIG_MACH_AC_SXB=y
+CONFIG_MACH_MEERKAT96=y
 CONFIG_MACH_VF610_TWR=y
 CONFIG_MACH_ZII_RDU1=y
 CONFIG_MACH_ZII_RDU2=y
diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
index 0c7e43e22..8cd994cf0 100644
--- a/arch/arm/dts/Makefile
+++ b/arch/arm/dts/Makefile
@@ -26,6 +26,7 @@ lwl-$(CONFIG_MACH_CCMX53) += imx53-ccxmx53.dtb.o
 lwl-$(CONFIG_MACH_DIGI_CCIMX6ULSBCPRO) += imx6ul-ccimx6ulsbcpro.dtb.o
 lwl-$(CONFIG_MACH_FREESCALE_MX53_VMX53) += imx53-voipac-bsb.dtb.o
 lwl-$(CONFIG_MACH_FREESCALE_MX7_SABRESD) += imx7d-sdb.dtb.o
+lwl-$(CONFIG_MACH_MEERKAT96) += imx7d-meerkat96.dtb.o
 lwl-$(CONFIG_MACH_GK802) += imx6q-gk802.dtb.o
 lwl-$(CONFIG_MACH_GLOBALSCALE_GURUPLUG) += kirkwood-guruplug-server-plus-bb.dtb.o
 lwl-$(CONFIG_MACH_GLOBALSCALE_MIRABOX) += armada-370-mirabox-bb.dtb.o
diff --git a/arch/arm/dts/imx7d-meerkat96.dts b/arch/arm/dts/imx7d-meerkat96.dts
new file mode 100644
index 000000000..f9d18f355
--- /dev/null
+++ b/arch/arm/dts/imx7d-meerkat96.dts
@@ -0,0 +1,42 @@
+// SPDX-License-Identifier: GPL-2.0+ OR MIT
+#include <arm/imx7d-meerkat96.dts>
+
+/ {
+	chosen {
+		environment {
+			compatible = "barebox,environment";
+			device-path = &bareboxenv;
+		};
+	};
+};
+
+&usdhc1 {
+	#address-cells = <1>;
+	#size-cells = <1>;
+
+	barebox@0 {
+		label = "barebox";
+		reg = <0x0 0x180000>;
+	};
+
+	bareboxenv: bareboxenv@180000 {
+		label = "bareboxenv";
+		reg = <0x180000 0x80000>;
+	};
+};
+
+/* FIXME: barebox serial is broken when barebox applies requested reparenting */
+&uart1 {
+	/delete-property/ assigned-clocks;
+	/delete-property/ assigned-clock-parents;
+};
+
+&uart3  {
+	/delete-property/ assigned-clocks;
+	/delete-property/ assigned-clock-parents;
+};
+
+&uart6 {
+	/delete-property/ assigned-clocks;
+	/delete-property/ assigned-clock-parents;
+};
diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
index 9ff549ac8..c10b09a12 100644
--- a/arch/arm/mach-imx/Kconfig
+++ b/arch/arm/mach-imx/Kconfig
@@ -485,6 +485,11 @@ config MACH_AC_SXB
 	select MCI_IMX_ESDHC_PBL
 	select ARM_USE_COMPRESSED_DTB
 
+config MACH_MEERKAT96
+	bool "96Boards: i.MX7 Meerkat96"
+	select ARCH_IMX7
+	select ARM_USE_COMPRESSED_DTB
+
 config MACH_VF610_TWR
 	bool "Freescale VF610 Tower Board"
 	select ARCH_VF610
diff --git a/images/Makefile.imx b/images/Makefile.imx
index 62549ab75..a19e0ff1c 100644
--- a/images/Makefile.imx
+++ b/images/Makefile.imx
@@ -418,6 +418,11 @@ CFG_start_zii_imx7d_dev.pblb.imximg = $(board)/zii-imx7d-dev/flash-header-zii-im
 FILE_barebox-zii-imx7d-dev.img = start_zii_imx7d_dev.pblb.imximg
 image-$(CONFIG_MACH_ZII_IMX7D_DEV) += barebox-zii-imx7d-dev.img
 
+pblb-$(CONFIG_MACH_MEERKAT96) += start_imx7d_meerkat96
+CFG_start_imx7d_meerkat96.pblb.imximg = $(board)/meerkat96/flash-header-mx7-meerkat96.imxcfg
+FILE_barebox-meerkat96.img = start_imx7d_meerkat96.pblb.imximg
+image-$(CONFIG_MACH_MEERKAT96) += barebox-meerkat96.img
+
 pblb-$(CONFIG_MACH_KAMSTRUP_MX7_CONCENTRATOR) += start_kamstrup_mx7_concentrator
 CFG_start_kamstrup_mx7_concentrator.pblb.imximg = $(board)/kamstrup-mx7-concentrator/flash-header-tqma7d.imxcfg
 FILE_barebox-kamstrup-mx7-concentrator.img = start_kamstrup_mx7_concentrator.pblb.imximg
-- 
2.30.2

Re: [PATCH v2 2/2] ARM: i.MX7: add 96Boards Meerkat96 support

[Ahmad Fatoum]

On 11.07.22 16:12, Johannes Zink wrote:
> This is a i.MX7D-based board with an upstream device tree.
> Add the necessary boilerplate to have barebox create an image.
> 
> The memory settings are taken from U-Boot v2022.07-rc6.
> 
> System reset requires pmic driver which is not available yet in barebox.
> 
> Signed-off-by: Johannes Zink <j.zink@pengutronix.de>
> ---
> v1 -> v2:
>  - added meerkat96 board to imx_v7_defconfig
>  - added Documentation for meerkat96 board
> ---
>  Documentation/boards/imx/meerkat96.rst        |  31 ++++++
>  arch/arm/boards/Makefile                      |   1 +
>  arch/arm/boards/meerkat96/Makefile            |   4 +
>  arch/arm/boards/meerkat96/board.c             |  10 ++
>  .../flash-header-mx7-meerkat96.imxcfg         | 105 ++++++++++++++++++
>  arch/arm/boards/meerkat96/lowlevel.c          |  34 ++++++
>  arch/arm/configs/imx_v7_defconfig             |   1 +
>  arch/arm/dts/Makefile                         |   1 +
>  arch/arm/dts/imx7d-meerkat96.dts              |  42 +++++++
>  arch/arm/mach-imx/Kconfig                     |   5 +
>  images/Makefile.imx                           |   5 +
>  11 files changed, 239 insertions(+)
>  create mode 100644 Documentation/boards/imx/meerkat96.rst
>  create mode 100644 arch/arm/boards/meerkat96/Makefile
>  create mode 100644 arch/arm/boards/meerkat96/board.c
>  create mode 100644 arch/arm/boards/meerkat96/flash-header-mx7-meerkat96.imxcfg
>  create mode 100644 arch/arm/boards/meerkat96/lowlevel.c
>  create mode 100644 arch/arm/dts/imx7d-meerkat96.dts
> 
> diff --git a/Documentation/boards/imx/meerkat96.rst b/Documentation/boards/imx/meerkat96.rst
> new file mode 100644
> index 000000000..3cdb1beaf
> --- /dev/null
> +++ b/Documentation/boards/imx/meerkat96.rst
> @@ -0,0 +1,31 @@
> +Meerkat 96
> +==========
> +
> +The Meerkat96 is a single board computer based on an i.MX7D SoC by NXP, featuring a dual core ARM Cortex-A7 at 1 GHz and a Cortex-M4 at 266MHz and 512 MB DRAM. For further details on the board's features check the manufacturers page at https://www.96boards.org/product/imx7-96
> +
> +Serial console
> +--------------
> +
> +UART6 of the i.MX7D is broken out to Pinheader J3, on the Silkscreen the Pins are labeled with B (Ground), W (UART 6 TX) and G (UART 6 RX). If you use the UART-To-Serial-Converter provided with the board, you can just connect the Black jumper to B, the White to W and the Green to G. The UART uses 3.3V levels. 

Quite a long line. Could you break it?

> +
> +Building Barebox                                                        
> +----------------                                                        
> +                                                                        
> +To build Barebox for ZII i.MX7 based boards do the following:   

That's not a ZII.
        
> +                                                                        
> +.. code-block:: sh                                                      
> +           

Much trailing whitespace. Block copy? :^)

Sascha accepts fixup commits, so you can create a fixup locally
and

  git send-email -1 --in-reply-to="<20220711141246.3331160-2-j.zink@pengutronix.de>"

to have it appear correctly threaded.

Cheers,
Ahmad


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

[PATCH] fixup! ARM: i.MX7: add 96Boards Meerkat96 support

[Johannes Zink]

This is a fixup for the documentation: fixed line breaks, whitespace changes 
and typos as requested.

Signed-off-by: Johannes Zink <j.zink@pengutronix.de>
---
 Documentation/boards/imx/meerkat96.rst | 28 ++++++++++++++++++--------
 1 file changed, 20 insertions(+), 8 deletions(-)

diff --git a/Documentation/boards/imx/meerkat96.rst b/Documentation/boards/imx/meerkat96.rst
index 3cdb1beaf..3a51b9144 100644
--- a/Documentation/boards/imx/meerkat96.rst
+++ b/Documentation/boards/imx/meerkat96.rst
@@ -1,28 +1,40 @@
 Meerkat 96
 ==========
 
-The Meerkat96 is a single board computer based on an i.MX7D SoC by NXP, featuring a dual core ARM Cortex-A7 at 1 GHz and a Cortex-M4 at 266MHz and 512 MB DRAM. For further details on the board's features check the manufacturers page at https://www.96boards.org/product/imx7-96
+The Meerkat96 is a single board computer based on an i.MX7D SoC by NXP, 
+featuring a dual core ARM Cortex-A7 at 1 GHz and a Cortex-M4 at 266MHz 
+and 512 MB DRAM. For further details on the board's features check the 
+manufacturers page at https://www.96boards.org/product/imx7-96
 
 Serial console
 --------------
 
-UART6 of the i.MX7D is broken out to Pinheader J3, on the Silkscreen the Pins are labeled with B (Ground), W (UART 6 TX) and G (UART 6 RX). If you use the UART-To-Serial-Converter provided with the board, you can just connect the Black jumper to B, the White to W and the Green to G. The UART uses 3.3V levels. 
+UART6 of the i.MX7D is broken out to Pinheader J3, on the Silkscreen 
+the Pins are labeled with B (Ground), W (UART 6 TX) and G (UART 6 RX). 
+If you use the UART-To-USB-Converter provided with the board, you can 
+just connect the Black jumper to B, the White to W and the Green to G. 
+
+The UART uses 3.3V levels. 
 
 Building Barebox                                                        
 ----------------                                                        
                                                                         
-To build Barebox for ZII i.MX7 based boards do the following:           
-                                                                        
-.. code-block:: sh                                                      
-           
-  make ARCH=arm CROSS_COMPILE=<ARM toolchain prefix> mrproper   
+To build Barebox for the meerkat96 board do the following:
+
+.. code-block:: sh
+
+  make ARCH=arm CROSS_COMPILE=<ARM toolchain prefix> mrproper
   make ARCH=arm CROSS_COMPILE=<ARM toolchain prefix> imx_v7_defconfig
   make ARCH=arm CROSS_COMPILE=<ARM toolchain prefix>
 
 Bringup
 -------
 
-flash the resulting barebox-meerkat96.img to an sdcard at address 0. Make sure the pmic is set to power-on state by setting the dipswitch SW3 on the boards bottom side to 1-1 (i.e. all switches on, which is the factory default).
+flash the resulting barebox-meerkat96.img to an sdcard at address 0. 
+
+Make sure the pmic is set to power-on state by setting the dipswitch 
+SW3 on the boards bottom side to 1-1 (i.e. all switches on, which is 
+the factory default).
 
 Schematics
 ----------
-- 
2.30.2

Re: [PATCH] fixup! ARM: i.MX7: add 96Boards Meerkat96 support

[Sascha Hauer]

Hi Johannes,

On Tue, Jul 12, 2022 at 07:04:49AM +0200, Johannes Zink wrote:
> This is a fixup for the documentation: fixed line breaks, whitespace changes 
> and typos as requested.
> 
> Signed-off-by: Johannes Zink <j.zink@pengutronix.de>
> ---
>  Documentation/boards/imx/meerkat96.rst | 28 ++++++++++++++++++--------
>  1 file changed, 20 insertions(+), 8 deletions(-)

Still many trailing whitespaces with this fixup. I fixed it up locally
and applied, thanks

Sascha

> 
> diff --git a/Documentation/boards/imx/meerkat96.rst b/Documentation/boards/imx/meerkat96.rst
> index 3cdb1beaf..3a51b9144 100644
> --- a/Documentation/boards/imx/meerkat96.rst
> +++ b/Documentation/boards/imx/meerkat96.rst
> @@ -1,28 +1,40 @@
>  Meerkat 96
>  ==========
>  
> -The Meerkat96 is a single board computer based on an i.MX7D SoC by NXP, featuring a dual core ARM Cortex-A7 at 1 GHz and a Cortex-M4 at 266MHz and 512 MB DRAM. For further details on the board's features check the manufacturers page at https://www.96boards.org/product/imx7-96
> +The Meerkat96 is a single board computer based on an i.MX7D SoC by NXP, 
> +featuring a dual core ARM Cortex-A7 at 1 GHz and a Cortex-M4 at 266MHz 
> +and 512 MB DRAM. For further details on the board's features check the 
> +manufacturers page at https://www.96boards.org/product/imx7-96
>  
>  Serial console
>  --------------
>  
> -UART6 of the i.MX7D is broken out to Pinheader J3, on the Silkscreen the Pins are labeled with B (Ground), W (UART 6 TX) and G (UART 6 RX). If you use the UART-To-Serial-Converter provided with the board, you can just connect the Black jumper to B, the White to W and the Green to G. The UART uses 3.3V levels. 
> +UART6 of the i.MX7D is broken out to Pinheader J3, on the Silkscreen 
> +the Pins are labeled with B (Ground), W (UART 6 TX) and G (UART 6 RX). 
> +If you use the UART-To-USB-Converter provided with the board, you can 
> +just connect the Black jumper to B, the White to W and the Green to G. 
> +
> +The UART uses 3.3V levels. 
>  
>  Building Barebox                                                        
>  ----------------                                                        
>                                                                          
> -To build Barebox for ZII i.MX7 based boards do the following:           
> -                                                                        
> -.. code-block:: sh                                                      
> -           
> -  make ARCH=arm CROSS_COMPILE=<ARM toolchain prefix> mrproper   
> +To build Barebox for the meerkat96 board do the following:
> +
> +.. code-block:: sh
> +
> +  make ARCH=arm CROSS_COMPILE=<ARM toolchain prefix> mrproper
>    make ARCH=arm CROSS_COMPILE=<ARM toolchain prefix> imx_v7_defconfig
>    make ARCH=arm CROSS_COMPILE=<ARM toolchain prefix>
>  
>  Bringup
>  -------
>  
> -flash the resulting barebox-meerkat96.img to an sdcard at address 0. Make sure the pmic is set to power-on state by setting the dipswitch SW3 on the boards bottom side to 1-1 (i.e. all switches on, which is the factory default).
> +flash the resulting barebox-meerkat96.img to an sdcard at address 0. 
> +
> +Make sure the pmic is set to power-on state by setting the dipswitch 
> +SW3 on the boards bottom side to 1-1 (i.e. all switches on, which is 
> +the factory default).
>  
>  Schematics
>  ----------
> -- 
> 2.30.2
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |