Re: [PATCH] common: deep-probe: write deep probe enabled message to log

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

Hello Ulrich,

On 22.12.22 18:04, Ulrich Ölmann wrote:
> Hi Ahmad,
> 
> On Thu, Dec 22 2022 at 15:35 +0100, Ahmad Fatoum <a.fatoum@pengutronix.de> wrote:
>> The "Deep probe supported due to" was not written to log and thus only
>> shown on startup and not in dmesg output. Make it available in both.
>>
>> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
>> ---
>>  common/deep-probe.c | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/common/deep-probe.c b/common/deep-probe.c
>> index 1020ad93b7f7..931e5a17709d 100644
>> --- a/common/deep-probe.c
>> +++ b/common/deep-probe.c
>> @@ -1,5 +1,7 @@
>>  // SPDX-License-Identifier: GPL-2.0-only
>>  
>> +#define pr_fmt(fmt) "deep-probe: " fmt
>> +
>>  #include <common.h>
>>  #include <deep-probe.h>
>>  #include <of.h>
>> @@ -27,7 +29,7 @@ bool deep_probe_is_supported(void)
>>  		for (; matches->compatible; matches++) {
>>  			if (of_machine_is_compatible(matches->compatible)) {
>>  				boardstate = DEEP_PROBE_SUPPORTED;
>> -				printk("Deep probe supported due to %s\n", matches->compatible);
>> +				pr_info("supported due to %s\n", matches->compatible);
> 
> was it by accident that you removed the message's beginning "Deep probe "?

The pr_ family of macros run the format string through pr_fmt before passing
it along. pr_fmt is defined above to prepend "deep-probe: ". This is a convention
to maintain a uniform prefix for debug prints of a file.

As we now have the prefix, I dropped that part here to avoid the duplication.

Cheers,
Ahmad

> 
> Best regards
> Ulrich
> 
> 
>>  				return true;
>>  			}
>>  		}

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |