Re: [PATCH] common: deep-probe: write deep probe enabled message to log

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

Hello Macro,

On 22.12.22 16:47, Marco Felsch wrote:
> Hi Ahamd,
> 
> thanks for your patch.
> 
> On 22-12-22, Ahmad Fatoum wrote:
>> The "Deep probe supported due to" was not written to log and thus only
>> shown on startup and not in dmesg output. Make it available in both.
>>
>> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
>> ---
>>  common/deep-probe.c | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/common/deep-probe.c b/common/deep-probe.c
>> index 1020ad93b7f7..931e5a17709d 100644
>> --- a/common/deep-probe.c
>> +++ b/common/deep-probe.c
>> @@ -1,5 +1,7 @@
>>  // SPDX-License-Identifier: GPL-2.0-only
>>  
>> +#define pr_fmt(fmt) "deep-probe: " fmt
>> +
>>  #include <common.h>
>>  #include <deep-probe.h>
>>  #include <of.h>
>> @@ -27,7 +29,7 @@ bool deep_probe_is_supported(void)
>>  		for (; matches->compatible; matches++) {
>>  			if (of_machine_is_compatible(matches->compatible)) {
>>  				boardstate = DEEP_PROBE_SUPPORTED;
>> -				printk("Deep probe supported due to %s\n", matches->compatible);
>> +				pr_info("supported due to %s\n", matches->compatible);
> 
> What do you think, should we move it to pr_debug()? The feature is now
> more robust and usual this information is only required for developers
> not for users.

I just fixed a deep probe regression in the other series, so I think
we should still leave it in.

> 
> Regards,
>   Marco
> 
>>  				return true;
>>  			}
>>  		}
>> -- 
>> 2.30.2
>>
>>
>>
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |