From: Ahmad Fatoum <a.fatoum@pengutronix.de> To: "Jan Lübbe" <jlu@pengutronix.de>, "Rouven Czerwinski" <r.czerwinski@pengutronix.de>, barebox@lists.infradead.org Subject: Re: [PATCH v2 10/13] test: add first sample tests Date: Thu, 3 Jun 2021 17:31:58 +0200 Message-ID: <61355db5-627e-0f60-050c-c98833a5c1e0@pengutronix.de> (raw) In-Reply-To: <b2efa5118953e06f34d236e6c9319f89bc1bd85b.camel@pengutronix.de> Hello Jan, On 03.06.21 17:14, Jan Lübbe wrote: > On Wed, 2021-06-02 at 13:35 +0200, Ahmad Fatoum wrote: >>>> +def get_config(command): >>>> + """Returns the enabled config options of barebox, either from >>>> + a running instance if supported or by looking into .config >>>> + in the build directory. >>>> + Args: >>>> + command (BareboxDriver): An instance of the BareboxDriver >>>> + Returns: >>>> + list: list of the enabled config options >>>> + """ >>>> + assert isinstance(command, BareboxDriver) >>>> + >>>> + out, err, returncode = command.run("cat /env/data/config") >>>> + if returncode != 0: >>>> + try: >>>> + with open(os.environ['LG_BUILDDIR'] + "/.config") as f: >>> >>> Please don't use the LG_ namespace currently used by labgrid, this >>> variable is introduced by your wrapper script, something like >>> BB_LG_BUILDDIR indicates that this is only used in the barebox test >>> scripts. >> >> Labgrid filters out anything that doesn't start with LG_ AFAIK. > > No. The filter is only for the environment templating. We don't touch the > os.environ dictionary. I am using LG_BUILDDIR out of the YAML config as well. > > Regards, > Jan > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2021-06-03 15:33 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-31 6:55 [PATCH v2 00/13] add barebox in-tree testing infrastructure Ahmad Fatoum 2021-05-31 6:55 ` [PATCH v2 01/13] kbuild: add install target Ahmad Fatoum 2021-05-31 6:55 ` [PATCH v2 02/13] kbuild: add ARCH={i386, x86_64} as aliases for x86 Ahmad Fatoum 2021-05-31 6:55 ` [PATCH v2 03/13] kbuild: add ARCH=um alias for sandbox Ahmad Fatoum 2021-05-31 6:55 ` [PATCH v2 04/13] MIPS: qemu-malta: generate swapped image as part of multi-image build Ahmad Fatoum 2021-05-31 6:55 ` [PATCH v2 05/13] openrisc: set default KBUILD_IMAGE Ahmad Fatoum 2021-05-31 6:55 ` [PATCH v2 06/13] Documentation: boards: RISC-V: update TinyEMU support Ahmad Fatoum 2021-05-31 6:55 ` [PATCH v2 07/13] test: add basic barebox self-test infrastructure Ahmad Fatoum 2021-05-31 6:55 ` [PATCH v2 08/13] test: self: port Linux printf kselftest Ahmad Fatoum 2021-05-31 6:55 ` [PATCH v2 09/13] test: add labgrid configs for some emulated targets Ahmad Fatoum 2021-06-02 11:27 ` Rouven Czerwinski 2021-06-02 11:34 ` Ahmad Fatoum 2021-05-31 6:55 ` [PATCH v2 10/13] test: add first sample tests Ahmad Fatoum 2021-06-02 11:33 ` Rouven Czerwinski 2021-06-02 11:35 ` Ahmad Fatoum 2021-06-03 15:14 ` Jan Lübbe 2021-06-03 15:31 ` Ahmad Fatoum [this message] 2021-05-31 6:55 ` [PATCH v2 11/13] test: add emulate.pl, a runner for barebox on emulated targets Ahmad Fatoum 2021-05-31 6:55 ` [PATCH v2 12/13] test: self: run selftests as part of the pytest suite Ahmad Fatoum 2021-06-02 11:36 ` Rouven Czerwinski 2021-05-31 6:55 ` [PATCH v2 13/13] test: add bthread test Ahmad Fatoum
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=61355db5-627e-0f60-050c-c98833a5c1e0@pengutronix.de \ --to=a.fatoum@pengutronix.de \ --cc=barebox@lists.infradead.org \ --cc=jlu@pengutronix.de \ --cc=r.czerwinski@pengutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
mail archive of the barebox mailing list This inbox may be cloned and mirrored by anyone: git clone --mirror https://lore.barebox.org/barebox/0 barebox/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 barebox barebox/ https://lore.barebox.org/barebox \ barebox@lists.infradead.org barebox@lists.infradead.org public-inbox-index barebox Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git