mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>, barebox@lists.infradead.org
Cc: Alexander Shiyan <shc_work@mail.ru>
Subject: Re: [PATCH RESEND v4 4/8] gpio: add driver for 74xx-ICs with MMIO access
Date: Fri, 1 Oct 2021 12:13:00 +0200
Message-ID: <6d5f6568-a43d-2643-53c6-f13e1c57cb98@pengutronix.de> (raw)
In-Reply-To: <20210817101104.114945-5-antonynpavlov@gmail.com>

On 17.08.21 12:11, Antony Pavlov wrote:
> This patch adds driver to support GPIO functionality
> for 74xx-compatible ICs with MMIO access.
> 
> Compatible models include:
>      1 bit:   741G125 (Input), 741G74 (Output)
>      2 bits:  742G125 (Input), 7474 (Output)
>      4 bits:  74125 (Input), 74175 (Output)
>      6 bits:  74365 (Input), 74174 (Output)
>      8 bits:  74244 (Input), 74273 (Output)
>      16 bits: 741624 (Input), 7416374 (Output)
> 
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> Cc: Alexander Shiyan <shc_work@mail.ru>

Acked-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

> ---
>  drivers/gpio/Kconfig          |  14 +++
>  drivers/gpio/Makefile         |   1 +
>  drivers/gpio/gpio-74xx-mmio.c | 165 ++++++++++++++++++++++++++++++++++
>  3 files changed, 180 insertions(+)
> 
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 98a44fbbb5..f79c9ea67d 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -21,6 +21,20 @@ config GPIO_74164
>  	  shift registers. This driver can be used to provide access
>  	  to more gpio outputs.
>  
> +config GPIO_74XX_MMIO
> +	tristate "GPIO driver for 74xx-ICs with MMIO access"
> +	depends on OFDEVICE
> +	select GPIO_GENERIC
> +	help
> +	  Say yes here to support GPIO functionality for 74xx-compatible ICs
> +	  with MMIO access. Compatible models include:
> +	    1 bit:	741G125 (Input), 741G74 (Output)
> +	    2 bits:	742G125 (Input), 7474 (Output)
> +	    4 bits:	74125 (Input), 74175 (Output)
> +	    6 bits:	74365 (Input), 74174 (Output)
> +	    8 bits:	74244 (Input), 74273 (Output)
> +	    16 bits:	741624 (Input), 7416374 (Output)
> +
>  config GPIO_CLPS711X
>  	bool "GPIO support for CLPS711X"
>  	depends on ARCH_CLPS711X || COMPILE_TEST
> diff --git a/drivers/gpio/Makefile b/drivers/gpio/Makefile
> index 638cbb19a3..023973cb63 100644
> --- a/drivers/gpio/Makefile
> +++ b/drivers/gpio/Makefile
> @@ -1,6 +1,7 @@
>  obj-$(CONFIG_GPIOLIB)		+= gpiolib.o
>  
>  obj-$(CONFIG_GPIO_74164)	+= gpio-74164.o
> +obj-$(CONFIG_GPIO_74XX_MMIO)	+= gpio-74xx-mmio.o
>  obj-$(CONFIG_MACH_MIPS_ATH79)	+= gpio-ath79.o
>  obj-$(CONFIG_GPIO_DAVINCI)	+= gpio-davinci.o
>  obj-$(CONFIG_GPIO_CLPS711X)	+= gpio-clps711x.o
> diff --git a/drivers/gpio/gpio-74xx-mmio.c b/drivers/gpio/gpio-74xx-mmio.c
> new file mode 100644
> index 0000000000..5b688f4766
> --- /dev/null
> +++ b/drivers/gpio/gpio-74xx-mmio.c
> @@ -0,0 +1,165 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +/*
> + * 74xx MMIO GPIO driver
> + *
> + *  Copyright (C) 2014 Alexander Shiyan <shc_work@mail.ru>
> + *
> + * Ported to barebox from linux-v5.4-rc6
> + *   Copyright (C) 2019-2021 Antony Pavlov <antonynpavlov@gmail.com>
> + *
> + */
> +
> +#include <common.h>
> +#include <driver.h>
> +#include <errno.h>
> +#include <gpio.h>
> +#include <init.h>
> +#include <io.h>
> +#include <malloc.h>
> +#include <of_device.h>
> +
> +#include <linux/err.h>
> +#include <linux/basic_mmio_gpio.h>
> +
> +#define MMIO_74XX_DIR_IN	(0 << 8)
> +#define MMIO_74XX_DIR_OUT	(1 << 8)
> +#define MMIO_74XX_BIT_CNT(x)	((x) & 0xff)
> +
> +struct mmio_74xx_gpio_priv {
> +	struct bgpio_chip	bgc;
> +	unsigned int		flags;
> +};
> +
> +static const struct of_device_id mmio_74xx_gpio_ids[] = {
> +	{
> +		.compatible	= "ti,741g125",
> +		.data		= (const void *)(MMIO_74XX_DIR_IN | 1),
> +	},
> +	{
> +		.compatible	= "ti,742g125",
> +		.data		= (const void *)(MMIO_74XX_DIR_IN | 2),
> +	},
> +	{
> +		.compatible	= "ti,74125",
> +		.data		= (const void *)(MMIO_74XX_DIR_IN | 4),
> +	},
> +	{
> +		.compatible	= "ti,74365",
> +		.data		= (const void *)(MMIO_74XX_DIR_IN | 6),
> +	},
> +	{
> +		.compatible	= "ti,74244",
> +		.data		= (const void *)(MMIO_74XX_DIR_IN | 8),
> +	},
> +	{
> +		.compatible	= "ti,741624",
> +		.data		= (const void *)(MMIO_74XX_DIR_IN | 16),
> +	},
> +	{
> +		.compatible	= "ti,741g74",
> +		.data		= (const void *)(MMIO_74XX_DIR_OUT | 1),
> +	},
> +	{
> +		.compatible	= "ti,7474",
> +		.data		= (const void *)(MMIO_74XX_DIR_OUT | 2),
> +	},
> +	{
> +		.compatible	= "ti,74175",
> +		.data		= (const void *)(MMIO_74XX_DIR_OUT | 4),
> +	},
> +	{
> +		.compatible	= "ti,74174",
> +		.data		= (const void *)(MMIO_74XX_DIR_OUT | 6),
> +	},
> +	{
> +		.compatible	= "ti,74273",
> +		.data		= (const void *)(MMIO_74XX_DIR_OUT | 8),
> +	},
> +	{
> +		.compatible	= "ti,7416374",
> +		.data		= (const void *)(MMIO_74XX_DIR_OUT | 16),
> +	},
> +	{ }
> +};
> +
> +static inline
> +struct mmio_74xx_gpio_priv *to_mmio_74xx_gpio_priv(struct gpio_chip *gc)
> +{
> +	struct bgpio_chip *bgc =
> +		container_of(gc, struct bgpio_chip, gc);
> +
> +	return container_of(bgc, struct mmio_74xx_gpio_priv, bgc);
> +}
> +
> +static int mmio_74xx_get_direction(struct gpio_chip *gc, unsigned int offset)
> +{
> +	struct mmio_74xx_gpio_priv *priv = to_mmio_74xx_gpio_priv(gc);
> +
> +	if (priv->flags & MMIO_74XX_DIR_OUT)
> +		return GPIOF_DIR_OUT;
> +
> +	return GPIOF_DIR_IN;
> +}
> +
> +static int mmio_74xx_dir_in(struct gpio_chip *gc, unsigned int gpio)
> +{
> +	struct mmio_74xx_gpio_priv *priv = to_mmio_74xx_gpio_priv(gc);
> +
> +	return (priv->flags & MMIO_74XX_DIR_OUT) ? -ENOTSUPP : 0;
> +}
> +
> +static int mmio_74xx_dir_out(struct gpio_chip *gc, unsigned int gpio, int val)
> +{
> +	struct mmio_74xx_gpio_priv *priv = to_mmio_74xx_gpio_priv(gc);
> +
> +	if (priv->flags & MMIO_74XX_DIR_OUT) {
> +		gc->ops->set(gc, gpio, val);
> +		return 0;
> +	}
> +
> +	return -ENOTSUPP;
> +}
> +
> +static int mmio_74xx_gpio_probe(struct device_d *dev)
> +{
> +	struct mmio_74xx_gpio_priv *priv;
> +	void __iomem *dat;
> +	int err;
> +	struct gpio_chip *gc;
> +
> +	priv = xzalloc(sizeof(*priv));
> +
> +	priv->flags = (uintptr_t)of_device_get_match_data(dev);
> +
> +	dat = dev_request_mem_region(dev, 0);
> +	if (IS_ERR(dat))
> +		return PTR_ERR(dat);
> +
> +	err = bgpio_init(&priv->bgc, dev,
> +			 DIV_ROUND_UP(MMIO_74XX_BIT_CNT(priv->flags), 8),
> +			 dat, NULL, NULL, NULL, NULL, 0);
> +	if (err)
> +		return err;
> +
> +	gc = &priv->bgc.gc;
> +	gc->ops->direction_input = mmio_74xx_dir_in;
> +	gc->ops->direction_output = mmio_74xx_dir_out;
> +	gc->ops->get_direction = mmio_74xx_get_direction;
> +	gc->ngpio = MMIO_74XX_BIT_CNT(priv->flags);
> +
> +	dev->priv = priv;
> +
> +	return gpiochip_add(gc);
> +}
> +
> +static struct driver_d mmio_74xx_gpio_driver = {
> +	.name = "74xx-mmio-gpio",
> +	.of_compatible	= DRV_OF_COMPAT(mmio_74xx_gpio_ids),
> +	.probe = mmio_74xx_gpio_probe,
> +};
> +
> +coredevice_platform_driver(mmio_74xx_gpio_driver);
> +
> +MODULE_LICENSE("GPL");
> +MODULE_AUTHOR("Alexander Shiyan <shc_work@mail.ru>");
> +MODULE_DESCRIPTION("74xx MMIO GPIO driver");
> 


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


  reply	other threads:[~2021-10-01 10:14 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-17 10:10 [PATCH RESEND v4 0/8] RISC-V: add LiteX SoC support Antony Pavlov
2021-08-17 10:10 ` [PATCH RESEND v4 1/8] clocksource: timer-riscv: select CSR from device tree Antony Pavlov
2021-08-23 12:08   ` Ahmad Fatoum
2021-08-31  4:07     ` Antony Pavlov
2021-10-01 10:12       ` Ahmad Fatoum
2021-08-17 10:10 ` [PATCH RESEND v4 2/8] serial: add litex UART driver Antony Pavlov
2021-08-23 11:58   ` Ahmad Fatoum
2021-08-17 10:10 ` [PATCH RESEND v4 3/8] console: support set baudrate for fixed baudrate drivers Antony Pavlov
2021-08-23 12:01   ` Ahmad Fatoum
2021-08-17 10:11 ` [PATCH RESEND v4 4/8] gpio: add driver for 74xx-ICs with MMIO access Antony Pavlov
2021-10-01 10:13   ` Ahmad Fatoum [this message]
2021-08-17 10:11 ` [PATCH RESEND v4 5/8] spi: add litex spiflash driver Antony Pavlov
2021-08-23 11:57   ` [PATCH] fixup! " Ahmad Fatoum
2021-10-01 10:13   ` [PATCH RESEND v4 5/8] " Ahmad Fatoum
2021-08-17 10:11 ` [PATCH RESEND v4 6/8] net: add LiteEth driver Antony Pavlov
2021-10-01 10:14   ` Ahmad Fatoum
2021-08-17 10:11 ` [PATCH RESEND v4 7/8] RISC-V: add LiteX SoC and linux-on-litex-vexriscv support Antony Pavlov
2021-08-23 12:06   ` Ahmad Fatoum
2021-08-31  4:38     ` Antony Pavlov
2021-10-01 10:21       ` Ahmad Fatoum
2021-08-17 10:11 ` [PATCH RESEND v4 8/8] RISC-V: add litex_linux_defconfig Antony Pavlov
2021-10-01 10:18   ` Ahmad Fatoum
2021-10-04 12:02 ` [PATCH RESEND v4 0/8] RISC-V: add LiteX SoC support Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6d5f6568-a43d-2643-53c6-f13e1c57cb98@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=antonynpavlov@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=shc_work@mail.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

mail archive of the barebox mailing list

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://lore.barebox.org/barebox/0 barebox/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 barebox barebox/ https://lore.barebox.org/barebox \
		barebox@lists.infradead.org
	public-inbox-index barebox

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git