* [PATCH] ARM: Rockchip: rk3568: add tsadc and spi
@ 2022-02-11 9:11 Frank Wunderlich
2022-02-11 10:43 ` Sascha Hauer
0 siblings, 1 reply; 3+ messages in thread
From: Frank Wunderlich @ 2022-02-11 9:11 UTC (permalink / raw)
To: barebox; +Cc: Frank Wunderlich
From: Frank Wunderlich <frank-w@public-files.de>
Add tsadc and spi node from linux.
Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
arch/arm/dts/rk3568-pinctrl.dtsi | 9 ++++++++
arch/arm/dts/rk3568.dtsi | 35 ++++++++++++++++++++++++++++++++
2 files changed, 44 insertions(+)
diff --git a/arch/arm/dts/rk3568-pinctrl.dtsi b/arch/arm/dts/rk3568-pinctrl.dtsi
index a588ca95ace2..8f90c66dd9e9 100644
--- a/arch/arm/dts/rk3568-pinctrl.dtsi
+++ b/arch/arm/dts/rk3568-pinctrl.dtsi
@@ -3108,4 +3108,13 @@
<4 RK_PA0 3 &pcfg_pull_none_drv_level_2>;
};
};
+
+ tsadc {
+ /omit-if-no-ref/
+ tsadc_pin: tsadc-pin {
+ rockchip,pins =
+ /* tsadc_pin */
+ <0 RK_PA1 0 &pcfg_pull_none>;
+ };
+ };
};
diff --git a/arch/arm/dts/rk3568.dtsi b/arch/arm/dts/rk3568.dtsi
index 0f19d3f0c0c3..6afd95b01c0c 100644
--- a/arch/arm/dts/rk3568.dtsi
+++ b/arch/arm/dts/rk3568.dtsi
@@ -772,6 +772,21 @@
clock-names = "tclk", "pclk";
};
+ spi3: spi@fe640000 {
+ compatible = "rockchip,rk3568-spi", "rockchip,rk3066-spi";
+ reg = <0x0 0xfe640000 0x0 0x1000>;
+ interrupts = <GIC_SPI 106 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cru CLK_SPI3>, <&cru PCLK_SPI3>;
+ clock-names = "spiclk", "apb_pclk";
+ dmas = <&dmac0 26>, <&dmac0 27>;
+ dma-names = "tx", "rx";
+ pinctrl-names = "default";
+ pinctrl-0 = <&spi3m0_cs0 &spi3m0_cs1 &spi3m0_pins>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "disabled";
+ };
+
uart1: serial@fe650000 {
compatible = "rockchip,rk3568-uart", "snps,dw-apb-uart";
reg = <0x0 0xfe650000 0x0 0x100>;
@@ -1030,6 +1045,26 @@
status = "disabled";
};
+ tsadc: tsadc@fe710000 {
+ compatible = "rockchip,rk3568-tsadc";
+ reg = <0x0 0xfe710000 0x0 0x100>;
+ interrupts = <GIC_SPI 115 IRQ_TYPE_LEVEL_HIGH>;
+ assigned-clocks = <&cru CLK_TSADC_TSEN>, <&cru CLK_TSADC>;
+ assigned-clock-rates = <17000000>, <700000>;
+ clocks = <&cru CLK_TSADC>, <&cru PCLK_TSADC>;
+ clock-names = "tsadc", "apb_pclk";
+ resets = <&cru SRST_P_TSADC>, <&cru SRST_TSADC>,
+ <&cru SRST_TSADCPHY>;
+ rockchip,grf = <&grf>;
+ rockchip,hw-tshut-temp = <95000>;
+ pinctrl-names = "init", "default", "sleep";
+ pinctrl-0 = <&tsadc_pin>;
+ pinctrl-1 = <&tsadc_shutorg>;
+ pinctrl-2 = <&tsadc_pin>;
+ #thermal-sensor-cells = <1>;
+ status = "disabled";
+ };
+
saradc: saradc@fe720000 {
compatible = "rockchip,rk3568-saradc";
reg = <0x0 0xfe720000 0x0 0x100>;
--
2.25.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: Rockchip: rk3568: add tsadc and spi
2022-02-11 9:11 [PATCH] ARM: Rockchip: rk3568: add tsadc and spi Frank Wunderlich
@ 2022-02-11 10:43 ` Sascha Hauer
2022-02-11 11:14 ` Frank Wunderlich
0 siblings, 1 reply; 3+ messages in thread
From: Sascha Hauer @ 2022-02-11 10:43 UTC (permalink / raw)
To: Frank Wunderlich; +Cc: barebox, Frank Wunderlich
Hi Frank,
On Fri, Feb 11, 2022 at 10:11:14AM +0100, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
>
> Add tsadc and spi node from linux.
>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
> arch/arm/dts/rk3568-pinctrl.dtsi | 9 ++++++++
> arch/arm/dts/rk3568.dtsi | 35 ++++++++++++++++++++++++++++++++
> 2 files changed, 44 insertions(+)
>
> diff --git a/arch/arm/dts/rk3568-pinctrl.dtsi b/arch/arm/dts/rk3568-pinctrl.dtsi
> index a588ca95ace2..8f90c66dd9e9 100644
> --- a/arch/arm/dts/rk3568-pinctrl.dtsi
> +++ b/arch/arm/dts/rk3568-pinctrl.dtsi
> @@ -3108,4 +3108,13 @@
> <4 RK_PA0 3 &pcfg_pull_none_drv_level_2>;
> };
> };
> +
> + tsadc {
> + /omit-if-no-ref/
> + tsadc_pin: tsadc-pin {
> + rockchip,pins =
> + /* tsadc_pin */
> + <0 RK_PA1 0 &pcfg_pull_none>;
> + };
> + };
> };
> diff --git a/arch/arm/dts/rk3568.dtsi b/arch/arm/dts/rk3568.dtsi
> index 0f19d3f0c0c3..6afd95b01c0c 100644
> --- a/arch/arm/dts/rk3568.dtsi
> +++ b/arch/arm/dts/rk3568.dtsi
> @@ -772,6 +772,21 @@
> clock-names = "tclk", "pclk";
> };
>
> + spi3: spi@fe640000 {
> + compatible = "rockchip,rk3568-spi", "rockchip,rk3066-spi";
> + reg = <0x0 0xfe640000 0x0 0x1000>;
> + interrupts = <GIC_SPI 106 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cru CLK_SPI3>, <&cru PCLK_SPI3>;
> + clock-names = "spiclk", "apb_pclk";
> + dmas = <&dmac0 26>, <&dmac0 27>;
> + dma-names = "tx", "rx";
> + pinctrl-names = "default";
> + pinctrl-0 = <&spi3m0_cs0 &spi3m0_cs1 &spi3m0_pins>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "disabled";
> + };
When you asked me if you should keep tsadc/spi3 in your board dts I
didn't understand that these are missing in rk3568.dtsi.
Adding these nodes when barebox doesn't use them has no gain for us. I
won't take this patch and removed references to spi3/tsadc from your
board patch while applying.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: Rockchip: rk3568: add tsadc and spi
2022-02-11 10:43 ` Sascha Hauer
@ 2022-02-11 11:14 ` Frank Wunderlich
0 siblings, 0 replies; 3+ messages in thread
From: Frank Wunderlich @ 2022-02-11 11:14 UTC (permalink / raw)
To: Sascha Hauer, Frank Wunderlich; +Cc: barebox
Am 11. Februar 2022 11:43:44 MEZ schrieb Sascha Hauer <sha@pengutronix.de>:
>Hi Frank,
>
>On Fri, Feb 11, 2022 at 10:11:14AM +0100, Frank Wunderlich wrote:
>> From: Frank Wunderlich <frank-w@public-files.de>
>>
>> Add tsadc and spi node from linux.
>>
>> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
>> ---
>> arch/arm/dts/rk3568-pinctrl.dtsi | 9 ++++++++
>> arch/arm/dts/rk3568.dtsi | 35
>++++++++++++++++++++++++++++++++
>> 2 files changed, 44 insertions(+)
>>
>> diff --git a/arch/arm/dts/rk3568-pinctrl.dtsi
>b/arch/arm/dts/rk3568-pinctrl.dtsi
>> index a588ca95ace2..8f90c66dd9e9 100644
>> --- a/arch/arm/dts/rk3568-pinctrl.dtsi
>> +++ b/arch/arm/dts/rk3568-pinctrl.dtsi
>> @@ -3108,4 +3108,13 @@
>> <4 RK_PA0 3 &pcfg_pull_none_drv_level_2>;
>> };
>> };
>> +
>> + tsadc {
>> + /omit-if-no-ref/
>> + tsadc_pin: tsadc-pin {
>> + rockchip,pins =
>> + /* tsadc_pin */
>> + <0 RK_PA1 0 &pcfg_pull_none>;
>> + };
>> + };
>> };
>> diff --git a/arch/arm/dts/rk3568.dtsi b/arch/arm/dts/rk3568.dtsi
>> index 0f19d3f0c0c3..6afd95b01c0c 100644
>> --- a/arch/arm/dts/rk3568.dtsi
>> +++ b/arch/arm/dts/rk3568.dtsi
>> @@ -772,6 +772,21 @@
>> clock-names = "tclk", "pclk";
>> };
>>
>> + spi3: spi@fe640000 {
>> + compatible = "rockchip,rk3568-spi", "rockchip,rk3066-spi";
>> + reg = <0x0 0xfe640000 0x0 0x1000>;
>> + interrupts = <GIC_SPI 106 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&cru CLK_SPI3>, <&cru PCLK_SPI3>;
>> + clock-names = "spiclk", "apb_pclk";
>> + dmas = <&dmac0 26>, <&dmac0 27>;
>> + dma-names = "tx", "rx";
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&spi3m0_cs0 &spi3m0_cs1 &spi3m0_pins>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + status = "disabled";
>> + };
>
>When you asked me if you should keep tsadc/spi3 in your board dts I
>didn't understand that these are missing in rk3568.dtsi.
>Adding these nodes when barebox doesn't use them has no gain for us. I
>won't take this patch and removed references to spi3/tsadc from your
>board patch while applying.
>
>Sascha
Hi,
I understood it,that when you take the mainline-linux dts it will not find spi3 and tsadc in rk3568.dtsi. Or do you plan to sync this too?
regards Frank
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-11 11:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-11 9:11 [PATCH] ARM: Rockchip: rk3568: add tsadc and spi Frank Wunderlich
2022-02-11 10:43 ` Sascha Hauer
2022-02-11 11:14 ` Frank Wunderlich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox