From: Vyacheslav Yurkov <uvv.mail@gmail.com>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>, barebox@lists.infradead.org
Cc: Vyacheslav Yurkov <Vyacheslav.Yurkov@bruker.com>
Subject: Re: [PATCH 1/2] ARM: socfpga: Fix SDRAM firewall init
Date: Tue, 1 Nov 2022 11:05:49 +0100 [thread overview]
Message-ID: <92804731-f7bf-cb4c-dfea-73955fac9351@gmail.com> (raw)
In-Reply-To: <779f4d6e-7ba8-973b-0097-f98cbce0dc1e@pengutronix.de>
Hi Ahmad,
The access of FPGA IPs to SDRAM regions is now possible. The region
filters were already set correctly, only 'enable' bits were not. I split
the fix into two patches, because they fix different sub-problems of one
issue.
Regards,
Slava
On 01.11.2022 10:58, Ahmad Fatoum wrote:
> Hello Slava,
>
> On 01.11.22 10:52, Vyacheslav Yurkov wrote:
>> From: Vyacheslav Yurkov <Vyacheslav.Yurkov@bruker.com>
>>
>> Incorrect enable bits were used in initialization sequence of SDRAM
>> firewall
> Thanks for your patch.
>
> It'd be useful to know what implications the incorrect enable bits had.
> What didn't work that now does?
>
> Cheers,
> Ahmad
>
>> Signed-off-by: Vyacheslav Yurkov <Vyacheslav.Yurkov@bruker.com>
>> ---
>> arch/arm/mach-socfpga/arria10-sdram.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/arm/mach-socfpga/arria10-sdram.c b/arch/arm/mach-socfpga/arria10-sdram.c
>> index 35c355df71..b7eade0b17 100644
>> --- a/arch/arm/mach-socfpga/arria10-sdram.c
>> +++ b/arch/arm/mach-socfpga/arria10-sdram.c
>> @@ -486,7 +486,7 @@ static int arria10_sdram_firewall_setup(void)
>> writel(0x00000000, ARRIA10_SDR_FW_MPU_FPGA_MPUREGION3ADDR);
>> writel(0xffff0000, ARRIA10_SDR_FW_MPU_FPGA_FPGA2SDRAM0REGION0ADDR);
>>
>> - mpu_en |= ARRIA10_NOC_FW_DDR_MPU_MPUREG1EN;
>> + mpu_en |= ARRIA10_NOC_FW_DDR_MPU_F2SDR0REG0EN;
>> writel(mpu_en, ARRIA10_SDR_FW_MPU_FPGA_EN);
>>
>> writel(0x00000000, ARRIA10_SDR_FW_MPU_FPGA_FPGA2SDRAM0REGION1ADDR);
>> @@ -494,7 +494,7 @@ static int arria10_sdram_firewall_setup(void)
>> writel(0x00000000, ARRIA10_SDR_FW_MPU_FPGA_FPGA2SDRAM0REGION3ADDR);
>> writel(0xffff0000, ARRIA10_SDR_FW_MPU_FPGA_FPGA2SDRAM1REGION0ADDR);
>>
>> - mpu_en |= ARRIA10_NOC_FW_DDR_MPU_MPUREG2EN;
>> + mpu_en |= ARRIA10_NOC_FW_DDR_MPU_F2SDR1REG0EN;
>> writel(mpu_en, ARRIA10_SDR_FW_MPU_FPGA_EN);
>>
>> writel(0x00000000, ARRIA10_SDR_FW_MPU_FPGA_FPGA2SDRAM1REGION1ADDR);
>> @@ -502,7 +502,7 @@ static int arria10_sdram_firewall_setup(void)
>> writel(0x00000000, ARRIA10_SDR_FW_MPU_FPGA_FPGA2SDRAM1REGION3ADDR);
>> writel(0xffff0000, ARRIA10_SDR_FW_MPU_FPGA_FPGA2SDRAM2REGION0ADDR);
>>
>> - mpu_en |= ARRIA10_NOC_FW_DDR_MPU_MPUREG3EN;
>> + mpu_en |= ARRIA10_NOC_FW_DDR_MPU_F2SDR2REG0EN;
>> writel(mpu_en, ARRIA10_SDR_FW_MPU_FPGA_EN);
>>
>> writel(0x00000000, ARRIA10_SDR_FW_MPU_FPGA_FPGA2SDRAM2REGION1ADDR);
next prev parent reply other threads:[~2022-11-01 10:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 9:52 Vyacheslav Yurkov
2022-11-01 9:52 ` [PATCH 2/2] ARM: socfpga: Configure F2SDRAM bridges Vyacheslav Yurkov
2022-11-01 9:58 ` [PATCH 1/2] ARM: socfpga: Fix SDRAM firewall init Ahmad Fatoum
2022-11-01 10:05 ` Vyacheslav Yurkov [this message]
2022-11-01 10:13 ` Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92804731-f7bf-cb4c-dfea-73955fac9351@gmail.com \
--to=uvv.mail@gmail.com \
--cc=Vyacheslav.Yurkov@bruker.com \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox