From: Ahmad Fatoum <a.fatoum@pengutronix.de> To: Frank Wunderlich <frank-w@public-files.de> Cc: Sascha Hauer <sha@pengutronix.de>, barebox@lists.infradead.org Subject: Re: Aw: Re: Re: Re: Driver load order Date: Tue, 24 May 2022 11:21:11 +0200 [thread overview] Message-ID: <97925f64-37cc-9691-3621-3b3746325fe2@pengutronix.de> (raw) In-Reply-To: <trinity-f7ff0d03-ce5d-4ce6-811b-aa7adc2a9179-1653383588438@3c-app-gmx-bs50> Hi Frank, On 24.05.22 11:13, Frank Wunderlich wrote: > as far as i looked into the linux driver and the binding-conversion [1] i think adding those fields is not enough > as the supply needs to be set from the upper values (vccX-supply) of the rk808 pmic. > > in core it seems that this recursion is not implemented yet (like the check for rdev->supply) > > from binding i mean this part: > > vcc1-supply: The input supply for DCDC_REG1 > vcc2-supply: The input supply for DCDC_REG2 > vcc3-supply: The input supply for DCDC_REG3 > vcc4-supply: The input supply for DCDC_REG4 > vcc6-supply: The input supply for LDO_REG1 and LDO_REG2 > vcc7-supply: The input supply for LDO_REG3 and LDO_REG7 > vcc8-supply: The input supply for SWITCH_REG1 > vcc9-supply: The input supply for LDO_REG4 and LDO_REG5 > vcc10-supply: The input supply for LDO_REG6 > vcc11-supply: The input supply for LDO_REG8 Please don't top-post. It makes it harder to follow the conversation. Quoting from below: >> Ah, I missed b8074eba2a6b ("regulator: RK808: Add proper input supplies >> for rk808"). I recall now that I had ported an older version of the Linux >> driver to make porting work easier. >> >> You should probably add a supply_name member into struct regulator_desc >> and then propagate this to core, so core can request it. I have no time currently to spend on Rockchip support, but I am happy to review patches improving it. Cheers, Ahmad -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2022-05-24 9:22 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-19 10:59 Frank Wunderlich 2022-05-19 11:54 ` Sascha Hauer 2022-05-19 12:43 ` Aw: " Frank Wunderlich 2022-05-19 12:50 ` Ahmad Fatoum 2022-05-19 13:10 ` Sascha Hauer 2022-05-19 17:54 ` Aw: " Frank Wunderlich 2022-05-21 10:31 ` Frank Wunderlich 2022-05-24 8:53 ` Ahmad Fatoum 2022-05-24 9:13 ` Aw: " Frank Wunderlich 2022-05-24 9:21 ` Ahmad Fatoum [this message] 2022-05-19 12:10 ` [PATCH 1/2] regmap: implement regmap_init_i2c_smbus Ahmad Fatoum 2022-05-19 12:10 ` [PATCH 2/2] regulator: add Rockchip rk808 support Ahmad Fatoum 2022-05-19 12:17 ` Driver load order Ahmad Fatoum 2022-05-19 12:42 ` Ahmad Fatoum
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=97925f64-37cc-9691-3621-3b3746325fe2@pengutronix.de \ --to=a.fatoum@pengutronix.de \ --cc=barebox@lists.infradead.org \ --cc=frank-w@public-files.de \ --cc=sha@pengutronix.de \ --subject='Re: Aw: Re: Re: Re: Driver load order' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox