mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Frank Wunderlich <frank-w@public-files.de>,
	Sascha Hauer <sha@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: Aw: Re: Re: Driver load order
Date: Tue, 24 May 2022 10:53:12 +0200	[thread overview]
Message-ID: <da75544b-8a44-9c0e-f3bc-1bf216523ed2@pengutronix.de> (raw)
In-Reply-To: <trinity-58fee77a-48b6-48ff-99a5-8eaa6c480d0b-1653129114535@3c-app-gmx-bs49>

Hello Frank,

On 21.05.22 12:31, Frank Wunderlich wrote:
> Hi,
> 
> current state is that pmu/ldo regulators work, but not the SWITCH ones.
> 
> these are read by linux using the supply of the regulator itself
> 
> 	} else if (rdev->supply) {
> 		ret = regulator_get_voltage_rdev(rdev->supply->rdev);
> 
> tried to port this to barebox, but regulator-struct there does not have the supply member
> 
> 	} else if (rdev->supply) {
> 		ret = regulator_get_voltage(rdev->supply);
> 
> so i added it here:
> 
> +++ b/include/regulator.h
> @@ -86,6 +86,7 @@ struct regulator_dev {
>         struct regmap *regmap;
>         bool boot_on;
>         bool always_on;
> +       struct regulator *supply;

I think this should go into struct regulator_internal instead?
(You'll need to rename the current const char *supply there).

>         /* the device this regulator device belongs to */
>         struct device_d *dev;
> 
> but now this needs to be set somwhere...linux set this in
> 
> set_supply(struct regulator_dev *rdev,
> 		      struct regulator_dev *supply_rdev)
> which is called in regulator_resolve_supply (called by _regulator_get).

Ah, I missed b8074eba2a6b ("regulator: RK808: Add proper input supplies
for rk808"). I recall now that I had ported an older version of the Linux
driver to make porting work easier. 

You should probably add a supply_name member into struct regulator_desc
and then propagate this to core, so core can request it.

Cheers,
Ahmad

> 
> regards Frank
> 
> 
>> Gesendet: Donnerstag, 19. Mai 2022 um 15:10 Uhr
>> Von: "Sascha Hauer" <sha@pengutronix.de>
>> I gave it a test with your rk808 driver. It just works \o/
>>
>> regulator_get() triggers probing of the rk808 regulator driver and
>> returns a valid regulator.
>>
>> Sascha
> 
> 


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


  reply	other threads:[~2022-05-24  8:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-19 10:59 Frank Wunderlich
2022-05-19 11:54 ` Sascha Hauer
2022-05-19 12:43   ` Aw: " Frank Wunderlich
2022-05-19 12:50     ` Ahmad Fatoum
2022-05-19 13:10       ` Sascha Hauer
2022-05-19 17:54         ` Aw: " Frank Wunderlich
2022-05-21 10:31         ` Frank Wunderlich
2022-05-24  8:53           ` Ahmad Fatoum [this message]
2022-05-24  9:13             ` Aw: " Frank Wunderlich
2022-05-24  9:21               ` Ahmad Fatoum
2022-05-19 12:10 ` [PATCH 1/2] regmap: implement regmap_init_i2c_smbus Ahmad Fatoum
2022-05-19 12:10   ` [PATCH 2/2] regulator: add Rockchip rk808 support Ahmad Fatoum
2022-05-19 12:17 ` Driver load order Ahmad Fatoum
2022-05-19 12:42   ` Ahmad Fatoum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=da75544b-8a44-9c0e-f3bc-1bf216523ed2@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=frank-w@public-files.de \
    --cc=sha@pengutronix.de \
    --subject='Re: Aw: Re: Re: Driver load order' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox